From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-35357-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 3031 invoked by alias); 2 Jun 2015 05:47:54 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 35357
Received: (qmail 20237 invoked from network); 2 Jun 2015 05:47:50 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2
	autolearn=ham autolearn_force=no version=3.4.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type;
        bh=AwfR55R8MUS2OYoWzDIQqO4yBXH1n6Gxavi78vt/di0=;
        b=TLxt7fnK1X0aKf00VeTOOYQqNZrdFBvUJ3eIyncaKPv9X6c+MmV0ZNDaPtDU9YqInv
         MDw9oULLnUJCZ+Jiasx+O+j0E9CA7flzojS+NQO3dJYnNVaCV+oUgh1ux8MdinZg8OgJ
         vOYyJiN2rq7H3U8akAaYx7CbCFmJl7edC6YstuB09dT/xwfDqlbVS/WlWlZ9hxdp1b/+
         mssr6jEoGCI5niRogRqvuGyXr2k2XpIeCQ7MPoCgpoLJNoo4sufBIy+F4lf0IOVYVlRM
         rol+1qxRCQIF32vE4u3QmTTOulk9VY+mysQBuNjWLUvsR+9ivVZZ9nCDJXaQMhKKP615
         uL3Q==
X-Received: by 10.112.27.238 with SMTP id w14mr14673200lbg.80.1433224066806;
 Mon, 01 Jun 2015 22:47:46 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAPKC6oJ0fOEeg1--qpufEYQoxTeUnD8KDNSHV5Sfn7J4EtPYCw@mail.gmail.com>
References: <20150531192334.26a88ef9@ntlworld.com> <150531171724.ZM29828@torch.brasslantern.com>
 <CAPKC6oJ0fOEeg1--qpufEYQoxTeUnD8KDNSHV5Sfn7J4EtPYCw@mail.gmail.com>
From: Baptiste Daroussin <baptiste.daroussin@gmail.com>
Date: Tue, 2 Jun 2015 07:47:25 +0200
Message-ID: <CAPKC6oLgaSB=emT-hXCZ7=Hp5fQWnLzYRZE1NHmqCpi==uK64g@mail.gmail.com>
Subject: Re: zsh 5.0.8 available (preliminary announcement)
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Content-Type: multipart/mixed; boundary=001a1133bb34630e070517827bcb

--001a1133bb34630e070517827bcb
Content-Type: text/plain; charset=UTF-8

2015-06-02 0:13 GMT+02:00 Baptiste Daroussin <baptiste.daroussin@gmail.com>:
> 2015-06-01 2:17 GMT+02:00 Bart Schaefer <schaefer@brasslantern.com>:
>> On May 31,  7:23pm, Peter Stephenson wrote:
>> }
>> } Please could people have a quick check there's nothing major broken
>> } before I announce it more widely.
>>
>> Passes "make check" on Ubuntu 12.04.5 and MacOS 10.9.5 (gnu tools).
>
> On FreeBSD I have 5 tests failing (actually for a couple of release of
> zsh) all related to zpty.
>
> This time I found time to analyse the code.
>
> It appears that freebsd has posix_openpt, but the code using that only
> used if USE_DEV_PTMX is defined (which is not on FreeBSD)
>
> Switching the #ifdef USE_DEV_PTMX line 157 to:
>
> #if defined(HAVE_POSIX_OPENPT) || defined(USE_DEV_PTMX)
>
>
> after doing that all tests passes.
>
> regards,
> Bapt

Here is the patch for this

regards,
Bapt

--001a1133bb34630e070517827bcb
Content-Type: text/x-patch; charset=US-ASCII; 
	name="0001-Allow-to-use-the-get_pty-code-using-posix_openpt-on-.patch"
Content-Disposition: attachment; 
	filename="0001-Allow-to-use-the-get_pty-code-using-posix_openpt-on-.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_iaewl3p10

RnJvbSBhYTIzODhjOTc1YjBlMzc0MTU5OWY4OTM1OGU1ZmE4ZTExZjU3ZTIzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBCYXB0aXN0ZSBEYXJvdXNzaW4gPGJhcHRARnJlZUJTRC5vcmc+
CkRhdGU6IFR1ZSwgMiBKdW4gMjAxNSAwNzo0NDowOSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIEFs
bG93IHRvIHVzZSB0aGUgZ2V0X3B0eSBjb2RlIHVzaW5nIHBvc2l4X29wZW5wdCBvbiBzeXN0ZW1z
CiB3aXRob3V0IC9kZXYvcHRteAoKLS0tCiBTcmMvTW9kdWxlcy96cHR5LmMgfCAyICstCiAxIGZp
bGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9T
cmMvTW9kdWxlcy96cHR5LmMgYi9TcmMvTW9kdWxlcy96cHR5LmMKaW5kZXggN2I2MTMwYy4uYTc3
YjBkZiAxMDA2NDQKLS0tIGEvU3JjL01vZHVsZXMvenB0eS5jCisrKyBiL1NyYy9Nb2R1bGVzL3pw
dHkuYwpAQCAtMTU0LDcgKzE1NCw3IEBAIGdldHB0eWNtZChjaGFyICpuYW1lKQogICAgIHJldHVy
biBOVUxMOwogfQogCi0jaWZkZWYgVVNFX0RFVl9QVE1YCisjaWYgZGVmaW5lZChVU0VfREVWX1BU
TVgpIHx8IGRlZmluZWQoSEFWRV9QT1NJWF9PUEVOUFQpCiAKICNpZmRlZiBIQVZFX1NZU19TVFJP
UFRTX0gKICNpbmNsdWRlIDxzeXMvc3Ryb3B0cy5oPgotLSAKMi40LjIKCg==
--001a1133bb34630e070517827bcb--