From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1284 invoked by alias); 2 Oct 2015 19:59:36 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 36750 Received: (qmail 22155 invoked from network); 2 Oct 2015 19:59:35 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 X-Biglobe-Sender: Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: PATCH: zle -f from inside widget to set flags and make yank start/end zle params writable From: "Jun T." In-Reply-To: Date: Sat, 3 Oct 2015 04:58:57 +0900 Content-Transfer-Encoding: 7bit Message-Id: References: <1443578812-18807-1-git-send-email-mikachu@gmail.com> <4556E6A0-3A89-4C0F-A359-3CA25E764761@kba.biglobe.ne.jp> <5E5C5064-FD62-44B8-B6B0-02FB5A70BC30@kba.biglobe.ne.jp> To: zsh-workers@zsh.org X-Mailer: Apple Mail (2.1878.6) X-Biglobe-Spnum: 55182 2015/10/03 03:43, Mikael Magnusson wrote: > I moved the definition up so it's not used before being defined instead. It's been pushed already so this is just a comment but, in general, it would be better to use zle_usable(void) because then the correct prototype is generated in zle_thingy.pro and, in the future, anyone can call zle_usable() from anywhere in zle_thingy.c. I think it's the main reason that there is a /**/ in front of the definition. But there are several functions in the zsh source which are defined as func() instead of func(void). So we may not need to be so strict here.