From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: (qmail 9376 invoked from network); 15 Apr 2020 02:05:58 -0000 Received-SPF: pass (primenet.com.au: domain of zsh.org designates 203.24.36.2 as permitted sender) receiver=inbox.vuxu.org; client-ip=203.24.36.2 envelope-from= Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with UTF8ESMTPZ; 15 Apr 2020 02:05:58 -0000 Received: (qmail 28226 invoked by alias); 15 Apr 2020 02:05:44 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45701 Received: (qmail 26191 invoked by uid 1010); 15 Apr 2020 02:05:44 -0000 X-Qmail-Scanner-Diagnostics: from mail-qk1-f193.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.2/25779. spamassassin: 3.4.4. Clear:RC:0(209.85.222.193):SA:0(-2.7/5.0):. Processed in 2.77858 secs); 15 Apr 2020 02:05:44 -0000 X-Envelope-From: dana@dana.is X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.222.193 as permitted sender) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=RwxWIZCl1nG32mNAFHRNtMb82LFjqHXbOf08b9xtIk0=; b=NqiFEzeE6LePmn+JoX17/GGBGsR1j8VHQjGeoB9Vk2SxEu6hgtahdQ0loEfkm38Krd PIfaLGTf9Y8O+iLg/mmKD7GoBt+0XP0IPiXiTnq4pXOwHL8oJuAPwuSowaKwr2YiC5II LydEym66V4SYPPz3e5fW+iQv0NQ2hzaU5FC/FsrnliPuayN0PaTBxg+onV3ERrX7C2VH TCzY9kurZjqAmZbzTqUs6I96BczD8ki05SDZjJYKYNV84wFK7Q9XLj/wcMJ9ZHPE+OIW 8lSFBPUlBicvGW3t2yqrEjaTnZYwIaa2wzo4Pvi6GqaS3/DnSwS3OtpmjPB31qzwNRvo 4UKQ== X-Gm-Message-State: AGi0PuaCLyqR4QFIjt5YiL00B7yW1yF6sOXoDDmSx28HQG7wro+CHmIY E8RLL+L/17fCIMe1ZzjeocopEw== X-Google-Smtp-Source: APiQypJkGtOxAasrRLDKdoIkTTNQTvYxQS/glYXCFy0rSDLRjPnv5SYdQbOaxxfRuRTi9YNEQtW19w== X-Received: by 2002:a37:6585:: with SMTP id z127mr22676106qkb.203.1586916307691; Tue, 14 Apr 2020 19:05:07 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) Subject: Re: [PATCH] Enable sub-second timeout in zsystem flock From: dana In-Reply-To: <20200415011530.2b8f3ed3@tarpaulin.shahaf.local2> Date: Tue, 14 Apr 2020 21:05:03 -0500 Cc: Cedric Ware , zsh-workers@zsh.org Content-Transfer-Encoding: 7bit Message-Id: References: <20200308183907.mxnhqrr2uflwooax@phare.normalesup.org> <20200314210454.hp562smyqv3ew255@phare.normalesup.org> <20200315005036.45bc846b@tarpaulin.shahaf.local2> <20200315160324.dstgtmajzwxpaccn@phare.normalesup.org> <20200315165410.GA30241@tarpaulin.shahaf.local2> <20200413213449.orqym5bqboznancl@phare.normalesup.org> <20200414114700.108febf3@tarpaulin.shahaf.local2> <20200414202100.x7fxbf3liwbyclpe@phare.normalesup.org> <20200415011530.2b8f3ed3@tarpaulin.shahaf.local2> To: Daniel Shahaf X-Mailer: Apple Mail (2.3608.60.0.2.5) On 14 Apr 2020, at 20:15, Daniel Shahaf wrote: > dana, would you happen to have time to review the Cedric's latest > revision (workers/45690)? I'm not sure i fully understand the implications of the 32-vs-64-bit stuff, nor whether it matters enough to go to all the extra trouble. But aside from that and the two bits you mentioned (agreed on the semicolon), the only thing i noticed is that there are several instances where the formatting of the new C code doesn't match its surroundings, e.g. unnecessary brackets in ((foo < bar) || (baz > qux)) and inconsistent white space in foo? bar : baz Otherwise i think it makes sense, as far as i understand it, and the tests pass on my machine. I don't see any functional issues dana