ZSH 4.1.1 Coredump bug

ZSH 4.1.1 Coredump bug

[Marius van Wyk]

Starting clean from bash:

[marius@boa-constructor /home/marius]$ zsh --version
zsh 4.1.1 (i686-pc-linux-gnu)
[marius@boa-constructor /home/marius]$ zsh -f
boa-constructor% compctl -f -x 'p[2]' -s "`/bin/ls /bin`" --open
Segmentation fault (core dumped)

(Note: I typed '--open' instead of '-- open')

Also:

[marius@boa-constructor /home/marius]$ gcc -v
Reading specs from /usr/lib/gcc-lib/i386-redhat-linux/2.96/specs
gcc version 2.96 20000731 (Red Hat Linux 7.2 2.96-112.7.1)

[marius@boa-constructor /home/marius]$ uname -a
Linux boa-constructor.org 2.4.20-020stab009.8.777-enterprise #1 SMP Tue 
Jan 6 12:34:23 MSK 2004 i686 unknown


Regards,
Marius.

-- 
Director,
Tangible Business Software

Re: ZSH 4.1.1 Coredump bug

[Oliver Kiddle]

Marius van Wyk wrote:
> [marius@boa-constructor /home/marius]$ zsh -f
> boa-constructor% compctl -f -x 'p[2]' -s "`/bin/ls /bin`" --open
> Segmentation fault (core dumped)

This should fix it.

Index: Src/Zle/compctl.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/compctl.c,v
retrieving revision 1.16
diff -u -r1.16 compctl.c
--- Src/Zle/compctl.c	13 Nov 2003 14:34:38 -0000	1.16
+++ Src/Zle/compctl.c	15 Feb 2004 12:29:35 -0000
@@ -857,7 +857,7 @@
 		}
 		break;
 	    default:
-		if (!first && (**argv == '-' || **argv == '+'))
+		if (!first && (**argv == '-' || **argv == '+') && !argv[0][1])
 		    (*argv)--, argv--, ready = 1;
 		else {
 		    zwarnnam(name, "bad option: -%c", NULL, **argv);

Re: ZSH 4.1.1 Coredump bug

[Marius van Wyk]

On 15 Feb 2004, at 14:48, Oliver Kiddle wrote:

> Marius van Wyk wrote:
>> [marius@boa-constructor /home/marius]$ zsh -f
>> boa-constructor% compctl -f -x 'p[2]' -s "`/bin/ls /bin`" --open
>> Segmentation fault (core dumped)
>
> This should fix it.

I updated the file, then did a 'make clean; make'
Then I ran zsh again, and entered:

~> compctl -f -x 'p[2]' -s "`/bin/ls /bin`" --open

Same thing. SIGSEGV.
Strange.

Me.

>
> Index: Src/Zle/compctl.c
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Src/Zle/compctl.c,v
> retrieving revision 1.16
> diff -u -r1.16 compctl.c
> --- Src/Zle/compctl.c	13 Nov 2003 14:34:38 -0000	1.16
> +++ Src/Zle/compctl.c	15 Feb 2004 12:29:35 -0000
> @@ -857,7 +857,7 @@
>  		}
>  		break;
>  	    default:
> -		if (!first && (**argv == '-' || **argv == '+'))
> +		if (!first && (**argv == '-' || **argv == '+') && !argv[0][1])
>  		    (*argv)--, argv--, ready = 1;
>  		else {
>  		    zwarnnam(name, "bad option: -%c", NULL, **argv);
>
-- 
Director,
Tangible Business Software

Re: ZSH 4.1.1 Coredump bug

[Marius van Wyk]

Sorry, my mistake.

When I did a "gdb ./zsh ../core" I noticed it crashed in:

(gdb) bt
#0  0x401eed00 in compctlread () from 
/usr/local/lib/zsh/4.1.1/zsh/compctl.so

And so I realised that compctl is a separate module and not part of the 
zsh executable. (Didn't know this before)

I updated the module, and voilla! It worked.
Sorry for my last mail.

Regards,
Marius.


On 15 Feb 2004, at 14:48, Oliver Kiddle wrote:

> Marius van Wyk wrote:
>> [marius@boa-constructor /home/marius]$ zsh -f
>> boa-constructor% compctl -f -x 'p[2]' -s "`/bin/ls /bin`" --open
>> Segmentation fault (core dumped)
>
> This should fix it.
>
> Index: Src/Zle/compctl.c
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Src/Zle/compctl.c,v
> retrieving revision 1.16
> diff -u -r1.16 compctl.c
> --- Src/Zle/compctl.c	13 Nov 2003 14:34:38 -0000	1.16
> +++ Src/Zle/compctl.c	15 Feb 2004 12:29:35 -0000
> @@ -857,7 +857,7 @@
>  		}
>  		break;
>  	    default:
> -		if (!first && (**argv == '-' || **argv == '+'))
> +		if (!first && (**argv == '-' || **argv == '+') && !argv[0][1])
>  		    (*argv)--, argv--, ready = 1;
>  		else {
>  		    zwarnnam(name, "bad option: -%c", NULL, **argv);
>
-- 
Director,
Tangible Business Software