zsh-workers
 help / color / mirror / code / Atom feed
From: "Karel Balej" <balejk@matfyz.cz>
To: "Bart Schaefer" <schaefer@brasslantern.com>
Cc: <zsh-workers@zsh.org>
Subject: Re: [RFC PATCH 1/2] complete absolute paths for mpc add
Date: Mon, 11 Nov 2024 20:26:04 +0100	[thread overview]
Message-ID: <D5JLH3KU97MD.23SM64QMYC20J@matfyz.cz> (raw)
In-Reply-To: <CAH+w=7YmmvYqdnNzbLRJd6y5pgNj0ceD=PhjeHiN4A5FtOf8jQ@mail.gmail.com>

Bart Schaefer, 2024-11-10T15:10:55-08:00:
> On Sun, Nov 10, 2024 at 10:56 AM Karel Balej <balejk@matfyz.cz> wrote:
> >... possibly simpler to just have _mpc_helper_files fail on no matches
> > and have the completion fall back to _files only then?
>
> If, when _mpc_helper_files does find something, you don't mind
> skipping files that _mpc_helper_files does not find, you can certainly
> do that.

Actually that isn't really better because only absolute paths should be
completed via _files.

So if you have no further comments, I can submit the original patches
updated with the ret handling.

Thank you,
K. B.


  reply	other threads:[~2024-11-11 19:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-27 16:31 Karel Balej
2024-09-27 16:31 ` [RFC PATCH 2/2] enable completion for mpc insert Karel Balej
2024-11-09 15:21 ` [RFC PATCH 1/2] complete absolute paths for mpc add Karel Balej
2024-11-09 19:44 ` Bart Schaefer
2024-11-10 18:56   ` Karel Balej
2024-11-10 23:10     ` Bart Schaefer
2024-11-11 19:26       ` Karel Balej [this message]
2024-11-12  2:52         ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D5JLH3KU97MD.23SM64QMYC20J@matfyz.cz \
    --to=balejk@matfyz.cz \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).