zsh-workers
 help / color / mirror / code / Atom feed
From: Zefram <zefram@fysh.org>
To: schaefer@candle.brasslantern.com (Bart Schaefer)
Cc: pws@ifh.de, zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: 3.1.6-pws-3: more getopts bugs
Date: Fri, 10 Sep 1999 17:54:51 +0100 (BST)	[thread overview]
Message-ID: <E11PTwp-0003pi-00@crucigera.fysh.org> (raw)
In-Reply-To: <990910163224.ZM17291@candle.brasslantern.com> from Bart Schaefer at "Sep 10, 1999  4:32:24 pm"

Bart Schaefer wrote:
>This also works as expected in 3.0.6.  I wonder what bugs Zefram removed?

I don't remember exactly; ISTR there being a bunch of fencepost errors,
error handling errors, errors handling unusual cases and so on.  The code
was so messy that it was easier to start from scratch -- most patches
to that code were introducing new errors while fixing the old ones.
Of course, getopts is a particularly bad design, so the code can't help
being messy to some extent.

>Restarting on OPTIND=0 must be one of the bugs Zefram fixed, but maybe
>he shouldn't have taken out the reset of optcind upon failure return?

Probably.  I remember having some difficulty working out where optcind
should be reset -- it's all very implicit in the POSIX definition.

-zefram


      reply	other threads:[~1999-09-10 16:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-09-10  9:21 Peter Stephenson
1999-09-10 16:32 ` Bart Schaefer
1999-09-10 16:54   ` Zefram [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E11PTwp-0003pi-00@crucigera.fysh.org \
    --to=zefram@fysh.org \
    --cc=pws@ifh.de \
    --cc=schaefer@candle.brasslantern.com \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).