zsh-workers
 help / color / mirror / code / Atom feed
From: Zefram <zefram@fysh.org>
To: schaefer@candle.brasslantern.com (Bart Schaefer)
Cc: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: mod_export keyword
Date: Thu, 2 Dec 1999 17:28:33 +0000 (GMT)	[thread overview]
Message-ID: <E11ta1x-0003MD-00@crucigera.fysh.org> (raw)
In-Reply-To: <991202171156.ZM8320@candle.brasslantern.com> from Bart Schaefer at "Dec 2, 1999  5:11:56 pm"

Bart Schaefer wrote:
>I can't say that I like this very much from a coding style perspective.
>Wouldn't it have been equally effective to, for example, change the
>leading comment marker from /**/ to /*export*/ for these symbols?

Funnily enough, I remember originally using /*L*/ to mark local symbols.
Now they have the same comment marker, and makepro.awk picks up on the
"static", which avoids having to indicate the same thing twice.  I used
a pseudo-keyword here to make it all consistent -- each declaration
starts with a keyword (or lack thereof) to indicate its scope, and /**/
is there strictly to draw makepro.awk's attention to relevant lines.
I see your point -- mod_export is effectively modifying the language --
but I'd rather keep it consistent.  And we are in fact extending the
language with this extra scope; I'd rather that was invoked through a
keyword than through magic comments.

-zefram


      reply	other threads:[~1999-12-02 17:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-12-01 18:33 zefram
1999-12-02 17:11 ` Bart Schaefer
1999-12-02 17:28   ` Zefram [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E11ta1x-0003MD-00@crucigera.fysh.org \
    --to=zefram@fysh.org \
    --cc=schaefer@candle.brasslantern.com \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).