From: Peter Stephenson <pws@pwstephenson.fsnet.co.uk>
To: zsh-workers@sunsite.auc.dk
Subject: Re: Problems with trap handling?
Date: Tue, 01 Feb 2000 18:45:18 +0000 [thread overview]
Message-ID: <E12FiFo-0003rR-00.2000-02-01-18-42-20@cmailg7.svr.pol.co.uk> (raw)
In-Reply-To: "Sven Wischnowsky"'s message of "Mon, 31 Jan 2000 13:07:45 +0100." <200001311207.NAA01858@beta.informatik.hu-berlin.de>
Sven Wischnowsky wrote:
> Bart Schaefer wrote:
> > function tst() {
> > trap return INT
> > read -q xx'?Type ^C here: '
> > echo You should not see this.
> > }
> >
> > Execute in 3.1.6-dev-16 and type ^C. Note that you don't leave the "read"
> > prompt. Type any plain character; now "read" returns, and the function
> > aborts as if interrupted.
>
> In this incanartion read ends up in read1char() which explicitly does
> *not* stop if the read returns with errno==EINTR. So I guess someone
> had a reason for doing this way.
>
> We could either test retflag/breaks/contflag there or give it a flag
> that says to stop in case of EINTR and which would be set by bin_read
> (via getquery()).
I think the answer is it should be testing more flags at this point:
whatever's making the function return (i.e. retflag) should make the read
return, too. It's certainly correct that EINTR shouldn't make it return ---
the problem was that the query aborted if, say, a background job exited,
and as far as I can see the same issue applies to any call to read1char().
It's quite possible the same issue comes up at umpteen other places in the
code, alas.
--
Peter Stephenson <pws@pwstephenson.fsnet.co.uk>
next prev parent reply other threads:[~2000-02-01 18:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-01-31 12:07 Sven Wischnowsky
2000-02-01 18:45 ` Peter Stephenson [this message]
-- strict thread matches above, loose matches on Subject: below --
2000-02-02 15:30 Sven Wischnowsky
2000-02-02 16:11 ` Bart Schaefer
2000-02-02 8:32 Sven Wischnowsky
2000-02-02 15:14 ` James Kirkpatrick
2000-01-30 18:47 Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E12FiFo-0003rR-00.2000-02-01-18-42-20@cmailg7.svr.pol.co.uk \
--to=pws@pwstephenson.fsnet.co.uk \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).