zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@pwstephenson.fsnet.co.uk>
To: ZSH-workers@sunsite.auc.dk
Subject: Re: PATCH: mmap error
Date: Tue, 01 Feb 2000 18:45:39 +0000	[thread overview]
Message-ID: <E12FiG6-0008Up-00.2000-02-01-18-42-39@mail12.svr.pol.co.uk> (raw)
In-Reply-To: "Clint Adams"'s message of "Mon, 31 Jan 2000 13:35:46 EST." <20000131133546.A13537@dman.com>

Clint Adams wrote:
> This is not an elegant solution.  Of course, I'm not even sure that it works.
> The point is to not segfault after mmap failure.

The following is basically the same, but more consistent with the other
allocation failures in mem.c

--- Src/mem.c.err	Mon Jan 31 20:09:54 2000
+++ Src/mem.c	Mon Jan 31 20:10:40 2000
@@ -356,6 +356,10 @@
 	    n = (n + pgsz) & ~pgsz;
 	    h = (Heap) mmap(NULL, n, PROT_READ | PROT_WRITE,
 			    MMAP_FLAGS, -1, 0);
+	    if (!h) {
+		zerr("fatal error: mmap failed", NULL, 0);
+		exit(1);
+	    }
 	    h->size = n;
 	}
 #else

-- 
Peter Stephenson <pws@pwstephenson.fsnet.co.uk>


  reply	other threads:[~2000-02-01 18:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-01-31 18:35 Clint Adams
2000-02-01 18:45 ` Peter Stephenson [this message]
2000-02-01 20:53   ` Peter Stephenson
2000-02-01 13:07 Sven Wischnowsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E12FiG6-0008Up-00.2000-02-01-18-42-39@mail12.svr.pol.co.uk \
    --to=pws@pwstephenson.fsnet.co.uk \
    --cc=ZSH-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).