zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@pwstephenson.fsnet.co.uk>
To: zsh-workers@sunsite.auc.dk
Subject: Re: Bugs with exclusion using file paths.
Date: Tue, 28 Mar 2000 21:48:30 +0100	[thread overview]
Message-ID: <E12aOS2-0004hL-00.2000-03-29-20-48-26@mail4.svr.pol.co.uk> (raw)
In-Reply-To: "Sven Wischnowsky"'s message of "Wed, 29 Mar 2000 10:26:47 +0200." <200003290826.KAA21838@beta.informatik.hu-berlin.de>

Sven Wischnowsky wrote:
> > +				if (buf) {
> >  				    zfree(buf, pathpos + patinlen);
> > +				    patinstart = savpatinstart;
> > +				    patinlen = savpatinlen;
> 
> With something like **/_*~*~ I now get lots of:
> 
>   BUG: attempt to free more than allocated.
> 
> warnings.

Very stupid, sorry; use the original pattern length, not the temporrary
one.  For boring technical reasons due to the way my front-end to configure
is run, I didn't have Zsh memory allocation on, or I would presumably have
picked it up.

Let me know if there is still a problem after this.  I tried **/*~(.)# in
my home directory, with zsh-mem turned on, which ought to have tickled any
bug of this kind.

Index: Src/pattern.c
===================================================================
RCS file: /home/pws/CVSROOT/projects/zsh/Src/pattern.c,v
retrieving revision 1.7
diff -u -r1.7 pattern.c
--- Src/pattern.c	2000/03/27 21:40:57	1.7
+++ Src/pattern.c	2000/03/28 20:16:50
@@ -1815,9 +1815,9 @@
 				    parsfound = savparsfound;
 				}
 				if (buf) {
-				    zfree(buf, pathpos + patinlen);
 				    patinstart = savpatinstart;
 				    patinlen = savpatinlen;
+				    zfree(buf, pathpos + patinlen);
 				}
 				if (!ret)
 				    break;

-- 
Peter Stephenson <pws@pwstephenson.fsnet.co.uk>
Work: pws@CambridgeSiliconRadio.com
Web: http://www.pwstephenson.fsnet.co.uk


  reply	other threads:[~2000-03-29 19:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-03-29  8:26 Sven Wischnowsky
2000-03-28 20:48 ` Peter Stephenson [this message]
2000-03-29 22:18   ` Bart Schaefer
  -- strict thread matches above, loose matches on Subject: below --
2000-03-26 22:17 Peter Stephenson
2000-03-29 17:19 ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E12aOS2-0004hL-00.2000-03-29-20-48-26@mail4.svr.pol.co.uk \
    --to=pws@pwstephenson.fsnet.co.uk \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).