From: "áÎÄÒÅÊ âÏÒÚÅÎËÏ×" <arvidjaar@mail.ru>
To: "Bart Schaefer" <schaefer@candle.brasslantern.com>
Cc: zsh-workers@sunsite.dk
Subject: Re[2]: Fix for zpty under Cygwin
Date: Tue, 08 May 2001 08:08:04 +0400 [thread overview]
Message-ID: <E14wyn6-000AE9-00@f10.mail.ru> (raw)
In-Reply-To: <010507124740.ZM27941@candle.brasslantern.com>
-----Original Message-----
From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: "Андрей Борзенков" <arvidjaar@mail.ru>
Date: Mon, 7 May 2001 12:47:39 -0700
Subject: Re: Fix for zpty under Cygwin
>
> > So the fix under Cygwin is quite simple - just
remove O NOCTTY.
> > Actually, I wonder what it does here at all - it is
exactly the
> > descriptor that *will* be ctty later.
>
> It will be ctty in the forked-off child that runs on
the pty, but we have
> to open the descriptor originally in the parent
before forking. O NOCTTY
> is to prevent the pty from becoming the parent's
controlling terminal.
>
That's wrong. get_pty() has two threads - one is
executed in parent (master) and one in child after fork
(slave). So, sfd descriptor is opened just once in
child and fix looks applicable. I've tried it on my
Unix as well without any obvious ill effects.
Anyway, I suggested to put it under ifdef __CYGWIN__
for the time being to avoid last-time breaking on other
systems. It does fix things under Cygwin (it is nice to
convince Cygwin folks to change O_NOCTTY semantics of
course).
-andrej
next prev parent reply other threads:[~2001-05-08 4:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-07 18:15 áÎÄÒÅÊ âÏÒÚÅÎËÏ×
2001-05-07 19:47 ` Bart Schaefer
2001-05-08 4:08 ` áÎÄÒÅÊ âÏÒÚÅÎËÏ× [this message]
2001-05-08 10:23 ` Peter Stephenson
2001-05-08 12:45 ` Andrej Borsenkow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E14wyn6-000AE9-00@f10.mail.ru \
--to=arvidjaar@mail.ru \
--cc=schaefer@candle.brasslantern.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).