zsh-workers
 help / color / mirror / code / Atom feed
From: "Jun T." <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: Commit 137b15a fails X02zlevi test
Date: Fri, 14 Feb 2014 01:17:12 +0900	[thread overview]
Message-ID: <E1B1A4F0-6643-4817-8930-CF876EB414E5@kba.biglobe.ne.jp> (raw)
In-Reply-To: <140212214922.ZM25943@torch.brasslantern.com>

(Sorry I've been too busy for testing recent patches.)

Today I did a few test with zsh-5.0.5-40-gba58bfe, and found that
X02zlevi.ztst always fails on Mac OS X (10.9.1) and FreeBSD 10.0.
All the test which use comptesteval seem to fail.

With the Bart's zpty_flush patch in 32377, it succeeds about 50%
on Mac but still fails 100% on FreeBSD.
On Both systems, the failure is at
  comptesteval 'bindkey -a "^R" redo'
  zletest $'123\C-_\e\C-r
and all the other tests pass.
(if I set ZTST_verbose=3 then the above test also succeeds always).

I don't know exactly what is causing this failure, but anyway replacing
^R with ^K (or some other keys) seems to work on both Mac and FreeBSD. 

# I noticed that 'stty -a' shows 'reprint' is set to '^R',
# and if I change the comptesteval to
#   comptesteval 'stty reprint "^K";bindkey -a "^R" redo'
# then the test always succeeds on Mac. But this doesn't work on FreeBSD;
# moreover, on Fedora20, X02zlevi.ztst alway succeeds but '^R' is also
# used for reprint. So this may not be related with the failure.




diff --git a/Test/X02zlevi.ztst b/Test/X02zlevi.ztst
index fe55d8a..60f878e 100644
--- a/Test/X02zlevi.ztst
+++ b/Test/X02zlevi.ztst
@@ -49,8 +49,8 @@
 >BUFFER: z
 >CURSOR: 1
 
-  comptesteval 'bindkey -a "^R" redo'
-  zletest $'123\C-_\e\C-r'
+  comptesteval 'bindkey -a "^K" redo'
+  zletest $'123\C-_\e\C-k'
 0:undo in insert mode, redo in command
 >BUFFER: 123
 >CURSOR: 2




  parent reply	other threads:[~2014-02-13 16:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-08 20:13 Bart Schaefer
2014-02-08 22:45 ` Bart Schaefer
2014-02-09 18:53   ` Bart Schaefer
2014-02-09 21:00     ` Peter Stephenson
2014-02-09 22:30     ` Oliver Kiddle
2014-02-11  7:37       ` Bart Schaefer
2014-02-13  5:49         ` Bart Schaefer
2014-02-13  9:32           ` Peter Stephenson
2014-02-13 16:17           ` Jun T. [this message]
2014-02-13 17:39             ` Bart Schaefer
2014-02-14 15:59               ` Jun T.
2014-02-15  1:42                 ` Bart Schaefer
2014-02-15 17:07                   ` Jun T.
2014-02-15 21:35                     ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1B1A4F0-6643-4817-8930-CF876EB414E5@kba.biglobe.ne.jp \
    --to=takimoto-j@kba.biglobe.ne.jp \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).