From: Jun T <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: P01privileged fails on CentOS/Fedora (a simple permission issue)
Date: Fri, 13 Mar 2020 19:16:20 +0900 [thread overview]
Message-ID: <E696D283-AFC7-4236-967B-E9E504AA253D@kba.biglobe.ne.jp> (raw)
In-Reply-To: <0F4775DE-00AB-49DA-A12C-72E13B60C1F5@dana.is>
> 2020/03/13 3:11, dana <dana@dana.is> wrote:
>
>
> On 11 Mar 2020, at 15:26, Bart Schaefer <schaefer@brasslantern.com> wrote:
>> What about reading the UID/GID of the directory to assign defaults of
>> ZSH_TEST_UNPRIVILEGED_UID and ZSH_TEST_UNPRIVILEGED_GID?
>
> Thanks. Had to double-check this.
>
> This will help, if (1) we use the directory owner for the EUID and (2) we get
> rid of anything in the test file that tries to set the test shell's EUID to
> something besides the owner or root.
>
> Right now, only the very first test (the one that failed for Jun) does that. I
> *think* it's probably fine to eliminate it, since it's a bit redundant in this
> particular case... but it'll break again if we ever try to re-add a similar
> check.
With the patch P01 (with sudo) succeeds on Fedora.
Personally I feel it's simpler to use relative path, but have no objection
to using UID of ZTST_tesdir.
# If you don't like hard-coding the directory name we can pass it from
# Test/Makefile.in, via a variable like ZTST_moddir, to ztst.zsh (line 38)
# and use it in P01privileged.ztst.
next prev parent reply other threads:[~2020-03-13 10:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 2:59 Jun T
2020-03-10 17:26 ` Jun. T
2020-03-11 20:06 ` dana
2020-03-11 20:26 ` Bart Schaefer
2020-03-12 18:11 ` dana
2020-03-13 10:16 ` Jun T [this message]
2020-03-13 14:19 ` dana
2020-03-17 5:34 ` Jun T
2020-04-01 22:35 ` dana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E696D283-AFC7-4236-967B-E9E504AA253D@kba.biglobe.ne.jp \
--to=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).