From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 30694 invoked from network); 8 Jul 2020 10:50:10 -0000 Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTPUTF8; 8 Jul 2020 10:50:10 -0000 Received: (qmail 22444 invoked by alias); 8 Jul 2020 10:50:00 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: Sender: zsh-workers@zsh.org X-Seq: 46215 Received: (qmail 9822 invoked by uid 1010); 8 Jul 2020 10:50:00 -0000 X-Qmail-Scanner-Diagnostics: from rcpt-expgw.biglobe.ne.jp by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.3/25863. spamassassin: 3.4.4. Clear:RC:0(133.208.98.1):SA:0(-2.6/5.0):. Processed in 1.469868 secs); 08 Jul 2020 10:50:00 -0000 X-Envelope-From: takimoto-j@kba.biglobe.ne.jp X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at spf01.biglobe.ne.jp designates 133.208.98.1 as permitted sender) X-Biglobe-Sender: From: Jun T Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Subject: Re: Five New Test Failures Date: Wed, 8 Jul 2020 19:49:23 +0900 References: <00445BFC-A800-49B6-A4FD-B1F294764245@kba.biglobe.ne.jp> To: zsh-workers@zsh.org In-Reply-To: <00445BFC-A800-49B6-A4FD-B1F294764245@kba.biglobe.ne.jp> Message-Id: X-Mailer: Apple Mail (2.3445.104.14) X-Biglobe-Spnum: 59287 Sorry, please forget the previous patch. I noticed that we should better to start the subshell without zle, i.e., with option +Z. Then the command 'rm *' is not echoed back. =20 > 2020/07/08 9:25, I wrote: >=20 > There is no prompt problem here, but the 'n' sent by the test is > echoed back and causes the failure. But I still get this 'n' on Fedora32 (maybe also on Ubuntu20.04). I don't know why. It doesn't happen on CentOS8. It seems we need '(|n)' at the end of the pattern. In the patch below, I explicitly set PS1 and wait for the prompt. Do we need to set MODULE_PATH in the subshell? I guess we don't since no module is used in this test? diff --git a/Test/E01options.ztst b/Test/E01options.ztst index c59509f2e..5a1c8ebcf 100644 --- a/Test/E01options.ztst +++ b/Test/E01options.ztst @@ -1432,12 +1432,13 @@ F:If this test fails at the first unsetopt, = refer to P01privileged.ztst. '/' '/*' do before=3D`ls -a -- $target_dir` - zpty subshell $ZTST_testdir/../Src/zsh -f + zpty subshell $ZTST_testdir/../Src/zsh -f +Z [[ $PWD =3D=3D */options.tmp ]] || return 1 # Sanity check before = calling rm(1). + zpty -w subshell 'PS1=3DPROMPT' + zpty -r -m subshell REPLY $'*PROMPT' zpty -w subshell "rm $target_pattern" - zpty -w subshell 'n' + zpty -w -n subshell 'n' sleep 1 - zpty -rt subshell REPLY # "${PS1} rm *" zpty -rt subshell REPLY && print -r -- ${REPLY%%$'\r\n'} zpty -d subshell after=3D`ls -a -- $target_dir` @@ -1448,5 +1449,5 @@ F:If this test fails at the first unsetopt, refer = to P01privileged.ztst. fi BEL=3D$'\a' 0q:RM_STAR_SILENT -*>zsh: sure you want to delete all 15 files in ${PWD:h}/options.tmp = \[yn\]\? ${BEL} -*>zsh: sure you want to delete all <-> files in / \[yn\]\? ${BEL} +*>zsh: sure you want to delete all 15 files in ${PWD:h}/options.tmp = \[yn\]\? ${BEL}(|n) +*>zsh: sure you want to delete all <-> files in / \[yn\]\? ${BEL}(|n)