From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 4083 invoked from network); 7 Sep 2023 14:27:26 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 7 Sep 2023 14:27:26 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1694096846; b=NW7HBN+7ZyuTg/D9BWxQ0lGIPjiPHtnE83RMoQvWWteEIIaZRn5L/dS5zeBMuhdXYdOcmFlRh0 VNKCwI723LLv82bpZhD+URXG0i8fdYbTyKQTqTHFmJdMncCD3h4rkH9Tv7huMzzUnFIbCOrhqP LhPtfJIBC1sjTb62NUcnsa9QjUxT1HUawgCFxpacLX4ECkU+bKizooxWftCBjQTRRGiz1zdNxJ JYyDdRfGL65UTScA16APCfdXEG8C68wYFanB9bHg0NtsLz9SZDxqfNzax6fYjxsIx6V4gE7lVP ji2KHeAK/J6TMWhL0J0jo7VjGJ/rWtjVi7ClSM687IyEWw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (snd00004-bg.im.kddi.ne.jp) smtp.remote-ip=27.86.113.4; dmarc=none header.from=kba.biglobe.ne.jp; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1694096846; bh=z7ujywmBCIPY1NXURDi4YDxuuXbwEBqxmLXb0ij8itg=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Message-ID:In-Reply-To:To:References:Date:Subject: MIME-Version:Content-Transfer-Encoding:Content-Type:From:DKIM-Signature; b=RiKsDgMcW+V8Tgc8InN6Jxt0TUnJdU3IzOPeCka1JxyTR1XgBhQQWwm/DlyI+IDuR+e65/9AIq DHw3Sbem6Rur2/1135hyc1uNdRKw+uHfAIFzLrU/eTowPSz8ahKSJSrFzTB9nnjzTx4jN8iQPJ kqMety+FvhVTqMxV8FsCBisCLBf9VUa0POHIGwUD6b4wJAttfIUv3QSeAY/SnmSVUkP8cy9OC7 vq3lTXYMPcHR2XoK/If5RPunpFxWPag2vTmMGqhsjapI9K5mKu5HpT+n83ASSswX84VLoNMhhV iByH/rGnMmLgu0NvkEu/4LnxD+vdKJYl48Q+jogwvCsWMg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Message-Id:In-Reply-To:To:References: Date:Subject:Mime-Version:Content-Transfer-Encoding:Content-Type:From: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=673mk9VYFXEtrUbyB5w+vsfhvJuoZhqWkxLAXrCrl90=; b=U7ab5S3ArHTlqAsbXttBPvlItW ZJwlMsFvQ0pup8uoZn6QPpn6wFvywFryDu0wPtC0+4aQofuBjCTcverW/PNLMDaV3TtC1D9JNGUah hSs2AOqj2WMm00gATF0nsRhNspjMEToyq8ceUpWC//fZxrhXfWcd7Mt5ZUNflhtkrQQ28EBC625/S SSDY3Ss2zKWtBtk6G5CopjJ5NEXm3bkoTLcZH0QGsxme03hme0NS+QkrOf37HvZdEAocpQPcg9QjP g/qPb+VRB0Huu0EN30LSitRlaMGQOOZRs8obIY917VVvcApuj0rajgRlYk+ZXt28q6VapJB6sR44j RH/S55cQ==; Received: by zero.zsh.org with local id 1qeFye-0002F2-Nw; Thu, 07 Sep 2023 14:27:24 +0000 Authentication-Results: zsh.org; iprev=pass (snd00004-bg.im.kddi.ne.jp) smtp.remote-ip=27.86.113.4; dmarc=none header.from=kba.biglobe.ne.jp; arc=none Received: from snd00004-bg.im.kddi.ne.jp ([27.86.113.4]:10341 helo=dfmta0027.biglobe.ne.jp) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1qeFyI-0001wx-OK; Thu, 07 Sep 2023 14:27:08 +0000 Received: from mail.biglobe.ne.jp by omta0027.biglobe.ne.jp with ESMTP id <20230907142656430.LGTC.49789.mail.biglobe.ne.jp@biglobe.ne.jp> for ; Thu, 7 Sep 2023 23:26:56 +0900 From: "Jun. T" Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.3\)) Subject: Re: (LC_ALL=C; set -x 128 129; printf "%s\n" ${(#)@} | hexdump -C) Date: Thu, 7 Sep 2023 23:26:55 +0900 References: <20230830072753.hhveg7teosubwzq7@chazelas.org> <88812889-04BC-412A-85BE-BDAA2326B29B@kba.biglobe.ne.jp> To: zsh-workers@zsh.org In-Reply-To: <88812889-04BC-412A-85BE-BDAA2326B29B@kba.biglobe.ne.jp> Message-Id: X-Mailer: Apple Mail (2.3696.120.41.1.3) X-Biglobe-Sender: takimoto-j@kba.biglobe.ne.jp X-Seq: 52120 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: > 2023/09/01 2:38, I wrote: > > So we need to reset (or save/restore) errflag somewhere... The patch below is a simple save/restore errflag. It seems to work, but I'm not sure it is the (or a) correct fix. I will not push this unless I get positive responses. By the way, the problem is not limited to the C locale. Even with UTF-8 locale (tested on Linux. macOS may behave differently): % a=( 0x8000_0000 0x8000_0001 ) % printf "%s\n" ${(#)a} | hexdump -C 00000000 22 0a 22 |"."| 00000003 Another problem (but I feel we don't need to fix it) is that when we get error with the (X) flag seems to be rather arbitrary. For positive values the lowest 4 bytes are used (subst.c:1503), while for negative values only the lowest one byte is used (subst.c:1511) and we never get warnings (tested on Fedora-38): % printf "%s\n" ${(#X):-0x8000_0000} zsh: character not in range % printf "%s\n" ${(#X):-0x1_0000_0000} | hexdump -C 00000000 00 0a |..| 00000002 % printf "%s\n" ${(#X):-0x1_8000_0000} | hexdump -C zsh: character not in range % printf "%s\n" ${(#X):--1} | hexdump -C 00000000 ff 0a |..| 00000002 % printf "%s\n" ${(#X):--0x8000_0001} | hexdump -C 00000000 ff 0a |..| 00000002 diff --git a/Src/subst.c b/Src/subst.c index 14947ae36..6d9197d44 100644 --- a/Src/subst.c +++ b/Src/subst.c @@ -3572,7 +3572,7 @@ colonsubscript: if (errflag) return NULL; if (evalchar) { - int one = noerrs, oef = errflag, haserr = 0; + int one = noerrs, haserr = 0; if (!quoteerr) noerrs = 1; @@ -3582,28 +3582,33 @@ colonsubscript: */ if (isarr) { char **aval2, **avptr, **av2ptr; + int tmp_errflag = 0; /* errflag==0 at this point */ aval2 = (char **)zhalloc((arrlen(aval)+1)*sizeof(char *)); for (avptr = aval, av2ptr = aval2; *avptr; avptr++, av2ptr++) { - /* When noerrs = 1, the only error is out-of-memory */ - if (!(*av2ptr = substevalchar(*avptr))) { + /* errflag must be cleared when calling substevalchar(). + * It will set errflag if conversion fails. */ + errflag = 0; + *av2ptr = substevalchar(*avptr); + tmp_errflag |= errflag; + if (!*av2ptr) { /* not a valid numerical expression? */ haserr = 1; break; } } + errflag = tmp_errflag; *av2ptr = NULL; aval = aval2; } else { - /* When noerrs = 1, the only error is out-of-memory */ if (!(val = substevalchar(val))) haserr = 1; } noerrs = one; if (!quoteerr) { /* Retain user interrupt error status */ - errflag = oef | (errflag & ERRFLAG_INT); + errflag &= ERRFLAG_INT; } if (haserr || errflag) return NULL;