From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE,RDNS_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 Received: (qmail 19520 invoked from network); 11 Mar 2020 21:15:51 -0000 Received-SPF: pass (primenet.com.au: domain of zsh.org designates 203.24.36.2 as permitted sender) receiver=inbox.vuxu.org; client-ip=203.24.36.2 envelope-from= Received: from unknown (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTP; 11 Mar 2020 21:15:51 -0000 Received: (qmail 26606 invoked by alias); 11 Mar 2020 21:15:42 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45530 Received: (qmail 23373 invoked by uid 1010); 11 Mar 2020 21:15:42 -0000 X-Qmail-Scanner-Diagnostics: from mail-yw1-f50.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.2/25744. spamassassin: 3.4.2. Clear:RC:0(209.85.161.50):SA:0(-1.9/5.0):. Processed in 2.274662 secs); 11 Mar 2020 21:15:42 -0000 X-Envelope-From: dana@dana.is X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.161.50 as permitted sender) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=NnRssqonQ5a3b+7N6HX/pbjlpbusbivhimQ5QUwo0TQ=; b=IRFHgby6dHq31/4zdHMOLvVJLp9Tzw/4CgRIfmfj626gEjKzel6/0LZUMNsmSCE9mL 5xgBNaBM33ArN3njpL8OdmObGV2tm6pyNb3Or7wc/2Ja+qOPBwg2Nekk5vfOrU2zMcgx c+AtvD24iFrGH+q06C6zb1zuXRCLZE9n0lgqLChH6bQ8q3P3NjmpY0KJNIEyE6fuOf3n MDcwUR3WjB+tl2itj4z+1umv6ruOmt+5VhonQxJ5ICdSz0zO+i3pLuZGjAC2pSW1a0ut 4WusVi1DjPIlXXO79ROscC9TVxUCxl+lD5kNwr48TLY57e/QJwdEJWcPwhZWFLjJJ1R/ 1tPw== X-Gm-Message-State: ANhLgQ17hgugLsm1rriv6yLlRm5MWwYmXRNs6Hw8dfmh5nucSTNEmu6q ZQrhaA1p2blEoEOqn3bKOZjqF8CgX3M= X-Google-Smtp-Source: ADFU+vtbMuQXN4qccsFSdN6xnV1+8v5KBVjs55NHqCVug/UO0gMx6NldCwIdRzrm3wLFlgDt0bw0mg== X-Received: by 2002:a25:b3c3:: with SMTP id x3mr5087003ybf.148.1583961305827; Wed, 11 Mar 2020 14:15:05 -0700 (PDT) From: dana Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: [BUG] E02 test failure / ztst *> issue Message-Id: Date: Wed, 11 Mar 2020 16:15:04 -0500 To: Zsh hackers list X-Mailer: Apple Mail (2.3445.104.11) When i run E02 on master, on macOS, i get an failure for the new = 'preserves tracing' test (see output below). On my machine, `which` outputs the = name of the =E3=83=8C function without quoting. I was going to just change it like this: ->$'\M-c\M-\C-C\M-\C-L' () { +*>(=E3=83=8C|$'\M-c\M-\C-C\M-\C-L') \(\) { But that doesn't work the way i expected =E2=80=94 it breaks the = surrounding lines. The documentation (B01) says this about `*>`: # Each line of a '>' and '?' chunk may be preceded by a '*', so the = line # starts '*>' or '*?'. This signifies that for any line with '*' in = front # the actual output should be pattern matched against the = corresponding # lines in the test output. In actuality, if *any* `>` line is preceded by `*`, *all* of them are = treated as patterns to be matched against the corresponding lines in the output. = Thus, if the surrounding lines contain pattern meta-characters (which they = do), they need to be escaped to work correctly. I'm not sure if the documentation is wrong or if the behaviour is. It = seems like it would be helpful if it worked the way it said, but it looks like = we'd have to pass pattern-containing line numbers or something to ZTST_diff = for it to do that. idk dana --- /tmp/zsh.ztst.28982/ztst.out 2020-03-11 15:57:36.000000000 = -0500 +++ /tmp/zsh.ztst.28982/ztst.tout 2020-03-11 15:57:36.000000000 = -0500 @@ -6,7 +6,7 @@ # traced echo inner } -$'\M-c\M-\C-C\M-\C-L' () { +=E3=83=8C () { # traced echo inner } Test ./E02xtrace.ztst failed: output differs from expected as shown = above for: test_cases=3D( f # baseline foo-bar # Dash =E3=83=8C # Meta (the UTF-8 representation of this = character has an 0x83 byte) \$\'ba\\0z\' # Nul, escaped as though by ${(qqqq)} ) for 1 in "$test_cases[@]"; do eval " ${1}() { ${1}() { echo inner } } functions -T ${1} ${1} which ${1} " done Was testing: a function that redefines itself preserves tracing