From: dana <dana@dana.is>
To: Sebastian Gniazdowski <sgniazdowski@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Completion for aplay from alsa-utils
Date: Sun, 3 Nov 2019 17:17:52 -0600 [thread overview]
Message-ID: <EE6F9F27-FFCB-4D88-91E7-C0EE5CF33C4D@dana.is> (raw)
In-Reply-To: <CAKc7PVArm7cgptJrBaHhe0R=J5M9m8MeiCqLGESN3nu6TdW8bQ@mail.gmail.com>
On 2 Nov 2019, at 16:13, Sebastian Gniazdowski <sgniazdowski@gmail.com> wrote:
> the submitted completion is in file _alsa-utils
Feels like maybe it should just be called _aplay, unless you think there would
be so much shared code between future alsa-utils completion functions that
they all need to live together in one (not sure but doesn't seem like it)
And you can add arecord to #compdef, since it's basically the same thing as
aplay
Some functional issues i noticed:
* _arguments should have -S
* There are no exclusions for any of the alias options (e.g., -D and --device
should be exclusive)
* --device, --file-type, and --process-id-file should take arguments
* All short aliases of long options that take an argument should have + (e.g.,
-c+ for --channels=)
* -v is cumulative, but there is no * in the spec
Would also be nice to have better optarg completion (there are no argument
descriptions, some of the options take pre-defined arguments that are listed
in the documentation that you could offer, &c.), and taking the option
descriptions from the help output verbatim doesn't look that nice here, but
i'm probably being too pedantic now
dana
next prev parent reply other threads:[~2019-11-03 23:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-02 21:13 Sebastian Gniazdowski
2019-11-03 23:17 ` dana [this message]
2019-11-04 10:38 ` Oliver Kiddle
2019-11-21 23:10 ` Sebastian Gniazdowski
2019-11-22 3:05 ` dana
2019-11-25 10:16 ` Sebastian Gniazdowski
2019-11-25 12:10 ` Sebastian Gniazdowski
2019-11-26 2:16 ` dana
2019-12-01 21:11 ` Sebastian Gniazdowski
2019-11-22 15:17 ` Eric Cook
2019-11-25 9:27 ` Sebastian Gniazdowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EE6F9F27-FFCB-4D88-91E7-C0EE5CF33C4D@dana.is \
--to=dana@dana.is \
--cc=sgniazdowski@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).