From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id efada46b for ; Sun, 3 Nov 2019 23:18:38 +0000 (UTC) Received: (qmail 24164 invoked by alias); 3 Nov 2019 23:18:29 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44890 Received: (qmail 6014 invoked by uid 1010); 3 Nov 2019 23:18:29 -0000 X-Qmail-Scanner-Diagnostics: from mail-yw1-f43.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.0/25622. spamassassin: 3.4.2. Clear:RC:0(209.85.161.43):SA:0(-1.9/5.0):. Processed in 1.543611 secs); 03 Nov 2019 23:18:29 -0000 X-Envelope-From: dana@dana.is X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.161.43 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana-is.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=cu90P1pnUmTElIp9ltJzwd3yOqti3bQXlF42D/kpI+Q=; b=bmbLxNsA23Cc9zi2dKuNhaQ1f9msG+/P/0u3HPCABlTt55usCZlXvwx9EF7dlg2nfq deiIrAgMYPe1028+gocK0d8b5z3saXsI1zSEr9yulRfIdqRsrhyGgSM+fmxYDZFXt6T0 lqmj/QeHAZyRasWhXUs4ZfphHXaoME8WG6AA/w3QLUZTDGJkyt59Ikk65K3x1DK6mb8f AYgta/oLASsNqDWx1YNbyaWM7pdyGaNF06zr3N4iavCbfYSgxeLMfCpY/VzyxNXoYrV1 NCpuLlKlprvqmqmId3pKhg/MW2ufRiiBea3WfnDhSAPSDqfbIbjBdRQFWODsmpBAllBT d2Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=cu90P1pnUmTElIp9ltJzwd3yOqti3bQXlF42D/kpI+Q=; b=ooLWcbM9v+MWiS1HZHDZRf83x27jwWiKmX1XV7eULqUOVT+fnTl/XjJIOplnfIuLah nZhvSrZqlJsWG+rBdelBtPLQdFBbG3aDhi1iv5YveQ2iGO60QOtECYyD2AdKbBj31U7h 73HcjiCd8d2qHgvqV0+lWeLJ/+fuLQrZNic8uTL7J6ZCJYRq3wlW+p4F7EHoT4k+UI1v bDkbHEf04k0taHMvrWcEmbm0aKXykOVvt4Wl8NjRVseozqXDizuEbVRVUIJL9D2+zajn D7JV9jEo8cJppRcrZJ2GOsdrT/hABVtqiBmlnbzgIfw35J3vkRvvx0pkwnfHkoOKqoYo g1ww== X-Gm-Message-State: APjAAAUFowq5IKteJqC+cvFqCiUQB1AIhiReF6imk7ZKyOUN4moS/L6r IL18fMFUNVIvBj4dS6xtHtyIIA== X-Google-Smtp-Source: APXvYqye19szAEOvz2SpkQt2Ao+u3SETpaxFhzQVLLJAEqR3oEFjhSKr8or8ugTHGtQgW84KAarWXQ== X-Received: by 2002:a81:5885:: with SMTP id m127mr18147904ywb.484.1572823073955; Sun, 03 Nov 2019 15:17:53 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: Completion for aplay from alsa-utils From: dana In-Reply-To: Date: Sun, 3 Nov 2019 17:17:52 -0600 Cc: Zsh hackers list Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Sebastian Gniazdowski X-Mailer: Apple Mail (2.3445.104.11) On 2 Nov 2019, at 16:13, Sebastian Gniazdowski = wrote: > the submitted completion is in file _alsa-utils Feels like maybe it should just be called _aplay, unless you think there = would be so much shared code between future alsa-utils completion functions = that they all need to live together in one (not sure but doesn't seem like = it) And you can add arecord to #compdef, since it's basically the same thing = as aplay Some functional issues i noticed: * _arguments should have -S * There are no exclusions for any of the alias options (e.g., -D and = --device should be exclusive) * --device, --file-type, and --process-id-file should take arguments * All short aliases of long options that take an argument should have + = (e.g., -c+ for --channels=3D) * -v is cumulative, but there is no * in the spec Would also be nice to have better optarg completion (there are no = argument descriptions, some of the options take pre-defined arguments that are = listed in the documentation that you could offer, &c.), and taking the option descriptions from the help output verbatim doesn't look that nice here, = but i'm probably being too pedantic now dana