From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3729 invoked from network); 6 Mar 2006 10:33:32 -0000 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00, FORGED_RCVD_HELO autolearn=ham version=3.1.0 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 6 Mar 2006 10:33:32 -0000 Received: (qmail 45538 invoked from network); 6 Mar 2006 10:33:26 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 6 Mar 2006 10:33:26 -0000 Received: (qmail 2062 invoked by alias); 6 Mar 2006 10:33:23 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 22327 Received: (qmail 2053 invoked from network); 6 Mar 2006 10:33:22 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 6 Mar 2006 10:33:22 -0000 Received: (qmail 45194 invoked from network); 6 Mar 2006 10:33:22 -0000 Received: from cluster-d.mailcontrol.com (217.69.20.190) by a.mx.sunsite.dk with SMTP; 6 Mar 2006 10:33:21 -0000 Received: from exchange03.csr.com (uuk202166.uk.customer.alter.net [62.189.241.194] (may be forged)) by rly35d.srv.mailcontrol.com (MailControl) with ESMTP id k26AX4u8027769 for ; Mon, 6 Mar 2006 10:33:12 GMT Received: from csr.com ([10.103.143.38]) by exchange03.csr.com with Microsoft SMTPSVC(5.0.2195.6713); Mon, 6 Mar 2006 10:33:00 +0000 To: zsh-workers@sunsite.dk (Zsh hackers list) Subject: Re: [PATCH][RFC] check for heap memory in zfree() In-reply-to: <060305124316.ZM25210@torch.brasslantern.com> References: <200603051723.k25HNdZI003407@pwslaptop.csr.com> <060305124316.ZM25210@torch.brasslantern.com> Date: Mon, 06 Mar 2006 10:32:43 +0000 From: Peter Stephenson Message-ID: X-OriginalArrivalTime: 06 Mar 2006 10:33:00.0180 (UTC) FILETIME=[574CCD40:01C64109] Content-Type: text/plain MIME-Version: 1.0 X-Scanned-By: MailControl A-06-00-05 (www.mailcontrol.com) on 10.68.0.145 Bart Schaefer wrote: > Any objections to my committing my patch? With one additional tweak > to call zheapptr() before zarrdup() in the builtin.c hunk. I think it's OK. > schaefer[514] typeset -T DIRSTACK dirstack > typeset: dirstack: can't change type of a special parameter > > IMO a unique array is a distinct type from an ordinary array. I'm not convinced about that. I think it's just a tidying up operation performed on the value. > Some of our quacking and waddling parameters are already dog-paddling. > For example, although you can (without getting warnings) set the -LRZ > options on any array, they don't have any effect except to make the > array show up in "typeset -LRZ" output. That's a bug, probably, although it might need care fixing (does the flag apply if the array is about to be joined?) > The way to fix > that is to require that the parameter's rules conform to the internal > structure it represents, not the other way around. Yes, but I think the correspondence can sometimes be made more logical. It doesn't make sense to have dirstack an integer, but it does makes sense to have it contain unique elements. -- Peter Stephenson Software Engineer CSR PLC, Churchill House, Cambridge Business Park, Cowley Road Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070 To access the latest news from CSR copy this link into a web browser: http://www.csr.com/email_sig.php