From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Subject: Re: cosmetic completion problem
Date: Mon, 10 Oct 2005 10:37:03 +0100 [thread overview]
Message-ID: <EXCHANGE03O6AprLfKY00003f28@exchange03.csr.com> (raw)
In-Reply-To: <1051009025449.ZM6480@candle.brasslantern.com>
Bart Schaefer wrote:
> Inside that same (col >= columns) block is an fputs() call that's intended
> to make sure that the line really has wrapped when col == columns. I'm
> not sure, looking at it, why that's only necessary when (colors).
This doesn't really help, but until I added the ZLE_UNICODE_SUPPORT
there were two separate functions, one which handled colours and one
which didn't. I rationalised them into one with a flag for the few
local differences.
What might be more interesting is that I changed
if (++col == columns) {
into
if (col >= columns) {
which might well have introduced a subtle bug. The reason I introduced it
was we may have characters spanning multiple columns, but perhaps those
need something more sophisticated. (The increment now happens in one
of the immediately preceeding code branches.)
pws
This message has been scanned for viruses by BlackSpider MailControl - www.blackspider.com
next prev parent reply other threads:[~2005-10-10 9:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-06 20:58 Clint Adams
2005-10-08 7:32 ` DervishD
2005-10-08 21:40 ` Clint Adams
2005-10-09 2:54 ` Bart Schaefer
2005-10-10 9:37 ` Peter Stephenson [this message]
2005-10-10 14:06 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EXCHANGE03O6AprLfKY00003f28@exchange03.csr.com \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).