From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17011 invoked by alias); 1 Feb 2014 10:33:30 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 32335 Received: (qmail 2487 invoked from network); 1 Feb 2014 10:33:14 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00,USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Resent-From: Geoff Wing Resent-Date: Sat, 1 Feb 2014 21:33:14 +1100 Resent-Message-ID: <20140201103314.GA11450@primenet.com.au> Resent-To: zsh-workers@zsh.org X-Biglobe-Sender: Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: zle: vi mode: wrong undo handling on fresh lines From: "Jun T." In-Reply-To: <16181.1391175951@thecus.kiddle.eu> Date: Sat, 1 Feb 2014 01:43:16 +0900 Content-Transfer-Encoding: 7bit Message-Id: References: <20130923213014.15f97f9e@pws-pc.ntlworld.com> <3511.1390605547@thecus.kiddle.eu> <140125111530.ZM21792@torch.brasslantern.com> <20140127124301.4144f2d9@pwslap01u.europe.root.pri> <20140127161124.2aa16b37@pwslap01u.europe.root.pri> <2700.1390950035@thecus.kiddle.eu> <16181.1391175951@thecus.kiddle.eu> To: zsh-workers@zsh.org X-Mailer: Apple Mail (2.1827) 2014/01/31 22:45, Oliver Kiddle wrote: > How about we instead add a split-undo zle > widget? It is then easy for someone to add that before completion or > other widgets like backward-delete-word. I have no objection to this. > I'm fairly convinced that we should handle the suffix with the simple > patch below. I've long had vi-cmd-mode set to first use > auto-suffix-retain. I could be wrong but would suspect most vi users > would prefer it this way. However, it'd be good to have the opinion of > another vi-mode user. What do you think? In some cases the suffix is purely optional; for example $ chown m will complete to $ chown myname: or (on Mac OS X) $ df -Th completes to $ df -Thfs, I believe at least for these cases it would be better to erase the suffix when is hit. >> (This will also change the behavior in emacs-mode.) > > I can't quite work out what the emacs-mode behaviour change is. This is just a minor difference. Suppose you have directories 'foo' and 'bar'. By hitting and a few times after 'ls ' the command line would look like $ ls foo bar/ Now type a few times; without the change in zle_main.c, at some point you get $ ls foo/ but with my patch '/' will not be appended.