From: "Jun T." <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: zsh 5.3.1 crashes on completion
Date: Fri, 26 May 2017 01:01:16 +0900 [thread overview]
Message-ID: <F12CB16D-97D8-4BBB-B759-DCF74CAAD378@kba.biglobe.ne.jp> (raw)
In-Reply-To: <20170516120527.572a5cc9@pwslap01u.europe.root.pri>
With the latest git master, expand-history doesn't work correctly:
[1]% echo one
[2]% echo two
[3]% !!<TAB> (or the key bound to expand-history)
then !! expands to 'echo one' (!!<Return> works as expected).
It seems this is caused by the patch:
2017/05/16 20:05, Peter Stephenson <p.stephenson@samsung.com> wrote:
> --- a/Src/hist.c
> +++ b/Src/hist.c
(snip)
> @@ -261,6 +264,9 @@ hist_context_save(struct hist_stack *hs, int toplevel)
> */
> hs->cstack = cmdstack;
> hs->csp = cmdsp;
> + hs->curline_linked = curline_linked;
> +
> + unlinkcurline();
which is included in the commit 94014ff65bc2bdd752717792b156cdfcbc5b5c98
doexpandhist() calles zcontext_save(), which calls hist_context_save(),
which now calls unlinkcurline(). So when the event !! is searched
curline has been unlinked and curhist has been decremented, and
!! expands to event 1 (not 2).
next prev parent reply other threads:[~2017-05-25 16:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 2:35 ChenYao
2017-05-11 21:19 ` Bart Schaefer
2017-05-12 16:16 ` Daniel Shahaf
2017-05-12 16:19 ` Bart Schaefer
2017-05-13 2:02 ` ChenYao
2017-05-13 18:23 ` Bart Schaefer
2017-05-15 9:28 ` Peter Stephenson
2017-05-15 20:33 ` Bart Schaefer
2017-05-16 9:48 ` Peter Stephenson
2017-05-16 11:05 ` Peter Stephenson
2017-05-17 18:18 ` Bart Schaefer
2017-05-17 18:41 ` Peter Stephenson
2017-05-25 16:01 ` Jun T. [this message]
2017-05-25 18:05 ` Bart Schaefer
2017-05-26 9:19 ` Peter Stephenson
2017-05-26 23:56 ` Bart Schaefer
2017-05-29 4:04 ` Jun T.
2017-05-17 18:07 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F12CB16D-97D8-4BBB-B759-DCF74CAAD378@kba.biglobe.ne.jp \
--to=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).