From: Jun T <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: ksh compatibility: initial value of $_
Date: Thu, 23 Mar 2023 19:40:57 +0900 [thread overview]
Message-ID: <F3EB0C55-C453-4C49-BA7A-7ED3826E43A0@kba.biglobe.ne.jp> (raw)
In-Reply-To: <CAH+w=7a5Pk5nk4+k_d7TCcBjE04TwXJTm7Xrre9SYdK_U-hLmQ@mail.gmail.com>
> 2023/01/28 10:52, Bart Schaefer <schaefer@brasslantern.com> wrote:
>
> Docs for ksh93 say that $_ should be initialized to the absolute path
> of what we put in $ZSH_ARGZERO.
>
> Src/init.c explicitly initializes $_ to the empty string.
>
> Any reason not to change this?
No reason, I think, but I don't know any portable way to obtain
the full path name of the current zsh executable.
> If so, where's the right place to do
> it? I tried doing it in createparamtab() but that led to memory
> errors.
Once the full path name is obtained, then I guess we can initialize
$_ in setupvals() as in the following pseudo-patch:
diff --git a/Src/init.c b/Src/init.c
index 68621a0ad..03cbe4d0e 100644
--- a/Src/init.c
+++ b/Src/init.c
@@ -1084,9 +1084,12 @@ setupvals(char *cmd, char *runscript, char *zsh_name)
ztrdup(DEFAULT_IFS_SH) : ztrdup(DEFAULT_IFS);
wordchars = ztrdup(DEFAULT_WORDCHARS);
postedit = ztrdup("");
- zunderscore = (char *) zalloc(underscorelen = 32);
- underscoreused = 1;
- *zunderscore = '\0';
+ /* assume full path name of this zsh is in 'mypath' */
+ underscoreused = strlen(mypath) + 1;
+ underscorelen = (underscoreused + 31) & ~31;
+ zunderscore = (char *) zalloc(underscorelen);
+ strcpy(zunderscore, mypath);
+ /* free 'mypath' if necessary */
zoptarg = ztrdup("");
zoptind = 1;
next prev parent reply other threads:[~2023-03-23 10:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-28 1:52 Bart Schaefer
2023-03-23 10:40 ` Jun T [this message]
2023-03-31 8:18 ` Jun T
2023-03-31 14:31 ` Jun. T
2023-03-31 17:45 ` Bart Schaefer
2023-04-03 11:16 ` Jun. T
2023-04-03 16:48 ` Bart Schaefer
2023-03-31 19:02 ` Bart Schaefer
2023-03-31 19:03 ` Bart Schaefer
2023-04-03 12:13 ` Jun. T
2023-04-03 16:50 ` Bart Schaefer
2023-04-04 16:24 ` Jun. T
2023-04-05 1:03 ` Oliver Kiddle
2023-04-05 8:15 ` zeurkous
2023-04-05 9:00 ` Oliver Kiddle
2023-04-05 16:24 ` Jun. T
2023-04-05 8:14 ` dana
2023-04-05 18:16 ` Jun. T
2023-04-08 4:03 ` dana
2023-04-08 16:22 ` Oliver Kiddle
2023-04-09 13:30 ` Jun. T
2023-04-10 0:51 ` Jun T
2023-04-15 5:02 ` Felipe Contreras
2023-04-15 22:24 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F3EB0C55-C453-4C49-BA7A-7ED3826E43A0@kba.biglobe.ne.jp \
--to=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).