* [PATCH] Completion: Don't prepend SIG to numeric signals in _signals @ 2018-07-02 15:52 ` dana 2018-07-02 16:38 ` Peter Stephenson 0 siblings, 1 reply; 3+ messages in thread From: dana @ 2018-07-02 15:52 UTC (permalink / raw) To: Zsh workers On the subject of _signals, an issue i noticed is that sometimes zsh doesn't have the symbolic name for all signals.* `_signals -s` doesn't account for this, and produces weird results like 'SIG16'. Technically most tools that deal with signals will accept these, since they just blindly strip off the 'SIG' and use whatever's left over, but it's weird and AFAIK any support for them is incidental and undocumented. I think they should be filtered out. * Ubuntu's zsh 5.4 is missing symbolic names for SIGSTKFLT and SIGPWR. If i build from source, they're there, and the scripts that generate the signals basically haven't changed in 20 years... so i'm not sure what's up with that. Maybe the system that Ubuntu used to build zsh had weird headers. PS: I noticed that zsh doesn't even *know* about SIGRTMIN through SIGRTMAX (they're neither listed in $signals nor accepted by kill), probably because they're defined weirdly in the headers. bash and procps both do, though `/bin/kill -l` doesn't show them. I might see if they're easy to add. dana diff --git a/Completion/Unix/Type/_signals b/Completion/Unix/Type/_signals index df9a2f339..ffb01eba0 100644 --- a/Completion/Unix/Type/_signals +++ b/Completion/Unix/Type/_signals @@ -36,7 +36,7 @@ if [[ -z "$minus" ]] || fi if [[ -n "$pre" && $PREFIX = ${minus}S* ]]; then - sigs=( "${minus}SIG${(@)^signals[first,last]}" ) + sigs=( "${minus}SIG${(@)^${(@)signals[first,last]:#<->}}" ) (( $#disp )) && tmp=( "$tmp[@]" "${(@)signals[first,last]}" ) else sigs=() ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Completion: Don't prepend SIG to numeric signals in _signals 2018-07-02 15:52 ` [PATCH] Completion: Don't prepend SIG to numeric signals in _signals dana @ 2018-07-02 16:38 ` Peter Stephenson 2018-07-02 16:43 ` dana 0 siblings, 1 reply; 3+ messages in thread From: Peter Stephenson @ 2018-07-02 16:38 UTC (permalink / raw) To: Zsh workers On Mon, 2 Jul 2018 10:52:38 -0500 dana <dana@dana.is> wrote: > * Ubuntu's zsh 5.4 is missing symbolic names for SIGSTKFLT and > SIGPWR. If i build from source, they're there, and the scripts that > generate the signals basically haven't changed in 20 years... so i'm > not sure what's up with that. Maybe the system that Ubuntu used to > build zsh had weird headers. Signal generation changed between 5.5 and 5.5.1 to accommodate this (42618, commit 66f0e5c1ac). It seems that glibc 2.25 needs multiple include files, which wasn't previously handled. However, this wasn't always showing up, so there are obviously other ingredients. pws ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Completion: Don't prepend SIG to numeric signals in _signals 2018-07-02 16:38 ` Peter Stephenson @ 2018-07-02 16:43 ` dana 0 siblings, 0 replies; 3+ messages in thread From: dana @ 2018-07-02 16:43 UTC (permalink / raw) To: Peter Stephenson; +Cc: Zsh workers On 2 Jul 2018, at 11:38, Peter Stephenson <p.stephenson@samsung.com> wrote: >Signal generation changed between 5.5 and 5.5.1 to accommodate this >(42618, commit 66f0e5c1ac). It seems that glibc 2.25 needs multiple >include files, which wasn't previously handled. However, this wasn't >always showing up, so there are obviously other ingredients. Aha, i was looking in the wrong place for a change. Thanks! dana ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-02 16:43 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <CGME20180702155313epcas2p161b67990a718b040929bef8556974a47@epcas2p1.samsung.com> 2018-07-02 15:52 ` [PATCH] Completion: Don't prepend SIG to numeric signals in _signals dana 2018-07-02 16:38 ` Peter Stephenson 2018-07-02 16:43 ` dana
Code repositories for project(s) associated with this public inbox https://git.vuxu.org/mirror/zsh/ This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).