* Re: zsh compiling on Apple OSX v. 10.4.x [not found] ` <dc507f4a050523002352f05af1@mail.gmail.com> @ 2005-05-23 14:33 ` Peter Stephenson 2005-05-25 0:27 ` lists 0 siblings, 1 reply; 2+ messages in thread From: Peter Stephenson @ 2005-05-23 14:33 UTC (permalink / raw) To: Zsh hackers list Felix Rosencrantz wrote: > It seems that on 10.4, it's better to use select() than poll() for the > terminal IO. Otherwise you get the broken behavior Bill mentions > Though configure for zsh hasn't been modified to know this. I'm not > sure how to modify the autoconfg code to change this code for 10.4. > But it would be nice to fix this, so that zsh builds properly on OSX > 10.4 w/o hand-edits to config.h. I don't know what definitions to use, but this shouldn't break anything. I don't think autoconf allows you to undefine values; the easiest way to fix it there would be to avoid testing for poll() and poll.h at all on the appropriate systems. Index: Src/system.h =================================================================== RCS file: /cvsroot/zsh/zsh/Src/system.h,v retrieving revision 1.30 diff -u -r1.30 system.h --- Src/system.h 24 Feb 2005 16:53:12 -0000 1.30 +++ Src/system.h 23 May 2005 13:41:18 -0000 @@ -300,6 +300,15 @@ # include <sys/socket.h> #endif +#if defined(__APPLE__) && defined(HAVE_SELECT) +/* + * Prefer select() to poll() on MacOS X since poll() is known + * to be problematic in 10.4 + */ +#undef HAVE_POLL +#undef HAVE_POLL_H +#endif + #ifdef HAVE_SYS_FILIO_H # include <sys/filio.h> #endif -- Peter Stephenson <pws@csr.com> Software Engineer CSR PLC, Churchill House, Cambridge Business Park, Cowley Road Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070 ********************************************************************** This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. ********************************************************************** ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: zsh compiling on Apple OSX v. 10.4.x 2005-05-23 14:33 ` zsh compiling on Apple OSX v. 10.4.x Peter Stephenson @ 2005-05-25 0:27 ` lists 0 siblings, 0 replies; 2+ messages in thread From: lists @ 2005-05-25 0:27 UTC (permalink / raw) To: Zsh hackers list This worked on Mac OS 10.3 and 10.4 for me. Thanks! -Ryan On May 23, 2005, at 9:33 AM, Peter Stephenson wrote: > I don't know what definitions to use, but this shouldn't break > anything. I don't think autoconf allows you to undefine values; the > easiest way to fix it there would be to avoid testing for poll() and > poll.h at all on the appropriate systems. > > Index: Src/system.h > =================================================================== > RCS file: /cvsroot/zsh/zsh/Src/system.h,v > retrieving revision 1.30 > diff -u -r1.30 system.h > --- Src/system.h 24 Feb 2005 16:53:12 -0000 1.30 > +++ Src/system.h 23 May 2005 13:41:18 -0000 > @@ -300,6 +300,15 @@ > # include <sys/socket.h> > #endif > > +#if defined(__APPLE__) && defined(HAVE_SELECT) > +/* > + * Prefer select() to poll() on MacOS X since poll() is known > + * to be problematic in 10.4 > + */ > +#undef HAVE_POLL > +#undef HAVE_POLL_H > +#endif > + > #ifdef HAVE_SYS_FILIO_H > # include <sys/filio.h> > #endif > > -- > Peter Stephenson <pws@csr.com> Software Engineer > CSR PLC, Churchill House, Cambridge Business Park, Cowley Road > Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 > 692070 > > > ********************************************************************** > This email and any files transmitted with it are confidential and > intended solely for the use of the individual or entity to whom they > are addressed. If you have received this email in error please notify > the system manager. > > ********************************************************************** > > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-05-25 0:27 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <294439D0-476D-43F3-8326-8209C1F3FE9C@chemistry.ucsc.edu> [not found] ` <dc507f4a050523002352f05af1@mail.gmail.com> 2005-05-23 14:33 ` zsh compiling on Apple OSX v. 10.4.x Peter Stephenson 2005-05-25 0:27 ` lists
Code repositories for project(s) associated with this public inbox https://git.vuxu.org/mirror/zsh/ This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).