From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI,
	RCVD_IN_DNSWL_NONE,RDNS_NONE,SPF_PASS autolearn=no autolearn_force=no
	version=3.4.2
Received: (qmail 12836 invoked from network); 24 Mar 2020 01:34:09 -0000
Received-SPF:  pass (primenet.com.au: domain of zsh.org
  designates 203.24.36.2 as permitted sender)
  receiver=inbox.vuxu.org; client-ip=203.24.36.2
  envelope-from=<zsh-workers-return-45609-ml=inbox.vuxu.org@zsh.org>
Received: from unknown (HELO primenet.com.au) (203.24.36.2)
  by inbox.vuxu.org with ESMTP; 24 Mar 2020 01:34:09 -0000
Received: (qmail 6683 invoked by alias); 24 Mar 2020 01:33:58 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 45609
Received: (qmail 18100 invoked by uid 1010); 24 Mar 2020 01:33:58 -0000
X-Qmail-Scanner-Diagnostics: from rcpt-expgw.biglobe.ne.jp by f.primenet.com.au (envelope-from <takimoto-j@kba.biglobe.ne.jp>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.102.2/25758. spamassassin: 3.4.2.  
 Clear:RC:0(133.208.98.4):SA:0(-2.6/5.0):. 
 Processed in 2.025283 secs); 24 Mar 2020 01:33:58 -0000
X-Envelope-From: takimoto-j@kba.biglobe.ne.jp
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: pass (ns1.primenet.com.au: SPF record at spf01.biglobe.ne.jp designates 133.208.98.4 as permitted sender)
X-Biglobe-Sender: <takimoto-j@kba.biglobe.ne.jp>
From: Jun T <takimoto-j@kba.biglobe.ne.jp>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: [PATCH] find RLIM_NLIMITS correctly on Cygwin
Date: Tue, 24 Mar 2020 10:33:21 +0900
References: <82F8CDE0-C95C-4D31-ABFC-EBB3C97799F3@kba.biglobe.ne.jp>
 <bfcc331d-b892-48e2-9eac-17bfd73287ef@www.fastmail.com>
 <1B509B1C-A670-482F-9D88-2145E15D03A1@kba.biglobe.ne.jp>
 <20200109131553.hqetnd45sc43z6xb@tarpaulin.shahaf.local2>
 <087AE8B9-35B0-4258-9626-AACA85471A07@kba.biglobe.ne.jp>
 <20200111201549.GA1264@tarpaulin.shahaf.local2>
 <ACEA0FD1-BC91-4882-ACB2-3F66A35EDD85@kba.biglobe.ne.jp>
 <c0580696-d917-4658-9c35-0af0e0625c67@www.fastmail.com>
 <3340070A-53DD-40F0-8363-A8C7D84702D3@kba.biglobe.ne.jp>
 <374cecf6-45d5-4688-861f-cc52017dbcea@www.fastmail.com>
 <321F9465-ABF9-465D-9242-7EF9A0EDDBED@kba.biglobe.ne.jp>
 <20200320191846.3a4f5682@tarpaulin.shahaf.local2>
 <C2095B48-B142-4D70-98FF-CE9CB0953E10@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
In-Reply-To: <C2095B48-B142-4D70-98FF-CE9CB0953E10@kba.biglobe.ne.jp>
Message-Id: <FB8CDFB2-6DFC-4A39-AAC0-EBAE802F8D69@kba.biglobe.ne.jp>
X-Mailer: Apple Mail (2.3445.104.11)
X-Biglobe-Spnum: 61443


> 2020/03/23 14:41, I wrote:
> 
> Personally I feel only adding a test (B12limit.zsh) is enough for now, but
> have no objection to adding a runtime check in rlimits.c.

If I add the runtime check, and if there is a duplicated option letter,
I get the error message 'duplicate ulimit option letter' every time
I start zsh. This may be quite annoying for ordinary users.

B12limit.ztst (limit| grep UNKNOWN || print OK) fails due to the error
message; I think it's OK. But V01zmodload.ztst also fails due to the
message, and other tests would fail if they use the rlimits module.

So I think just adding a test for duplicated option letter is enough.
If someone add a new resource then it is their responsibility to
confirm that all the tests pass. I think ordinary users need not see
the error message.