From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 27152 invoked from network); 25 Aug 2023 04:57:00 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 25 Aug 2023 04:57:00 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1692939420; b=p1uScirqi2yDZXQdkeP+PzjuLcmRQRA1+M8LMcvrU/8cll6hzSL0i+Ud8dEW/8mLf5LK/oaS+I yGwPPU7SxNrHEnQ9wxwZVeYRDf5LchpRm/ubSQAt+teZRUndVl1lFSUrsQOsrqRfftZGo1xm4h 3YVSY0s3U0foP4CApTrQMrtLr3f1Ht5RED7eITGcCZSzFnAcv7I6KFp8LbPXM53Beei2n/qG+a kmJUJTp981au83Rn3Pn4ECFmg/wwNEiU2t9E0FwBlMD41yuK0VxkBH2QqKzg6gW60PKT6OmUF6 uduQYxOFNXDA3D31nxkBTnGdh+DFaCQEc0tLDsCoZaBfaA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (snd00012-bg.im.kddi.ne.jp) smtp.remote-ip=27.86.113.12; dmarc=none header.from=kba.biglobe.ne.jp; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1692939420; bh=2T5zrH2+sPsv7iABy/mMAlAOJ9NRwONGVCBxJG6nLKI=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Message-ID:In-Reply-To:To:References:Date:Subject: MIME-Version:Content-Transfer-Encoding:Content-Type:From:DKIM-Signature; b=bHFCy9ZJyc0gkUuDxwb3wohVgCzIk+jKBILkGoSoEnwpmQq8+I3mBLY25zAB/g58sTCN6Xjo+V 3Spp85UjgFc6Q1oQea5HK9ymbt/z1DQBfVtXPX7e4z7QF0nn1NQkImznRN1UJdpEUatumLk/AK ZCP5HCLuM3BJtkpNBVw5UnUxald7gASFjQYY0+bPR88uIiVjc866EuqGlqOSFyp2+wx26/rKoB sq6tJTwxZ3d32sqRKLk+SZi4Cy6wMNDhhY46hPzfL2NXkzbwF6cXt2+6Lh5sII1YdhaVjrMJ7D TI0muzuTMEpEcZWBAM8+Lao5Zptju2kEhTmLrmzJSqAlag==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Message-Id:In-Reply-To:To:References: Date:Subject:Mime-Version:Content-Transfer-Encoding:Content-Type:From: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=vxbyB0OMfuj6wiMgiKqz0+OWwwan8zagqDvhX+vQA/I=; b=awOOK0EV2+W0AfXrtNM28GGIgZ lX3/TTS9WNppRv9KS7iX1W/zeDglYYXEcKmh4E4jRRwynqI+yTfGyeO/WafuuHHB7jVguMbaGhWb/ AVbIe76DMU43USEQdREvZ8TGDlraTRTKuzxjAR2UIwytO2tDEerlWNMUuY0vGeUqq7UyrqpQZ2F/D 6AFLdHwUB4f7m5bzwhCc+86Ul3mhpmZEeJIF7HTzOr+puPEQarbHiLQq7d1916BhmUXAMqKilhTQl MT14wBkNAakeSmQG+he4weVuohYVeIBnsc2T627JFZrLZiKmHg7xJhvS0PBXfMWmy0UTLqeKonS/O mTWmxlhA==; Received: by zero.zsh.org with local id 1qZOsT-000KZs-Kq; Fri, 25 Aug 2023 04:56:57 +0000 Authentication-Results: zsh.org; iprev=pass (snd00012-bg.im.kddi.ne.jp) smtp.remote-ip=27.86.113.12; dmarc=none header.from=kba.biglobe.ne.jp; arc=none Received: from snd00012-bg.im.kddi.ne.jp ([27.86.113.12]:26849 helo=dfmta0028.biglobe.ne.jp) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1qZOrv-000KGO-E6; Fri, 25 Aug 2023 04:56:25 +0000 Received: from mail.biglobe.ne.jp by omta0028.biglobe.ne.jp with ESMTP id <20230825045617778.CUID.89814.mail.biglobe.ne.jp@biglobe.ne.jp> for ; Fri, 25 Aug 2023 13:56:17 +0900 From: Jun T Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: [PATCH 1/4] Update system_profiler completion Date: Fri, 25 Aug 2023 13:56:16 +0900 References: <20230823040004.171642-1-syohex@gmail.com> <20230823040004.171642-2-syohex@gmail.com> To: zsh-workers@zsh.org In-Reply-To: <20230823040004.171642-2-syohex@gmail.com> Message-Id: X-Mailer: Apple Mail (2.3445.104.21) X-Biglobe-Sender: takimoto-j@kba.biglobe.ne.jp X-Seq: 52089 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: > 2023/08/23 13:00, Shohei YOSHIDA wrote: >=20 > --- > Completion/Darwin/Command/_system_profiler | 3 ++- The patch is OK, of course. But _system_profiler has the following comment: # TODO: Should this be static? Calling `system_profiler -listDataTypes` = takes # about 0.07-0.08 secs on my machine. Does this list ever change = (between # different versions of OS X)? _data_types=3D( SP{AirPort,Applications,Audio,...(snip)...,WWAN}DataType = ) # the dynamic alternative is: #_data_types=3D( ${${(f)"$(_call_program path system_profiler = -listDataTypes 2>/dev/null)"}[2,-1]} ) At least on macOS Ventura (the latest), "system_profiler -listDataTypes" gives somewhat different list of data types. And I think the time required by this command is negligible (I can't notice any delay). So isn't it better to use the 'dynamic alternative' in the above = comment? The tag name 'path' used in the _call_program is not appropriate. It would be better to use, for example, 'data-types'.=