From: "Jun T." <takimoto-j@kba.biglobe.ne.jp>
To: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: Bug in C02cont.ztst's -N test
Date: Mon, 9 May 2016 22:42:34 +0900 [thread overview]
Message-ID: <FEE16E72-B6B1-4CDE-B32D-EB111C13240C@kba.biglobe.ne.jp> (raw)
In-Reply-To: <160430111131.ZM11437@torch.brasslantern.com>
On 2016/05/01, at 3:11, Bart Schaefer <schaefer@brasslantern.com> wrote:
> diff --git a/Test/C02cond.ztst b/Test/C02cond.ztst
(snip)
>
> - sleep 2
> - cat $unmodified
> - touch $newnewnew
(snip)
> + elif { (( ! $+unmodified_ls )) &&
> + { sleep 2; cat $unmodified } &&
(snip)
>
> else
> + touch $newnewnew
Moving 'touch $newnewnew' into the 'else' block causes a problem
on a system where the test for -N is skipped, for example Cygwin.
The file newnewnew is not created at all, and the next test
[[ $newnewnew -nt $zlnfs && ! ($unmodified -nt $zlnfs) ]]
fails.
diff --git a/Test/C02cond.ztst b/Test/C02cond.ztst
index b0e84dd..63c89dd 100644
--- a/Test/C02cond.ztst
+++ b/Test/C02cond.ztst
@@ -152,12 +152,14 @@
unmodified_ls="$(ls -lu $unmodified)"
print -u $ZTST_fd 'This test takes up to 60 seconds...'
fi
+ sleep 2
+ touch $newnewnew
if [[ $OSTYPE == "cygwin" ]]; then
ZTST_skip="[[ -N file ]] not supported on Cygwin"
elif (( isnfs )); then
ZTST_skip="[[ -N file ]] not supported with NFS"
elif { (( ! $+unmodified_ls )) &&
- { sleep 2; cat $unmodified } &&
+ cat $unmodified &&
{ df -k -- ${$(print -r -- "$mtab" |
awk '/noatime/ {print $1,$3}'):-""} | tr -s ' ' |
fgrep -- "$(df -k . | tail -1 | tr -s ' ')" } >&/dev/null } ||
@@ -168,7 +170,6 @@
done }; then
ZTST_skip="[[ -N file ]] not supported with noatime file system"
else
- touch $newnewnew
[[ -N $newnewnew && ! -N $unmodified ]]
fi
0:-N cond
next prev parent reply other threads:[~2016-05-09 14:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 0:20 Jason L Tibbitts III
2016-04-29 20:10 ` Bart Schaefer
2016-04-29 20:29 ` Jason L Tibbitts III
2016-04-29 20:31 ` Jason L Tibbitts III
2016-04-30 0:03 ` Bart Schaefer
2016-04-29 22:38 ` Jason L Tibbitts III
2016-04-30 0:46 ` Daniel Shahaf
2016-04-30 1:01 ` Matthew Martin
2016-04-30 1:28 ` Daniel Shahaf
2016-04-30 3:51 ` Bart Schaefer
2016-04-30 17:55 ` Bart Schaefer
2016-04-30 18:11 ` Bart Schaefer
2016-05-01 1:48 ` Daniel Shahaf
2016-05-01 4:42 ` Bart Schaefer
2016-05-09 13:42 ` Jun T. [this message]
2016-05-09 16:21 ` Bart Schaefer
2016-05-09 17:32 ` Jun T.
2016-05-10 3:33 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FEE16E72-B6B1-4CDE-B32D-EB111C13240C@kba.biglobe.ne.jp \
--to=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).