zsh-workers
 help / color / mirror / code / Atom feed
From: Wayne Davison <wayne@clari.net>
To: zsh-workers@sunsite.auc.dk
Subject: PATCH: pws-22: history -r fix
Date: Wed, 16 Jun 1999 13:46:56 -0700 (PDT)	[thread overview]
Message-ID: <Pine.GSO.4.10.9906161339370.20632-100000@house.clari.net> (raw)
In-Reply-To: <990616081913.ZM29592@candle.brasslantern.com>

On Wed, 16 Jun 1999, Bart Schaefer wrote:
> On a possibly-related note, "history -r" seems to be broken now

Yes, the start-of-loop check was wrong.  Here's a patch:

Index: Src/builtin.c
--- zsh-3.1.5-pws-22/Src/builtin.c	Mon Jun 14 09:14:30 1999
+++ ./Src/builtin.c	Wed Jun 16 13:37:17 1999
@@ -1349,7 +1349,7 @@
 	fclistdone = 1;
 
     ent = gethistent(first, first < last? GETHIST_DOWNWARD : GETHIST_UPWARD);
-    if (!ent || ent->histnum < first || ent->histnum > last) {
+    if (!ent || (first < last? ent->histnum > last : ent->histnum < last)) {
 	if (first == last)
 	    zwarnnam("fc", "no such event: %d", NULL, first);
 	else

..wayne..




  reply	other threads:[~1999-06-16 20:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-06-15 13:10 history related suggestions Kiddle, Oliver
1999-06-15 15:27 ` Peter Stephenson
1999-06-16  8:19 ` history related suggestions (plus bug reports) Bart Schaefer
1999-06-16 20:46   ` Wayne Davison [this message]
1999-06-16 21:59   ` Wayne Davison
1999-06-17  6:33     ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.GSO.4.10.9906161339370.20632-100000@house.clari.net \
    --to=wayne@clari.net \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).