From: Janos Farkas <chexum@shadow.banki.hu>
To: Zoltan Hidvegi <hzoli@cs.elte.hu>
Cc: zsh-workers@math.gatech.edu
Subject: Re: $BAUD is strange on Linux for 115200
Date: Mon, 24 Jun 1996 20:15:06 +0200 (MET DST) [thread overview]
Message-ID: <Pine.LNX.3.93.960624200905.8113A-100000@shadow.banki.hu> (raw)
In-Reply-To: <199606241754.TAA05385@bolyai.cs.elte.hu>
On Mon, 24 Jun 1996, Zoltan Hidvegi wrote:
[about the following patch]
> > # if defined(HAVE_TCGETATTR) && defined(HAVE_TERMIOS_H)
> > tempbaud = cfgetospeed(&shttyinfo->tio);
> > +#if defined CBAUDEX && CBAUDEX > 100
> > + /* If we have CBAUDEX, then it's a mask of the extended
> > + speeds, and the baud rates are still encoded. At least
> > + this is so on Linux, and I hope this logic is true on
> > + most systems. */
> > +#else
> > if (tempbaud >= 100)
> > return tempbaud;
> > else
> > +#endif
> Is'n it better to move the tempbaud >= 100 check to the default case in
> switch (speedcode) (modifying the type of speedcode from int to long)?
> I'm sure that if cfgetospeed() returns the value of a B... macro than its
> the logical meaning should always be used.
For me, it's ok; but I thought it were there for purpose. Maybe POSIX
doesn't define that speed_t can only contain Bxxxx constants, or some
(maybe non-POSIX) systems are broken in this aspect, or maybe some can
get away with B9600=9600 and so they don't really need constants...
This way, we hopefully won't break on anyone's system... Or, that's what
beta-testing is for? :)
Janos
prev parent reply other threads:[~1996-06-24 18:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
1996-06-24 17:14 Janos Farkas
1996-06-24 17:54 ` Zoltan Hidvegi
1996-06-24 18:15 ` Janos Farkas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.3.93.960624200905.8113A-100000@shadow.banki.hu \
--to=chexum@shadow.banki.hu \
--cc=hzoli@cs.elte.hu \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).