From: Wayne Davison <wayned@users.sourceforge.net>
To: Zsh Workers <zsh-workers@sunsite.auc.dk>
Subject: spaceflag question; remhist() going away
Date: Sun, 16 Jul 2000 18:54:27 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.21.0007161822390.23825-100000@phong.blorf.net> (raw)
There's a variable that gets set in input.c called "spaceflag". It
gets set if the first character of the first line is a space. Later
on, the history code checks this flag when the HIST_IGNORE_SPACE
option is set. Can anyone tell me why the history code doesn't just
check if (*chline == ' ') instead of checking spaceflag? I've removed
this variable from my local source, and everything appears to be
working just fine without it.
In a related area, I've dumped the function remhist() in my local
source. This function is a constant source of bugs, and I found
yet another bug today: if you have HIST_IGNORE_SPACE set along
with HIST_NO_STORE, you lose a line of history every time you type
" history" (note the leading space).
I've been wanting to dump remhist() for some time now due to how it
does not properly interact with the INC_APPEND_HIST & SHARE_HISTORY
options. My solution is to use string matching of the command line
to determine if this is a command that should not be saved. I'm also
considering adding a general-purpose environment variable that would
allow the user to specify an arbitrary pattern that would cause the
current command line not to be stored in the history. I was thinking
about calling it $HISTIGNOREMATCH.
Comments are welcomed.
..wayne..
next reply other threads:[~2000-07-17 1:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-07-17 1:54 Wayne Davison [this message]
2000-07-17 8:57 ` Peter Stephenson
2000-07-17 10:04 ` Wayne Davison
2000-07-17 16:46 ` Bart Schaefer
2000-07-17 18:29 ` Wayne Davison
2000-07-17 19:44 ` Wayne Davison
2000-07-18 5:23 Felix Rosencrantz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.21.0007161822390.23825-100000@phong.blorf.net \
--to=wayned@users.sourceforge.net \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).