Space-expansion problem in dev-8

Space-expansion problem in dev-8

[Wayne Davison]

I just upgraded from dev-7 to dev-8 to try to fix the following problem,
but it is still there.

If a filename contains spaces (or other escapable characters) and you
expand it via wild-carding, the spaces are not escaped.

For instance:

% zsh -f
% touch 'a b c d e'
% autoload -U compinit
% compinit
% zstyle ':completion:*' completer _expand _complete
% bindkey '\t' complete-word
% ls a*<TAB>

One of the offered suggestions is "a b c d e" rather than "a\ b\ c\ d\ e".
If I complete it without the '*' or expand it without changing tab's key
binding, it works properly.

..wayne..

Re: Space-expansion problem in dev-8

[Peter Stephenson]

> If a filename contains spaces (or other escapable characters) and you
> expand it via wild-carding, the spaces are not escaped.

The fix is probably something like the following, but Sven may have better
ideas.  This is leaving my cursor at the end of the word for some reason.
Probably _expand was written before ${(q)...} existed.

Index: Completion/Core/_expand
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Core/_expand,v
retrieving revision 1.33
diff -u -r1.33 _expand
--- Completion/Core/_expand	2000/10/11 12:19:24	1.33
+++ Completion/Core/_expand	2001/02/01 17:46:47
@@ -68,7 +68,7 @@
 # Now try globbing.
 
 [[ "$force" = *g* ]] || zstyle -T ":completion:${curcontext}:" glob &&
-    eval 'exp=( ${~exp} ); exp=( ${exp//(#b)([][()|*?^#~<>\\=])/\\${match[1]}} )' 2>/dev/null
+    eval 'exp=( ${~exp} ); exp=( ${(q)exp} )' 2>/dev/null
 
 # If we don't have any expansions or only one and that is the same
 # as the original string, we let other completers run.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
Cambridge Silicon Radio, Unit 300, Science Park, Milton Road,
Cambridge, CB4 0XL, UK                          Tel: +44 (0)1223 392070

Re: Space-expansion problem in dev-8

[Sven Wischnowsky]

Peter Stephenson wrote:

> > If a filename contains spaces (or other escapable characters) and you
> > expand it via wild-carding, the spaces are not escaped.
> 
> The fix is probably something like the following, but Sven may have better
> ideas.  This is leaving my cursor at the end of the word for some reason.
> Probably _expand was written before ${(q)...} existed.

Hm, maybe. I don't remember why we used that instead of (q), I have
only a very faint memory of problems with (q) when that quoted more
than we wanted but unfortunately I don't remember what that was (and
not even in _expand, but in some other completion function, I think).

So for now I've just committed Peter's patch and left the old stuff
commented out.

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de