From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-16195-mason-zsh=primenet.com.au@sunsite.dk>
Received: (qmail 21323 invoked from network); 30 Oct 2001 18:26:58 -0000
Received: from ns2.primenet.com.au (HELO primenet.com.au) (?ELi9EQq85Sm76C9XJ2cXRHJ/GNj1XTeI?@203.24.36.3)
  by ns1.primenet.com.au with SMTP; 30 Oct 2001 18:26:58 -0000
Received: (qmail 2331 invoked from network); 30 Oct 2001 18:26:57 -0000
Received: from sunsite.dk (130.225.247.90)
  by proxy.melb.primenet.com.au with SMTP; 30 Oct 2001 18:26:57 -0000
Received: (qmail 22464 invoked by alias); 30 Oct 2001 18:26:50 -0000
Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm
Precedence: bulk
X-No-Archive: yes
X-Seq: 16195
Received: (qmail 22453 invoked from network); 30 Oct 2001 18:26:48 -0000
Date: Tue, 30 Oct 2001 10:25:20 -0800 (PST)
From: Wayne Davison <wayned@users.sourceforge.net>
X-Sender: wayne@life.blorf.net
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@sunsite.dk
Subject: Re: .zsh_history bugreport
In-Reply-To: <1011030173655.ZM30372@candle.brasslantern.com>
Message-ID: <Pine.LNX.4.21.0110301018500.31194-100000@life.blorf.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII

On Tue, 30 Oct 2001, Bart Schaefer wrote:
> 16184 probably should go onto the patches branch, too.

Cool.  I just put it there.

One other potential change:  Should readhistline() return "start"
instead of "0" when fgets() fails?  Having fgets() fail with a non-0
start value doesn't look like a very common scenario (because of the
feof() calls), but if we've got some characters in the string, I figure
we might as well return them.  Do you agree?

Index: Src/hist.c
--- Src/hist.c	2001/10/26 23:47:10	1.36
+++ Src/hist.c	2001/10/30 18:19:46
@@ -1793,7 +1793,7 @@
 	}
 	return len;
     }
-    return 0;
+    return start;
 }
 
 /**/

..wayne..