PATCH: fix compiler warnings

PATCH: fix compiler warnings

[Wayne Davison]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 324 bytes --]

The attached patch fixes an unused-variable warning, two warnings
about static variables that were defined but never used, and several
warnings about prototyped static functions that are never defined.
(All these warnings only showed up if HAVE_TIGETSTR was not defined.)

I went ahead and checked this into CVS.

..wayne..

[-- Attachment #2: silence some compiler warnings --]
[-- Type: TEXT/PLAIN, Size: 988 bytes --]

Index: Src/Modules/terminfo.c
@@ -30,13 +30,14 @@
 #include "terminfo.mdh"
 #include "terminfo.pro"
 
+/**/
+#ifdef HAVE_TIGETSTR
+
 static char terminfo_nam[] = "terminfo";
 static Param terminfo_pm;
 
 /* echoti: output a terminfo capability */
 
-#ifdef HAVE_TIGETSTR
-
 /**/
 static int
 bin_echoti(char *name, char **argv, char *ops, int func)
@@ -79,11 +80,13 @@
     return 0;
 }
 
-#else
+/**/
+#else /* !HAVE_TIGETSTR */
 
 #define bin_echoti bin_notavail
 
-#endif
+/**/
+#endif /* !HAVE_TIGETSTR */
 
 static struct builtin bintab[] = {
     BUILTIN("echoti", 0, bin_echoti, 1, -1, 0, NULL, NULL),
@@ -93,6 +96,7 @@
 
 static int incleanup;
 
+/**/
 #ifdef HAVE_TIGETSTR
 
 /* Empty dummy function for special hash parameters. */
@@ -195,6 +199,7 @@
 {
 }
 
+/**/
 #endif /* HAVE_TIGETSTR */
 
 /**/
@@ -225,7 +230,9 @@
 int
 cleanup_(Module m)
 {
+#ifdef HAVE_TIGETSTR
     Param pm;
+#endif
 
     incleanup = 1;
 

Re: PATCH: fix compiler warnings

[Wayne Davison]

On Mon, 9 Apr 2001, Wayne Davison wrote:
> The attached patch fixes [...] two warnings about static variables
> that were defined but never used

Sigh.  Bart's unposted change made one of the variables necessary in
the HAVE_TIGETSTR case, but I checked my change in before recompiling.
(Bad! Bad Wayne!)  I've fixed this in CVS.  The change looks like
this:

Index: Src/Modules/terminfo.c
@@ -30,10 +30,11 @@
 #include "terminfo.mdh"
 #include "terminfo.pro"

+static char terminfo_nam[] = "terminfo";
+
 /**/
 #ifdef HAVE_TIGETSTR

-static char terminfo_nam[] = "terminfo";
 static Param terminfo_pm;

 /* echoti: output a terminfo capability */

..wayne..