From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10387 invoked from network); 16 Jun 2001 06:25:35 -0000 Received: from sunsite.dk (130.225.51.30) by ns1.primenet.com.au with SMTP; 16 Jun 2001 06:25:35 -0000 Received: (qmail 15346 invoked by alias); 16 Jun 2001 06:25:04 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 14943 Received: (qmail 15333 invoked from network); 16 Jun 2001 06:25:03 -0000 Date: Fri, 15 Jun 2001 23:24:46 -0700 (PDT) From: Wayne Davison X-X-Sender: To: Zsh hackers list Subject: Re: PATCH: 4.1.0: mkstemp In-Reply-To: <1010616030727.ZM4354@candle.brasslantern.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII On Sat, 16 Jun 2001, Bart Schaefer wrote: > You should have made a ChangeLog entry, or deleted PWS's ... Thanks, I got distracted there for a moment. I've committed my ChangeLog entry. > if (close(mkstemp(ret = dyncat(unmeta(s), "XXXXXX"))) < 0 || > unlink(ret) < 0) Oooh, slimey! That would sure silence the (dubious) warning, but I would hate the extra open/close/unlink. Perhaps we should just link in a work-alike mktemp() function that doesn't generate a warning? ..wayne..