From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-19921-mason-zsh=primenet.com.au@sunsite.dk>
Received: (qmail 9444 invoked from network); 11 May 2004 16:27:27 -0000
Received: from thor.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.86)
  by ns1.primenet.com.au with SMTP; 11 May 2004 16:27:27 -0000
Received: (qmail 8258 invoked from network); 11 May 2004 16:27:17 -0000
Received: from sunsite.dk (130.225.247.90)
  by a.mx.sunsite.dk with SMTP; 11 May 2004 16:27:17 -0000
Received: (qmail 17918 invoked by alias); 11 May 2004 16:27:16 -0000
Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm
Precedence: bulk
X-No-Archive: yes
X-Seq: 19921
Received: (qmail 17907 invoked from network); 11 May 2004 16:27:16 -0000
Received: from thor.dotsrc.org (HELO a.mx.sunsite.dk) (qmailr@130.225.247.86)
  by sunsite.dk with SMTP; 11 May 2004 16:27:12 -0000
Received: (qmail 8098 invoked from network); 11 May 2004 16:27:12 -0000
Received: from unknown (HELO moonbase.zanshin.com) (root@167.160.213.139)
  by a.mx.sunsite.dk with SMTP; 11 May 2004 16:27:10 -0000
Received: from toltec.zanshin.com (toltec.zanshin.com [64.84.47.166])
	by moonbase.zanshin.com (8.12.11/8.12.11) with ESMTP id i4BGQuYi012461
	for <zsh-workers@sunsite.dk>; Tue, 11 May 2004 09:26:56 -0700
Date: Tue, 11 May 2004 09:26:50 -0700 (PDT)
From: Bart Schaefer <schaefer@brasslantern.com>
Sender: schaefer@toltec.zanshin.com
Reply-To: Zsh hackers list <zsh-workers@sunsite.dk>
To: Zsh hackers list <zsh-workers@sunsite.dk>
Subject: Re: PATCH: heap reallocation
In-Reply-To: <20882.1084290045@csr.com>
Message-ID: <Pine.LNX.4.44.0405110924220.13856-100000@toltec.zanshin.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Spam-Checker-Version: SpamAssassin 2.63 on a.mx.sunsite.dk
X-Spam-Level: 
X-Spam-Status: No, hits=0.0 required=6.0 tests=none autolearn=no version=2.63
X-Spam-Hits: 0.0

On Tue, 11 May 2004, Peter Stephenson wrote:

> a careful look would be appreciated.

This looks like a bug (some lines trimmed):

> +#ifdef USE_MMAP
> +	    Heap hnew;
> +
> +#else
> +	    h = (Heap) realloc(h, n);
> +#endif
> +
> +	    hnew->size = n;

Using hnew outside the #ifdef where it is declared.  Should be h->size ?