From: "Peter A. Castro" <doctor@fruitbat.org>
To: Motoi Washida <a66@h8.dion.ne.jp>
Cc: Peter Stephenson <pws@csr.com>,
Zsh hackers list <zsh-workers@sunsite.dk>
Subject: Re: 4.2.4 failure on MacOS X
Date: Fri, 4 Feb 2005 11:10:41 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.58.0502041103400.17079@ming.fruitbat.org> (raw)
In-Reply-To: <a2cd090851702fd1519fbabaa1e3ab4f@h8.dion.ne.jp>
On Fri, 4 Feb 2005, Motoi Washida wrote:
> I also failed to build zsh on Mac OS X 10.3.7.
>
> I think this is because configure can't find iconv(), because iconv()
> is defined as libiconv() in /usr/include/iconv.h and the configure
> script checks iconv() without using the header file.
>
> I modified configure.ac a bit and seems to work. Here is the patch.
Excellent! It seems Darwin and Cygwin share a similar implementation.
Maybe it can simply be made generic? :
AC_CHECK_LIB(iconv, iconv)
AC_CHECK_LIB(iconv, libiconv)
Presumably it's unlikely that both iconv() and libiconv() would exist?
FWIW, I did hack an iconv test which #include the header, if detected,
but this started to get more complicated than it was worth and opt'ed for
simply looking for the real symbol name.
> --
> Motoi Washida
>
>
>
> Index: configure.ac
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/configure.ac,v
> retrieving revision 1.25
> diff -d -u -r1.25 configure.ac
> --- configure.ac 1 Feb 2005 10:53:10 -0000 1.25
> +++ configure.ac 3 Feb 2005 18:42:05 -0000
> @@ -729,10 +729,11 @@
>
> AC_CHECK_LIB(iconv, iconv)
>
> -if test "$host_os" = cygwin; then
> -dnl cygwin iconv() is really libiconv()
> -AC_CHECK_LIB(iconv, libiconv)
> -fi
> +case "$host_os" in
> + cygwin | darwin*)
> + dnl cygwin iconv() is really libiconv()
> + AC_CHECK_LIB(iconv, libiconv) ;;
> +esac
>
> if test x$enable_pcre = xyes; then
> dnl pcre-config should probably be employed here
--
Peter A. Castro <doctor@fruitbat.org> or <Peter.Castro@oracle.com>
"Cats are just autistic Dogs" -- Dr. Tony Attwood
prev parent reply other threads:[~2005-02-04 21:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-03 16:15 Peter Stephenson
2005-02-03 16:28 ` Bart Schaefer
2005-02-03 17:10 ` Peter Stephenson
2005-02-03 18:32 ` Clint Adams
2005-02-04 18:59 ` Peter A. Castro
2005-02-03 17:19 ` Peter Stephenson
2005-02-04 18:55 ` Peter A. Castro
2005-02-03 19:01 ` Motoi Washida
2005-02-04 10:35 ` Peter Stephenson
2005-02-04 19:10 ` Peter A. Castro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0502041103400.17079@ming.fruitbat.org \
--to=doctor@fruitbat.org \
--cc=a66@h8.dion.ne.jp \
--cc=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).