zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@sunsite.dk
Subject: Re: More POSIX developments
Date: Sat, 2 Oct 2004 14:23:54 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.61.0410021419240.25270@toltec.zanshin.com> (raw)
In-Reply-To: <200409271104.i8RB4URU009112@news01.csr.com>

Finally got a chance to look at this.

On Mon, 27 Sep 2004, Peter Stephenson wrote:

> The following patch, which I won't commit until we've decided which way
> to go, tries to cover the bases by making test work (more) like POSIX
> while leaving [[ ... ]] the way it is.  The errors now return status 2
> from evalcond, but for backward compatibility [[ ... ]] turns them into
> shell errors.

I think this would be OK.

> I needed to add an extra warning function to choose between the cases
> where we have a builtin name and where the code is called internally as
> a condition.  Does anyone know if there's a reason zwarnnam handles the
> absence of a command name in a strange way?

I paged through a grep of all the calls to zwarnnam(), and there don't
seem to be any that intentionally get passed a NULL first argument, so it
probably is just defensive programming.

> In other words, could I remove zwarnnamopt and make zwarnnam behave like 
> that?

I think that'd be safe, but I wouldn't object to a second opinion.


  reply	other threads:[~2004-10-02 21:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-25  2:08 Bart Schaefer
2004-09-27 11:04 ` Peter Stephenson
2004-10-02 21:23   ` Bart Schaefer [this message]
2004-10-04 10:23     ` Peter Stephenson
2004-10-04 10:49       ` Oliver Kiddle
2004-10-25 16:05       ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61.0410021419240.25270@toltec.zanshin.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).