[rr13@mail.inf.tu-dresden.de: Bug#276187: zsh: Ineractive menu completion with tab doesnt work.]

[rr13@mail.inf.tu-dresden.de: Bug#276187: zsh: Ineractive menu completion with tab doesnt work.]

[Clint Adams]

I can reproduce this.  The garbage characters are predominantly NULs
with a \022 thrown in.

----- Forwarded message from Rene Reusner <rr13@mail.inf.tu-dresden.de> -----

On a sarge box i discovered the following bug with the new zsh.
I use interactive menu completion and normaly i scroll through
the items via tab, but this doesnt work on the new zsh anymore.

Description: 
I type an command, like ls, type a space
and then press tab, to get the filelist.
A menu appears with the files in this directory and the first entry
is selected.
Then normaly, i press tab again and again, to cycle through
these items. But this doesnt work anymore, the shell puts some weird 
chars in the prompt, like ^@^@^@ and i cant use tab anymore.

Example:

ls
<tab> .. to get the list, this works
<tab> .. normaly to scroll through the list, but the new zsh print some
weird characters and i cant use tab anymore.

copy from the terminal
neodym% ^@^@^@
interactive: []
0307.pdf                        < first selected item.
113240-10.jar
115738-03.zip
3com_manage.pdf


A work around is, to press some cursor keys to move around in this menu, but
the resulting completion is wrong.  ^@^ is inserted before the filename
and the resulting filename is wrong.

I also deleted the .zcompdump and started a new shell and also emptied
my .zsenv only for the important settings.
My terminal is a normal xterm.

My .zshenv is:

autoload -U compinit
compinit -C # don't perform security check
compinit -u 
zstyle ':completion:*' menu select interactive


nothing more

On the old shell on woody, Version is 4.07 the menu completion works
fine.
This bug makes the new zsh with interactive menucompletion 
nearby unusually for me.

----- End forwarded message -----

Re: [rr13@mail.inf.tu-dresden.de: Bug#276187: zsh: Ineractive menu completion with tab doesnt work.]

[Bart Schaefer]

On Tue, 12 Oct 2004, Clint Adams wrote:

> I can reproduce this.  The garbage characters are predominantly NULs
> with a \022 thrown in.

I can reproduce it with a build from the 4.2.0 release, so it's been a 
while.  Obviously interactive menu completion is not a widely-used mode.

I'm a little confused by this remark:

> ----- Forwarded message from Rene Reusner <rr13@mail.inf.tu-dresden.de> -----
> 
> On the old shell on woody, Version is 4.07 the menu completion works
> fine.

As far as I can tell from the commit history, 4.0.7 never had interactive
menu completion mode.  It was added 2002/06/26 but 4.0 branched off as of
2001/06/13.

Sven W. seems to have believed interactive mode was still working as of a 
commit on 2002/07/05, and none of the changes to complist.c since then 
appear to make any difference, so either Sven was wrong or the bug is in
some other part of the completion system and merely manifests in complist.

Re: [rr13@mail.inf.tu-dresden.de: Bug#276187: zsh: Ineractive menu completion with tab doesnt work.]

[Clint Adams]

> I'm a little confused by this remark:
> 
> > ----- Forwarded message from Rene Reusner <rr13@mail.inf.tu-dresden.de> -----
> > 
> > On the old shell on woody, Version is 4.07 the menu completion works
> > fine.
> 
> As far as I can tell from the commit history, 4.0.7 never had interactive
> menu completion mode.  It was added 2002/06/26 but 4.0 branched off as of
> 2001/06/13.

It's possible that the 4.07 [sic] to which he refers had that patch
applied.  Since the last version to ship with woody was a patched 4.0.4,
I have no idea what he really has.

Re: [rr13@mail.inf.tu-dresden.de: Bug#276187: zsh: Ineractive menu completion with tab doesnt work.]

[pws]

> On a sarge box i discovered the following bug with the new zsh.
> I use interactive menu completion and normaly i scroll through
> the items via tab, but this doesnt work on the new zsh anymore.
> 
> Description: 
> I type an command, like ls, type a space
> and then press tab, to get the filelist.
> A menu appears with the files in this directory and the first entry
> is selected.
> Then normaly, i press tab again and again, to cycle through
> these items. But this doesnt work anymore, the shell puts some weird 
> chars in the prompt, like ^@^@^@ and i cant use tab anymore.

I can see the part of the code which is causing this: modline in the function
domenuselect is inconsistently handled.  At one point it gets assigned just
the combined prefix and suffix from the last completion, but everywhere else it's
assumed it's the whole line.

However, I'm not quite sure what this is supposed to do.  Evidently it's supposed to
something special, not simply  normal menu completion, but I don't really know what.
After fixing or blocking out the problem, it just does normal menucompletion, i.e.
the fact you're in ineractive completion doesn't make a difference.

pws

-- 

Whatever you Wanadoo:
http://www.wanadoo.co.uk/time/

This email has been checked for most known viruses - find out more at: http://www.wanadoo.co.uk/help/id/7098.htm

Re: [rr13@mail.inf.tu-dresden.de: Bug#276187: zsh: Ineractive menu completion with tab doesnt work.]

[Bart Schaefer]

On Wed, 13 Oct 2004 pws@pwstephenson.fsnet.co.uk wrote:

> I can see the part of the code which is causing this: modline in the 
> function domenuselect is inconsistently handled.  At one point it gets 
> assigned just the combined prefix and suffix from the last completion, 
> but everywhere else it's assumed it's the whole line.

There's only one other assignment to it that I can see.

> However, I'm not quite sure what this is supposed to do.  Evidently it's 
> supposed to something special, not simply normal menu completion, but I 
> don't really know what.

I think what's supposed to happen is this:

You enter interactive completion (this may e.g. require two presses of TAB 
depending on your other menu completion/listing settings).  At this point, 
if you start typing the disambiguating characters, the menu list changes 
on the fly to show the changing subset (or superset, for corrections) of 
the possible completions that match, and backspace widens the list again.

This part all works fine.

If you type TAB again in this mode, though, it's not clear what should 
happen.  If you've already begun to disambiguate, typing TAB does nothing.  
The bug happens when you type TAB immediately after entering interactive 
completion, before any disambiguation has occurred.  I suspect in this 
case it's fine just to drop straight back into normal menulist completion 
and cancel interactive mode.  (Ideally that would happen even after the 
disambiguation has begun, too, rather than have TAB be a no-op there.)

> After fixing or blocking out the problem, it just does normal 
> menucompletion, i.e. the fact you're in ineractive completion doesn't 
> make a difference.

Fixing how?