From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 584 invoked by alias); 1 Mar 2018 01:17:19 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42412 Received: (qmail 5796 invoked by uid 1010); 1 Mar 2018 01:17:19 -0000 X-Qmail-Scanner-Diagnostics: from mail-oln040092000102.outbound.protection.outlook.com (unknown@mail-oln040092000102.outbound.protection.outlook.com) by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(40.92.0.102):SA:0(-1.9/5.0):. Processed in 2.015302 secs); 01 Mar 2018 01:17:19 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_FONT_LOW_CONTRAST,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS, T_DKIM_INVALID,T_RP_MATCHES_RCVD autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: krokodileglue@outlook.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Gtbs7ifdrIv72gKPTFcmNiT4D6PGPjBNu0Cpn6ZmVw8=; b=qr6vyO9Fp8rAsWrI1rTq47ZFyWTUSb/HLp3wh4woru6+LsEzperJ/0ykVm/xsXUoibPePWy8hSIBm7EePl9H7uZma5US4THpVPP06EyVy1STXXiSWIOFwkZPkqFxUhnbzXME5ee+YNsF09eoXRftoOGoPaOC/xsDtCYEeoLAd3+VgEaxvITMMkZ7vygL24NnjCmuoZ0zzArvbMyyYs5uMSg2tt72wbIpnOhoGUpGFVWaUkx9vFENUFTbs9tCW2LPqsPuMIQ3oO/p8hYBrgrHyz9zW9EQLT9rnuT/9+HQc76KhjaJW50WExy8th/kpOIF4GKVKZ9k1Sv0iOsyXDzf9Q== From: Taylor West To: "zsh-workers@zsh.org" Subject: Re: [PATCH] remove unnecessary checks for NULL in zfree and zsfree Thread-Topic: [PATCH] remove unnecessary checks for NULL in zfree and zsfree Thread-Index: AQHTsPrO5gNXQaJqDUyao2SqzTE4qaO6k/bI Date: Thu, 1 Mar 2018 01:17:12 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:8913C2891418768C6327688CB627C571CD7EBEF9BE310FCBD7CF4922145C8942;UpperCasedChecksum:081658083FF82C5360D37B8A7BC592F2E6DF726EFF9A7A342599BF53560D2682;SizeAsReceived:7053;Count:45 x-tmn: [T1BzfnOhq7fe0kcocrUhFODOoaMsV3i7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BY2NAM01HT113;6:+zKU2zye10wC8n8HQhKTq/qjGJ/vw8EfixveNNHFq6cYg4WuE62E8HX2ByoOOR9KIKQo36gBveC3jU3IftKpNITYfh+adKwpc3xsbRC/Vr1c8hSJuKA4P944fJZFzruR9CJWKUmjKnPFx6tGwwYPgtWS/WImVxvd3C5JlAxQJRHrAWLjd/WtWzXRidjzrwqjjohR+zBZCtNOwX24/OB7s7g5IOhB1bAMxeLVoc+/Ic26gYvAb6dnyJ5ljcw6rcHCjqb/CUwQAkFxZuLayUG+Z5fhaHp0mqtTWfxG81gZab9X+bCW18HFX1GXJfhNxwuT4qWP/SUvE1J4ohhC7MWlOfk2qEEuxQ8fYLAKvWf7XVg=;5:+WZazzoQto49VKbHTZW7V2Y7kWmAK3GcwRahg/SH8KabfnRr/ZOBGYaTivGYMfEgIkY61MSJwfuQ8LGLMkLctt8jvuCRk+JEwgn7axHdr8oVQXKmK1TiaKoDZu/4UqHXe3ChlAq7nV4W+KAV7a8HBwlaB/+j04gyp1RZgHFdYGY=;24:fho1pFQR3F32cvn+b7aqyDeN4A9SYYIEtd5wB2vF3ye0PnMMR+NnRJKz4EYueTtNpV+fyFo0iE1bfZed3KOnaI6nV/iwsU+rHROYhNaa9QQ=;7:RsBXPV6vAT8ODwA59luYOYO4cPcs4cDL8KKJOVn2gVviMl4O2uW4965QsiUnJ8POV8LbSB4Ws62HpdJ+buBxjxQTQ+BvEL63WWelYnJyVRfNjiuWM8ETsLJtcGg/hGEzC/Ay5RpL5Cufkv8IPSyIaV/HDjGW5rNiTtLCbVvvNkvlxFiawMrmn2mU86HlN3Gz9Y2m4nAaAV8x3DgjwNj7pixznnevc9GpkPd4mKihHnYkd6JsbRoHNniIMnOb9XqU x-incomingheadercount: 45 x-eopattributedmessage: 0 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1603101448)(1601125374)(1701031045);SRVR:BY2NAM01HT113; x-ms-traffictypediagnostic: BY2NAM01HT113: x-ms-office365-filtering-correlation-id: 991d122e-68d9-4433-8fb0-08d57f122958 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(444000031);SRVR:BY2NAM01HT113;BCL:0;PCL:0;RULEID:;SRVR:BY2NAM01HT113; x-forefront-prvs: 05986C03E0 x-forefront-antispam-report: SFV:NSPM;SFS:(7070007)(98901004);DIR:OUT;SFP:1901;SCL:1;SRVR:BY2NAM01HT113;H:SN1PR06MB2288.namprd06.prod.outlook.com;FPR:;SPF:None;LANG:; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: multipart/alternative; boundary="_000_SN1PR06MB22887FAE0FD9C98D54754312B1C60SN1PR06MB2288namp_" MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 991d122e-68d9-4433-8fb0-08d57f122958 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2018 01:17:12.2133 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2NAM01HT113 --_000_SN1PR06MB22887FAE0FD9C98D54754312B1C60SN1PR06MB2288namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable According to section 7.22.3.3 paragraph 2 of the final committee draft of the C11 standard, if free() is passed a NULL pointer then "no action occurs". The current checks on `p' in zfree and zsfree are unnecessary---this patch removes them. ________________________________ From: Taylor West Sent: Wednesday, February 28, 2018 5:15 PM To: zsh-workers@zsh.org Cc: Taylor West Subject: [PATCH] remove unnecessary checks for NULL in zfree and zsfree --- Src/mem.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Src/mem.c b/Src/mem.c index f120819..77e4375 100644 --- a/Src/mem.c +++ b/Src/mem.c @@ -1885,16 +1885,14 @@ bin_mem(char *name, char **argv, Options ops, int f= unc) mod_export void zfree(void *p, UNUSED(int sz)) { - if (p) - free(p); + free(p); } /**/ mod_export void zsfree(char *p) { - if (p) - free(p); + free(p); } /**/ -- 2.9.5 --_000_SN1PR06MB22887FAE0FD9C98D54754312B1C60SN1PR06MB2288namp_--