zsh-workers
 help / color / mirror / code / Atom feed
* Make Failure on SunOS-4.1
@ 2001-04-24 19:43 Vin Shelton
  2001-04-25  4:13 ` Bart Schaefer
  0 siblings, 1 reply; 22+ messages in thread
From: Vin Shelton @ 2001-04-24 19:43 UTC (permalink / raw)
  To: zsh-workers

Using the latest CVS sources, I can build fine against SunOS-5.5, but
building under 4.1 gives me the following errors:

gcc -c -I.  -DHAVE_CONFIG_H -Wall -Wno-implicit -Wmissing-prototypes -O2  -o parameter.o /u/shelton/new/src/zsh-2001-04-24/Src/Modules/parameter.c
echo '' parameter.o | sed 's" " Modules/"g' >> ../../Src/stamp-modobjs.tmp
gcc -c -I.  -DHAVE_CONFIG_H -Wall -Wno-implicit -Wmissing-prototypes -O2  -o termcap.o /u/shelton/new/src/zsh-2001-04-24/Src/Modules/termcap.c
In file included from /usr/include/sgtty.h:6,
                 from /u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/curses.h:20,
                 from /u/shelton/new/src/zsh-2001-04-24/Src/Modules/termcap.c:51:
/usr/include/sys/ioctl.h:23: warning: `ECHO' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:169: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:30: warning: `NL0' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:116: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:31: warning: `NL1' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:117: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:35: warning: `TAB0' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:124: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:36: warning: `TAB1' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:125: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:37: warning: `TAB2' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:126: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:38: warning: `XTABS' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:127: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:40: warning: `CR0' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:119: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:41: warning: `CR1' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:120: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:42: warning: `CR2' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:121: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:43: warning: `CR3' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:122: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:45: warning: `FF0' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:136: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:46: warning: `FF1' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:137: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:48: warning: `BS0' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:130: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:49: warning: `BS1' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:131: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:57: warning: `TOSTOP' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:174: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:58: warning: `FLUSHO' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:189: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:64: warning: `PENDIN' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:190: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:66: warning: `NOFLSH' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:173: warning: this is the location of the previous definition
In file included from /u/shelton/new/src/zsh-2001-04-24/Src/Modules/termcap.c:51:
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/curses.h:54: `DO' redeclared as different kind of symbol
/u/shelton/new/src/zsh-2001-04-24/Src/zsh.h:211: previous declaration of `DO'
/u/shelton/new/src/zsh-2001-04-24/Src/Modules/termcap.c: In function `bin_echotc':
/u/shelton/new/src/zsh-2001-04-24/Src/Modules/termcap.c:100: warning: assignment makes pointer from integer without a cast
make[3]: *** [termcap.o] Error 1
make[3]: Leaving directory `/tmp_mnt/u/shelton/new/build/SunOS-4.1/zsh-2001-04-24/Src/Modules'
make[2]: *** [modobjs] Error 1
make[2]: Leaving directory `/tmp_mnt/u/shelton/new/build/SunOS-4.1/zsh-2001-04-24/Src'
make[1]: *** [modobjs] Error 2
make[1]: Leaving directory `/tmp_mnt/u/shelton/new/build/SunOS-4.1/zsh-2001-04-24/Src'
make: *** [all] Error 1


The configuration is:

# /u/shelton/new/src/zsh-2001-04-24/configure  --prefix=/u/shelton/new/SunOS-4.1/zsh-2001-04-24 --datadir=/u/shelton/new/share --enable-zsh-mem --enable-etcdir=/u/shelton/new/etc --disable-dynamic --disable-nls --disable-locale

and uname -a reports:

SunOS peach 4.1.4 1 sun4m unknown

HTH,
  vin


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: Make Failure on SunOS-4.1
  2001-04-24 19:43 Make Failure on SunOS-4.1 Vin Shelton
@ 2001-04-25  4:13 ` Bart Schaefer
  2001-04-25  9:55   ` Peter Stephenson
  2001-04-25 14:29   ` Vin Shelton
  0 siblings, 2 replies; 22+ messages in thread
From: Bart Schaefer @ 2001-04-25  4:13 UTC (permalink / raw)
  To: Vin Shelton, zsh-workers

On Apr 24,  3:43pm, Vin Shelton wrote:
}
} Using the latest CVS sources, I can build fine against SunOS-5.5, but
} building under 4.1 gives me the following errors:

First, just to cover all the bases:  Did you remove config.cache and re-run
Util/preconfig before running configure?

} gcc -c -I.  -DHAVE_CONFIG_H -Wall -Wno-implicit -Wmissing-prototypes -O2  -o termcap.o /u/shelton/new/src/zsh-2001-04-24/Src/Modules/termcap.c
} In file included from /usr/include/sgtty.h:6,
}                  from /u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/curses.h:20,
}                  from /u/shelton/new/src/zsh-2001-04-24/Src/Modules/termcap.c:51:
} /usr/include/sys/ioctl.h:23: warning: `ECHO' redefined
} /u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:169: warning: this is the location of the previous definition

If you did the configure cleanly and still are getting those errors, try
replacing

# if defined(HAVE_CURSES_H) && defined(HAVE_TERM_H)
#  ifdef HAVE_TERMIO_H
#   include <termio.h>
#  endif

with

# if defined(HAVE_CURSES_H) && defined(HAVE_TERM_H)
#  ifdef VINTR
#   undef VINTR
#  endif
#  ifdef offsetof
#   undef offsetof
#  endif

in Src/Modules/termcap.c.  However, this part worries me:

} /u/shelton/new/src/zsh-2001-04-24/Src/Modules/termcap.c: In function `bin_echotc':
} /u/shelton/new/src/zsh-2001-04-24/Src/Modules/termcap.c:100: warning: assignment makes pointer from integer without a cast

That's tgetstr(), which should have been declared somewhere.  I suspect
perhaps that the `defined(HAVE_CURSES_H) && defined(HAVE_TERM_H)' test
is inadequate.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: Make Failure on SunOS-4.1
  2001-04-25  4:13 ` Bart Schaefer
@ 2001-04-25  9:55   ` Peter Stephenson
  2001-04-25 14:41     ` Bart Schaefer
  2001-04-25 14:29   ` Vin Shelton
  1 sibling, 1 reply; 22+ messages in thread
From: Peter Stephenson @ 2001-04-25  9:55 UTC (permalink / raw)
  To: Zsh hackers list

I don't want to produce a `final' pre-release until the termcap problems
have gone.  Is there something else to back out?  Although this was never
perfect I don't think there were any compilation problems until recently.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Unit 300, Science Park, Milton Road,
Cambridge, CB4 0XL, UK                          Tel: +44 (0)1223 392070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: Make Failure on SunOS-4.1
  2001-04-25  4:13 ` Bart Schaefer
  2001-04-25  9:55   ` Peter Stephenson
@ 2001-04-25 14:29   ` Vin Shelton
  2001-04-25 14:58     ` Bart Schaefer
  1 sibling, 1 reply; 22+ messages in thread
From: Vin Shelton @ 2001-04-25 14:29 UTC (permalink / raw)
  To: Bart Schaefer; +Cc: zsh-workers

"Bart Schaefer" <schaefer@candle.brasslantern.com> writes:
> First, just to cover all the bases:  Did you remove config.cache and re-run
> Util/preconfig before running configure?
> 

Of course.  I build in separate objdirs for SunOS-4.1 and SunOS-5.5.
After receiving your message, I created a new directory and started
from scratch just to be sure, and the problem remains.

> If you did the configure cleanly and still are getting those errors, try
> replacing
> 
> # if defined(HAVE_CURSES_H) && defined(HAVE_TERM_H)
> #  ifdef HAVE_TERMIO_H
> #   include <termio.h>
> #  endif
> 
> with
> 
> # if defined(HAVE_CURSES_H) && defined(HAVE_TERM_H)
> #  ifdef VINTR
> #   undef VINTR
> #  endif
> #  ifdef offsetof
> #   undef offsetof
> #  endif
> 
> in Src/Modules/termcap.c.  However, this part worries me:
> 
> } /u/shelton/new/src/zsh-2001-04-24/Src/Modules/termcap.c: In function `bin_echotc':
> } /u/shelton/new/src/zsh-2001-04-24/Src/Modules/termcap.c:100: warning: assignment makes pointer from integer without a cast
> 
> That's tgetstr(), which should have been declared somewhere.  I suspect
> perhaps that the `defined(HAVE_CURSES_H) && defined(HAVE_TERM_H)' test
> is inadequate.

You worry was well placed.  After making the proposed change, here's
what happened:

make[3]: Leaving directory `/tmp_mnt/u/shelton/new/build/SunOS-4.1/zsh-2001-04-24-new/Src/Builtins'
make[3]: Entering directory `/tmp_mnt/u/shelton/new/build/SunOS-4.1/zsh-2001-04-24-new/Src/Modules'
echo '' parameter.o | sed 's" " Modules/"g' >> ../../Src/stamp-modobjs.tmp
gcc -c -I.  -DHAVE_CONFIG_H -Wall -Wno-implicit -Wmissing-prototypes -O2  -o termcap.o ../../../../../src/zsh-2001-04-24/Src/Modules/termcap.c
In file included from /usr/include/sgtty.h:6,
                 from /u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/curses.h:20,
                 from ../../../../../src/zsh-2001-04-24/Src/Modules/termcap.c:54:
/usr/include/sys/ioctl.h:23: warning: `ECHO' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:169: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:30: warning: `NL0' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:116: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:31: warning: `NL1' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:117: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:35: warning: `TAB0' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:124: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:36: warning: `TAB1' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:125: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:37: warning: `TAB2' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:126: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:38: warning: `XTABS' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:127: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:40: warning: `CR0' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:119: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:41: warning: `CR1' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:120: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:42: warning: `CR2' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:121: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:43: warning: `CR3' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:122: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:45: warning: `FF0' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:136: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:46: warning: `FF1' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:137: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:48: warning: `BS0' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:130: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:49: warning: `BS1' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:131: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:57: warning: `TOSTOP' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:174: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:58: warning: `FLUSHO' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:189: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:64: warning: `PENDIN' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:190: warning: this is the location of the previous definition
/usr/include/sys/ioctl.h:66: warning: `NOFLSH' redefined
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/termios.h:173: warning: this is the location of the previous definition
In file included from ../../../../../src/zsh-2001-04-24/Src/Modules/termcap.c:54:
/u/shelton/new/SunOS-4.1/gcc-2.95.3-test5/lib/gcc-lib/sparc-sun-sunos4.1.4/2.95.3/include/curses.h:54: `DO' redeclared as different kind of symbol
../../Src/../../../../src/zsh-2001-04-24/Src/zsh.h:211: previous declaration of `DO'
../../../../../src/zsh-2001-04-24/Src/Modules/termcap.c: In function `bin_echotc':
../../../../../src/zsh-2001-04-24/Src/Modules/termcap.c:103: warning: assignment makes pointer from integer without a cast
make[3]: *** [termcap.o] Error 1
make[3]: Leaving directory `/tmp_mnt/u/shelton/new/build/SunOS-4.1/zsh-2001-04-24-new/Src/Modules'
make[2]: *** [modobjs] Error 1
make[2]: Leaving directory `/tmp_mnt/u/shelton/new/build/SunOS-4.1/zsh-2001-04-24-new/Src'
make[1]: *** [modobjs] Error 2
make[1]: Leaving directory `/tmp_mnt/u/shelton/new/build/SunOS-4.1/zsh-2001-04-24-new/Src'
make: *** [all] Error 1

I'm sorry I don't have time at work right now to investigate further,
but if there are any further experiments people need to have run, I
will try to oblige.

HTH,
  vin


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: Make Failure on SunOS-4.1
  2001-04-25  9:55   ` Peter Stephenson
@ 2001-04-25 14:41     ` Bart Schaefer
  2001-04-25 14:57       ` Clint Adams
  0 siblings, 1 reply; 22+ messages in thread
From: Bart Schaefer @ 2001-04-25 14:41 UTC (permalink / raw)
  To: Peter Stephenson, Zsh hackers list

On Apr 25, 10:55am, Peter Stephenson wrote:
} Subject: Re: Make Failure on SunOS-4.1
}
} I don't want to produce a `final' pre-release until the termcap problems
} have gone.  Is there something else to back out?

We could back out the `termcap' parameter entirely, and we could back out
the ability to use ${(k)terminfo} -- those were the changes that started
requiring the ncurses header files to be included even on systems that
have the old termcap as well.

Or we could change the termcap-search-order in configure.in to always try
to find ncurses first, and skip defining HAVE_TERMCAP_H when we find the
ncurses headers.  (My understanding is that in the distant past of zsh,
there were some who objected to linking the shell against curses when it
would be sufficient to link against termcap, because curses is bloated.)

Or we could add another --enable flag, which switches between the two
states described above (in which case it should probably disable the
terminfo parameter entirely rather than just crippling it).

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: Make Failure on SunOS-4.1
  2001-04-25 14:41     ` Bart Schaefer
@ 2001-04-25 14:57       ` Clint Adams
  0 siblings, 0 replies; 22+ messages in thread
From: Clint Adams @ 2001-04-25 14:57 UTC (permalink / raw)
  To: Bart Schaefer; +Cc: Peter Stephenson, Zsh hackers list

> We could back out the `termcap' parameter entirely, and we could back out
> the ability to use ${(k)terminfo} -- those were the changes that started
> requiring the ncurses header files to be included even on systems that
> have the old termcap as well.

Or, since I think that the only dependency on term.h is for the
{bool,num,str}codes, those could be made static under whatever
circumstances would call for that.
 
> Or we could change the termcap-search-order in configure.in to always try
> to find ncurses first, and skip defining HAVE_TERMCAP_H when we find the
> ncurses headers.  (My understanding is that in the distant past of zsh,
> there were some who objected to linking the shell against curses when it
> would be sufficient to link against termcap, because curses is bloated.)
>
> Or we could add another --enable flag, which switches between the two
> states described above (in which case it should probably disable the
> terminfo parameter entirely rather than just crippling it).

All of these seem reasonable to me.


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: Make Failure on SunOS-4.1
  2001-04-25 14:29   ` Vin Shelton
@ 2001-04-25 14:58     ` Bart Schaefer
  2001-04-25 18:03       ` Vin Shelton
  0 siblings, 1 reply; 22+ messages in thread
From: Bart Schaefer @ 2001-04-25 14:58 UTC (permalink / raw)
  To: Vin Shelton; +Cc: zsh-workers

On Apr 25, 10:29am, Vin Shelton wrote:
} Subject: Re: Make Failure on SunOS-4.1
}
} > That's tgetstr(), which should have been declared somewhere.  I suspect
} > perhaps that the `defined(HAVE_CURSES_H) && defined(HAVE_TERM_H)' test
} > is inadequate.
} 
} You worry was well placed.

I'm also attention-deficient, apparently, as I see that (in your original
complaint) the error is coming from line 51 of termcap.c, which would mean
that you have curses.h but neither termcap.h nor term.h.

Can you please check your config.h for HAVE_TERM.*_H and HAVE_CURSES_H and
see which of them are defined?

Also, if you have a build tree from an older version of zsh where this all
worked, can you check the config.h there, too?

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: Make Failure on SunOS-4.1
  2001-04-25 14:58     ` Bart Schaefer
@ 2001-04-25 18:03       ` Vin Shelton
  2001-04-26  4:27         ` Bart Schaefer
  0 siblings, 1 reply; 22+ messages in thread
From: Vin Shelton @ 2001-04-25 18:03 UTC (permalink / raw)
  To: Bart Schaefer; +Cc: zsh-workers

[-- Attachment #1: Type: text/plain, Size: 990 bytes --]

"Bart Schaefer" <schaefer@candle.brasslantern.com> writes:
> On Apr 25, 10:29am, Vin Shelton wrote:
> } Subject: Re: Make Failure on SunOS-4.1
> }
> } > That's tgetstr(), which should have been declared somewhere.  I suspect
> } > perhaps that the `defined(HAVE_CURSES_H) && defined(HAVE_TERM_H)' test
> } > is inadequate.
> } 
> } You worry was well placed.
> 
> I'm also attention-deficient, apparently, as I see that (in your original
> complaint) the error is coming from line 51 of termcap.c, which would mean
> that you have curses.h but neither termcap.h nor term.h.
> 
> Can you please check your config.h for HAVE_TERM.*_H and HAVE_CURSES_H and
> see which of them are defined?
> 
> Also, if you have a build tree from an older version of zsh where this all
> worked, can you check the config.h there, too?

In the non-working 4/24 build, HAVE_CURSES_H, HAVE_TERMIO_H, and
HAVE_TERMIOS_H are defined and HAVE_TERM_H and HAVE_TERMCAP_H are not
defined.  See the attached config.h:


[-- Attachment #2: SunOS-4.1 config.h generated from Apr-24 CVS --]
[-- Type: Broken-4-24-config.h, Size: 21865 bytes --]

/* config.h.  Generated automatically by configure.  */
/* config.h.in.  Generated automatically from configure.in by autoheader.  */

/***** begin user configuration section *****/

/* Define this to be the location of your password file */
#define PASSWD_FILE "/etc/passwd"

/* Define this to be the name of your NIS/YP password *
 * map (if applicable)                                */
#define PASSWD_MAP "passwd.byname"

/* Define to 1 if you want user names to be cached */
#define CACHE_USERNAMES 1

/* Define to 1 if system supports job control */
#define JOB_CONTROL 1

/* Define this if you use "suspended" instead of "stopped" */
#define USE_SUSPENDED 1
 
/* The default history buffer size in lines */
#define DEFAULT_HISTSIZE 30

/* The default editor for the fc builtin */
#define DEFAULT_FCEDIT "vi"

/* The default prefix for temporary files */
#define DEFAULT_TMPPREFIX "/tmp/zsh"


/***** end of user configuration section            *****/
/***** shouldn't have to change anything below here *****/

/* Define if using alloca.c.  */
/* #undef C_ALLOCA */

/* Define to empty if the keyword does not work.  */
/* #undef const */

/* Define to one of _getb67, GETB67, getb67 for Cray-2 and Cray-YMP systems.
   This function is required for alloca.c support on those systems.  */
/* #undef CRAY_STACKSEG_END */

/* Define if the `getpgrp' function takes no argument.  */
/* #undef GETPGRP_VOID */

/* Define to `int' if <sys/types.h> doesn't define.  */
/* #undef gid_t */

/* Define if you have alloca, as a function or macro.  */
#define HAVE_ALLOCA 1

/* Define if you have <alloca.h> and it should be used (not on Ultrix).  */
#define HAVE_ALLOCA_H 1

/* Define if you have a working `mmap' system call.  */
#define HAVE_MMAP 1

/* Define if you have the strcoll function and it is properly defined.  */
#define HAVE_STRCOLL 1

/* Define if you have <sys/wait.h> that is POSIX.1 compatible.  */
#define HAVE_SYS_WAIT_H 1

/* Define to `int' if <sys/types.h> doesn't define.  */
/* #undef mode_t */

/* Define to `long' if <sys/types.h> doesn't define.  */
/* #undef off_t */

/* Define to `int' if <sys/types.h> doesn't define.  */
/* #undef pid_t */

/* Define as the return type of signal handlers (int or void).  */
#define RETSIGTYPE void

/* Define to `unsigned' if <sys/types.h> doesn't define.  */
/* #undef size_t */

/* If using the C implementation of alloca, define if you know the
   direction of stack growth for your system; otherwise it will be
   automatically deduced at run-time.
 STACK_DIRECTION > 0 => grows toward higher addresses
 STACK_DIRECTION < 0 => grows toward lower addresses
 STACK_DIRECTION = 0 => direction of growth unknown
 */
/* #undef STACK_DIRECTION */

/* Define if the `S_IS*' macros in <sys/stat.h> do not work properly.  */
/* #undef STAT_MACROS_BROKEN */

/* Define if you have the ANSI C header files.  */
/* #undef STDC_HEADERS */

/* Define if you can safely include both <sys/time.h> and <time.h>.  */
#define TIME_WITH_SYS_TIME 1

/* Define to `int' if <sys/types.h> doesn't define.  */
/* #undef uid_t */

/* The global file to source absolutely first whenever zsh is run; *
 * if undefined, don't source anything                             */
#define GLOBAL_ZSHENV "/u/shelton/new/etc/zshenv"

/* The global file to source whenever zsh is run; *
 * if undefined, don't source anything            */
#define GLOBAL_ZSHRC "/u/shelton/new/etc/zshrc"

/* The global file to source whenever zsh is run as a login shell; *
 * if undefined, don't source anything                             */
#define GLOBAL_ZLOGIN "/u/shelton/new/etc/zlogin"

/* The global file to source whenever zsh is run as a login shell, *
 * before zshrc is read; if undefined, don't source anything       */
#define GLOBAL_ZPROFILE "/u/shelton/new/etc/zprofile"

/* The global file to source whenever zsh was run as a login shell.  *
 * This is sourced right before exiting.  If undefined, don't source *
 * anything                                                          */
#define GLOBAL_ZLOGOUT "/u/shelton/new/etc/zlogout"

/* Define to 1 if compiler could initialise a union */
#define HAVE_UNION_INIT 1

/* Define to 1 if compiler incorrectly cast signed to unsigned */
/* #undef BROKEN_SIGNED_TO_UNSIGNED_CASTING */

/* Define to 1 if compiler supports variable-length arrays */
/* #undef HAVE_VARIABLE_LENGTH_ARRAYS */

/* Define if your system defines TIOCGWINSZ in sys/ioctl.h.  */
/* #undef GWINSZ_IN_SYS_IOCTL */

/* Define to 1 if you have NIS */
#define HAVE_NIS 1

/* Define to 1 if you have NISPLUS */
/* #undef HAVE_NIS_PLUS */

/* Define to 1 if you have RFS superroot directory. */
/* #undef HAVE_SUPERROOT */

/* Define to 1 if you need to use the native getcwd */
/* #undef USE_GETCWD */

/* Define to the path of the /dev/fd filesystem */
/* #undef PATH_DEV_FD */

/* Define if sys/time.h and sys/select.h cannot be both included */
/* #undef TIME_H_SELECT_H_CONFLICTS */

/* Define to be the machine type (microprocessor class or machine model) */
#define MACHTYPE "sparc"

/* Define to be the name of the operating system */
#define OSTYPE "sunos4.1.4"

/* Define to 1 if ANSI function prototypes are usable.  */
#define PROTOTYPES 1

/* Define to be location of utmp file. */
#define PATH_UTMP_FILE "/etc/utmp"

/* Define to be location of utmpx file. */
/* #undef PATH_UTMPX_FILE */

/* Define to be location of wtmp file. */
#define PATH_WTMP_FILE "/var/adm/wtmp"

/* Define to be location of wtmpx file. */
/* #undef PATH_WTMPX_FILE */

/* Define to 1 if struct utmp is defined by a system header */
#define HAVE_STRUCT_UTMP 1

/* Define to 1 if struct utmpx is defined by a system header */
/* #undef HAVE_STRUCT_UTMPX */

/* Define if your system's struct utmp has a member named ut_host.  */
#define HAVE_STRUCT_UTMP_UT_HOST 1

/* Define if your system's struct utmpx has a member named ut_host.  */
/* #undef HAVE_STRUCT_UTMPX_UT_HOST */

/* Define if your system's struct utmpx has a member named ut_xtime.  */
/* #undef HAVE_STRUCT_UTMPX_UT_XTIME */

/* Define if your system's struct utmpx has a member named ut_tv.  */
/* #undef HAVE_STRUCT_UTMPX_UT_TV */

/* Define if your system's struct dirent has a member named d_ino.  */
#define HAVE_STRUCT_DIRENT_D_INO 1

/* Define if your system's struct dirent has a member named d_stat.  */
/* #undef HAVE_STRUCT_DIRENT_D_STAT */

/* Define if your system's struct direct has a member named d_ino.  */
/* #undef HAVE_STRUCT_DIRECT_D_INO */

/* Define if your system's struct direct has a member named d_stat.  */
/* #undef HAVE_STRUCT_DIRECT_D_STAT */

/* Define if your system's struct sockaddr_in6 has a member named sin6_scope_id.  */
/* #undef HAVE_STRUCT_SOCKADDR_IN6_SIN6_SCOPE_ID */

/* Define to be a string corresponding the vendor of the machine */
#define VENDOR "sun"

/* Define to limit job table size */
#define MAXJOB 50
/* #undef NEED_LINUX_TASKS_H */

/* Define if your system defines `struct winsize' in sys/ptem.h.  */
/* #undef WINSIZE_IN_PTEM */

/* Define to 1 if you want to debug zsh */
/* #undef DEBUG */

/* Define to 1 if you want to use zsh's own memory allocation routines */
#define ZSH_MEM 1

/* Define to 1 if you want to debug zsh memory allocation routines */
/* #undef ZSH_MEM_DEBUG */

/* Define to 1 if you want to turn on warnings of memory allocation errors */
/* #undef ZSH_MEM_WARNING */

/* Define to 1 if you want to turn on memory checking for free() */
/* #undef ZSH_SECURE_FREE */

/* Define to 1 if you want to get debugging information on internal *
 * hash tables.  This turns on the `hashinfo' builtin.              */
/* #undef ZSH_HASH_DEBUG */

/* Undefine this if you don't want to get a restricted shell *
 * when zsh is exec'd with basename that starts with r.      *
 * By default this is defined.                               */
#define RESTRICTED_R 1

/* Define for Maildir support */
/* #undef MAILDIR_SUPPORT */

/* Define for function depth limits */
/* #undef MAX_FUNCTION_DEPTH */

/* Define if you want locale features.  By default this is defined. */
/* #undef CONFIG_LOCALE */

/* Define to 1 if your termcap library has the ospeed variable */
#define HAVE_OSPEED 1
/* Define to 1 if you have ospeed, but it is not defined in termcap.h */
#define MUST_DEFINE_OSPEED 1

/* Define to 1 if tgetent() accepts NULL as a buffer */
/* #undef TGETENT_ACCEPTS_NULL */

/* Define to 1 if you use POSIX style signal handling */
#define POSIX_SIGNALS 1

/* Define to 1 if you use BSD style signal handling (and can block signals) */
/* #undef BSD_SIGNALS */

/* Define to 1 if you use SYS style signal handling (and can block signals) */
/* #undef SYSV_SIGNALS */

/* Define to 1 if you have no signal blocking at all (bummer) */
/* #undef NO_SIGNAL_BLOCKING */

/* Define to `unsigned int' if <sys/types.h> or <signal.h> doesn't define */
/* #undef sigset_t */

/* Define to 1 if struct timezone is defined by a system header */
#define HAVE_STRUCT_TIMEZONE 1

/* Define to 1 if there is a prototype defined for brk() on your system */
/* #undef HAVE_BRK_PROTO */

/* Define to 1 if there is a prototype defined for sbrk() on your system */
/* #undef HAVE_SBRK_PROTO */

/* Define to 1 if there is a prototype defined for ioctl() on your system */
/* #undef HAVE_IOCTL_PROTO */

/* Define to 1 if there is a prototype defined for mknod() on your system */
/* #undef HAVE_MKNOD_PROTO */

/* Define to 1 if select() is defined in <sys/socket.h>, ie BeOS R4.51*/
/* #undef SELECT_IN_SYS_SOCKET_H */

/* Define to 1 if system has working FIFO's */
#define HAVE_FIFOS 1

/* Define to 1 if struct rlimit uses quad_t */
/* #undef RLIM_T_IS_QUAD_T */

/* Define to 1 if struct rlimit uses long long */
/* #undef RLIM_T_IS_LONG_LONG */

/* Define to 1 if rlimit uses unsigned */
/* #undef RLIM_T_IS_UNSIGNED */

/* Define to the type used in struct rlimit */
#define rlim_t long

/* Define to 1 if /bin/sh does not interpret \ escape sequences */
#define SH_USE_BSD_ECHO 1

/* Define to 1 if system has working link() */
#define HAVE_LINK 1

/* Define to 1 if kill(pid, 0) doesn't return ESRCH, ie BeOS R4.51 */
/* #undef BROKEN_KILL_ESRCH */

/* Define to 1 if sigsuspend() is broken, ie BeOS R4.51 */
/* #undef BROKEN_POSIX_SIGSUSPEND */

/* Define to 1 if getpwnam() is faked, ie BeOS R4.51 */
/* #undef GETPWNAM_FAKED */

/* Define to 1 if tcsetpgrp() doesn't work, ie BeOS R4.51 */
/* #undef BROKEN_TCSETPGRP */

/* Define to 1 if an underscore has to be prepended to dlsym() argument */
/* #undef DLSYM_NEEDS_UNDERSCORE */

/* Define to 1 if multiple modules defining the same symbol are OK */
/* #undef DYNAMIC_NAME_CLASH_OK */

/* The exension used for dynamically loaded modules */
#define DL_EXT ""

/* Define to 1 if you want to use dynamically loaded modules */
/* #undef DYNAMIC */

/* Define to 1 if you want to use dynamically loaded modules on AIX */
/* #undef AIXDYNAMIC */

/* Define to 1 if you want to use dynamically loaded modules on HPUX 10 */
/* #undef HPUXDYNAMIC */

/* Define to `unsigned long' if <sys/types.h> doesn't define. */
/* #undef ino_t */

/*
 * Definitions used when a long is less than eight byte, to try to
 * provide some support for eight byte operations.
 *
 * Note that ZSH_64_BIT_TYPE, OFF_T_IS_64_BIT, INO_T_IS_64_BIT do *not* get
 * defined if long is already 64 bits, since in that case no special handling
 * is required.
 */
/* Define to 1 if long is 64 bits */
/* #undef LONG_IS_64_BIT */

/* Define to a 64 bit integer type if there is one, but long is shorter */
#define ZSH_64_BIT_TYPE long long

/* Define to an unsigned variant of ZSH_64_BIT_TYPE if that is defined */
#define ZSH_64_BIT_UTYPE unsigned long long

/* Define to 1 if off_t is 64 bit (for large file support) */
/* #undef OFF_T_IS_64_BIT */

/* Define to 1 if ino_t is 64 bit (for large file support) */
/* #undef INO_T_IS_64_BIT */

/* Define to 1 if h_errno is not defined by the system */
/* #undef USE_LOCAL_H_ERRNO */

/* Define if you have the termcap boolcodes symbol.  */
/* #undef HAVE_BOOLCODES */

/* Define if you have the termcap numcodes symbol.  */
/* #undef HAVE_NUMCODES */

/* Define if you have the termcap strcodes symbol.  */
/* #undef HAVE_STRCODES */

/* Define if you have the terminfo boolnames symbol.  */
/* #undef HAVE_BOOLNAMES */

/* Define if you have the terminfo numnames symbol.  */
/* #undef HAVE_NUMNAMES */

/* Define if you have the terminfo strnames symbol.  */
/* #undef HAVE_STRNAMES */

/* Define if you have the _mktemp function.  */
/* #undef HAVE__MKTEMP */

/* Define if you have the brk function.  */
#define HAVE_BRK 1

/* Define if you have the cap_get_proc function.  */
/* #undef HAVE_CAP_GET_PROC */

/* Define if you have the difftime function.  */
/* #undef HAVE_DIFFTIME */

/* Define if you have the dlclose function.  */
/* #undef HAVE_DLCLOSE */

/* Define if you have the dlerror function.  */
/* #undef HAVE_DLERROR */

/* Define if you have the dlopen function.  */
/* #undef HAVE_DLOPEN */

/* Define if you have the dlsym function.  */
/* #undef HAVE_DLSYM */

/* Define if you have the faccessx function.  */
/* #undef HAVE_FACCESSX */

/* Define if you have the fchdir function.  */
#define HAVE_FCHDIR 1

/* Define if you have the fseeko function.  */
/* #undef HAVE_FSEEKO */

/* Define if you have the ftello function.  */
/* #undef HAVE_FTELLO */

/* Define if you have the ftruncate function.  */
#define HAVE_FTRUNCATE 1

/* Define if you have the getenv function.  */
#define HAVE_GETENV 1

/* Define if you have the getgrgid function.  */
#define HAVE_GETGRGID 1

/* Define if you have the getgrnam function.  */
#define HAVE_GETGRNAM 1

/* Define if you have the gethostbyname2 function.  */
/* #undef HAVE_GETHOSTBYNAME2 */

/* Define if you have the gethostname function.  */
#define HAVE_GETHOSTNAME 1

/* Define if you have the getipnodebyname function.  */
/* #undef HAVE_GETIPNODEBYNAME */

/* Define if you have the getlogin function.  */
#define HAVE_GETLOGIN 1

/* Define if you have the getpagesize function.  */
#define HAVE_GETPAGESIZE 1

/* Define if you have the getpwent function.  */
#define HAVE_GETPWENT 1

/* Define if you have the getpwnam function.  */
#define HAVE_GETPWNAM 1

/* Define if you have the getpwuid function.  */
#define HAVE_GETPWUID 1

/* Define if you have the getrlimit function.  */
#define HAVE_GETRLIMIT 1

/* Define if you have the gettimeofday function.  */
#define HAVE_GETTIMEOFDAY 1

/* Define if you have the inet_aton function.  */
/* #undef HAVE_INET_ATON */

/* Define if you have the inet_ntop function.  */
/* #undef HAVE_INET_NTOP */

/* Define if you have the inet_pton function.  */
/* #undef HAVE_INET_PTON */

/* Define if you have the initgroups function.  */
#define HAVE_INITGROUPS 1

/* Define if you have the killpg function.  */
#define HAVE_KILLPG 1

/* Define if you have the lchown function.  */
/* #undef HAVE_LCHOWN */

/* Define if you have the load function.  */
/* #undef HAVE_LOAD */

/* Define if you have the loadbind function.  */
/* #undef HAVE_LOADBIND */

/* Define if you have the loadquery function.  */
/* #undef HAVE_LOADQUERY */

/* Define if you have the lstat function.  */
#define HAVE_LSTAT 1

/* Define if you have the memcpy function.  */
#define HAVE_MEMCPY 1

/* Define if you have the memmove function.  */
/* #undef HAVE_MEMMOVE */

/* Define if you have the mkfifo function.  */
#define HAVE_MKFIFO 1

/* Define if you have the msync function.  */
#define HAVE_MSYNC 1

/* Define if you have the munmap function.  */
#define HAVE_MUNMAP 1

/* Define if you have the nice function.  */
#define HAVE_NICE 1

/* Define if you have the nis_list function.  */
/* #undef HAVE_NIS_LIST */

/* Define if you have the pathconf function.  */
#define HAVE_PATHCONF 1

/* Define if you have the poll function.  */
#define HAVE_POLL 1

/* Define if you have the putenv function.  */
#define HAVE_PUTENV 1

/* Define if you have the readlink function.  */
#define HAVE_READLINK 1

/* Define if you have the sbrk function.  */
#define HAVE_SBRK 1

/* Define if you have the select function.  */
#define HAVE_SELECT 1

/* Define if you have the seteuid function.  */
#define HAVE_SETEUID 1

/* Define if you have the setlocale function.  */
#define HAVE_SETLOCALE 1

/* Define if you have the setpgid function.  */
#define HAVE_SETPGID 1

/* Define if you have the setpgrp function.  */
#define HAVE_SETPGRP 1

/* Define if you have the setresuid function.  */
/* #undef HAVE_SETRESUID */

/* Define if you have the setreuid function.  */
#define HAVE_SETREUID 1

/* Define if you have the setsid function.  */
#define HAVE_SETSID 1

/* Define if you have the setuid function.  */
#define HAVE_SETUID 1

/* Define if you have the setupterm function.  */
/* #undef HAVE_SETUPTERM */

/* Define if you have the shl_findsym function.  */
/* #undef HAVE_SHL_FINDSYM */

/* Define if you have the shl_load function.  */
/* #undef HAVE_SHL_LOAD */

/* Define if you have the shl_unload function.  */
/* #undef HAVE_SHL_UNLOAD */

/* Define if you have the sigaction function.  */
#define HAVE_SIGACTION 1

/* Define if you have the sigblock function.  */
#define HAVE_SIGBLOCK 1

/* Define if you have the sighold function.  */
/* #undef HAVE_SIGHOLD */

/* Define if you have the signgam function.  */
#define HAVE_SIGNGAM 1

/* Define if you have the sigprocmask function.  */
#define HAVE_SIGPROCMASK 1

/* Define if you have the sigrelse function.  */
/* #undef HAVE_SIGRELSE */

/* Define if you have the sigsetmask function.  */
#define HAVE_SIGSETMASK 1

/* Define if you have the strerror function.  */
/* #undef HAVE_STRERROR */

/* Define if you have the strftime function.  */
#define HAVE_STRFTIME 1

/* Define if you have the strstr function.  */
#define HAVE_STRSTR 1

/* Define if you have the sysconf function.  */
#define HAVE_SYSCONF 1

/* Define if you have the tcgetattr function.  */
#define HAVE_TCGETATTR 1

/* Define if you have the tcsetpgrp function.  */
#define HAVE_TCSETPGRP 1

/* Define if you have the tgetent function.  */
#define HAVE_TGETENT 1

/* Define if you have the tigetflag function.  */
/* #undef HAVE_TIGETFLAG */

/* Define if you have the tigetnum function.  */
/* #undef HAVE_TIGETNUM */

/* Define if you have the tigetstr function.  */
/* #undef HAVE_TIGETSTR */

/* Define if you have the uname function.  */
#define HAVE_UNAME 1

/* Define if you have the unload function.  */
/* #undef HAVE_UNLOAD */

/* Define if you have the wait3 function.  */
#define HAVE_WAIT3 1

/* Define if you have the waitpid function.  */
#define HAVE_WAITPID 1

/* Define if you have the <curses.h> header file.  */
#define HAVE_CURSES_H 1

/* Define if you have the <dirent.h> header file.  */
#define HAVE_DIRENT_H 1

/* Define if you have the <dl.h> header file.  */
/* #undef HAVE_DL_H */

/* Define if you have the <dlfcn.h> header file.  */
/* #undef HAVE_DLFCN_H */

/* Define if you have the <errno.h> header file.  */
#define HAVE_ERRNO_H 1

/* Define if you have the <fcntl.h> header file.  */
#define HAVE_FCNTL_H 1

/* Define if you have the <grp.h> header file.  */
#define HAVE_GRP_H 1

/* Define if you have the <libc.h> header file.  */
/* #undef HAVE_LIBC_H */

/* Define if you have the <limits.h> header file.  */
#define HAVE_LIMITS_H 1

/* Define if you have the <linux/tasks.h> header file.  */
/* #undef HAVE_LINUX_TASKS_H */

/* Define if you have the <locale.h> header file.  */
#define HAVE_LOCALE_H 1

/* Define if you have the <memory.h> header file.  */
#define HAVE_MEMORY_H 1

/* Define if you have the <ndir.h> header file.  */
/* #undef HAVE_NDIR_H */

/* Define if you have the <netinet/in_systm.h> header file.  */
#define HAVE_NETINET_IN_SYSTM_H 1

/* Define if you have the <poll.h> header file.  */
#define HAVE_POLL_H 1

/* Define if you have the <pwd.h> header file.  */
#define HAVE_PWD_H 1

/* Define if you have the <stdlib.h> header file.  */
#define HAVE_STDLIB_H 1

/* Define if you have the <string.h> header file.  */
#define HAVE_STRING_H 1

/* Define if you have the <sys/capability.h> header file.  */
/* #undef HAVE_SYS_CAPABILITY_H */

/* Define if you have the <sys/dir.h> header file.  */
/* #undef HAVE_SYS_DIR_H */

/* Define if you have the <sys/filio.h> header file.  */
#define HAVE_SYS_FILIO_H 1

/* Define if you have the <sys/mman.h> header file.  */
#define HAVE_SYS_MMAN_H 1

/* Define if you have the <sys/ndir.h> header file.  */
/* #undef HAVE_SYS_NDIR_H */

/* Define if you have the <sys/param.h> header file.  */
#define HAVE_SYS_PARAM_H 1

/* Define if you have the <sys/resource.h> header file.  */
#define HAVE_SYS_RESOURCE_H 1

/* Define if you have the <sys/select.h> header file.  */
/* #undef HAVE_SYS_SELECT_H */

/* Define if you have the <sys/time.h> header file.  */
#define HAVE_SYS_TIME_H 1

/* Define if you have the <sys/times.h> header file.  */
#define HAVE_SYS_TIMES_H 1

/* Define if you have the <sys/types.h> header file.  */
#define HAVE_SYS_TYPES_H 1

/* Define if you have the <sys/utsname.h> header file.  */
#define HAVE_SYS_UTSNAME_H 1

/* Define if you have the <term.h> header file.  */
/* #undef HAVE_TERM_H */

/* Define if you have the <termcap.h> header file.  */
/* #undef HAVE_TERMCAP_H */

/* Define if you have the <termio.h> header file.  */
#define HAVE_TERMIO_H 1

/* Define if you have the <termios.h> header file.  */
#define HAVE_TERMIOS_H 1

/* Define if you have the <unistd.h> header file.  */
#define HAVE_UNISTD_H 1

/* Define if you have the <utmp.h> header file.  */
#define HAVE_UTMP_H 1

/* Define if you have the <utmpx.h> header file.  */
/* #undef HAVE_UTMPX_H */

/* Define if you have the cap library (-lcap).  */
/* #undef HAVE_LIBCAP */

/* Define if you have the dl library (-ldl).  */
/* #undef HAVE_LIBDL */

/* Define if you have the m library (-lm).  */
#define HAVE_LIBM 1

/* Define if you have the socket library (-lsocket).  */
/* #undef HAVE_LIBSOCKET */

[-- Attachment #3: Type: text/plain, Size: 1224 bytes --]


The only difference between that config.h file and the one from Apr-17
(which works) is that the new config.h file apparently checks for
SETUPTERM, and does not find it:

--- /u/shelton/new/build/SunOS-4.1/zsh-2001-04-17/config.h      Tue Apr 17 08:55:58 2001
+++ /u/shelton/new/build/SunOS-4.1/zsh-2001-04-24-new/config.h  Wed Apr 25 08:26:09 2001
@@ -557,6 +557,9 @@
 /* Define if you have the setuid function.  */
 #define HAVE_SETUID 1
 
+/* Define if you have the setupterm function.  */
+/* #undef HAVE_SETUPTERM */
+
 /* Define if you have the shl_findsym function.  */
 /* #undef HAVE_SHL_FINDSYM */


OK.  I found a little time to investigate further.  This is truly
ugly.  curses.h includes the following definitions:

extern char	*AL, *BC, *BT, *CD, *CE, *CL, *CM, *CR, *CS, *DC, *DL,
		*DM, *DO, *ED, *EI, *K0, *K1, *K2, *K3, *K4, *K5, *K6,
		*K7, *K8, *K9, *HO, *IC, *IM, *IP, *KD, *KE, *KH, *KL,
		*KR, *KS, *KU, *LL, *MA, *ND, *NL, *RC, *SC, *SE, *SF,
		*SO, *SR, *TA, *TE, *TI, *UC, *UE, *UP, *US, *VB, *VS,
		*VE, *AL_PARM, *DL_PARM, *UP_PARM, *DOWN_PARM,
		*LEFT_PARM, *RIGHT_PARM;

'DO' conflicts with the 'DO' token from zsh.h.  I guess curses.h
predates any kind of useful namespace standard.

  - vin

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: Make Failure on SunOS-4.1
  2001-04-25 18:03       ` Vin Shelton
@ 2001-04-26  4:27         ` Bart Schaefer
  2001-04-26  4:35           ` Make Failure on SunOS-4.1 (correction) Bart Schaefer
  0 siblings, 1 reply; 22+ messages in thread
From: Bart Schaefer @ 2001-04-26  4:27 UTC (permalink / raw)
  To: Vin Shelton; +Cc: zsh-workers

On Apr 25,  2:03pm, Vin Shelton wrote:
} Subject: Re: Make Failure on SunOS-4.1
}
} OK.  I found a little time to investigate further.  This is truly
} ugly.
} 
} 'DO' conflicts with the 'DO' token from zsh.h.  I guess curses.h
} predates any kind of useful namespace standard.

Ah, distant memory begins to return ... try the following patch (against
current CVS); if this works, the only configure.in issue we need to deal
with is the question of which (if either) of tigetstr or setupterm to pass
to a call to AC_SEARCH_LIBS.


diff -u -x CVS zsh-forge/current/Src/Modules/termcap.c zsh-4.0/Src/Modules/termcap.c
--- zsh-forge/current/Src/Modules/termcap.c	Mon Apr 23 23:43:27 2001
+++ zsh-4.0/Src/Modules/termcap.c	Wed Apr 25 21:24:42 2001
@@ -27,36 +27,36 @@
  *
  */
 
-#define USES_TERMCAP_H 1
-#define USES_TERM_H 1
+#ifdef HAVE_TGETENT
+# if defined(HAVE_CURSES_H) && defined(HAVE_TERM_H)
+#  define USES_TERM_H 1
+# else
+#  ifdef HAVE_TERMCAP_H
+#   define USES_TERMCAP_H 1
+#  endif
+# endif
+
 #include "termcap.mdh"
 #include "termcap.pro"
 
 static char termcap_nam[] = "termcap";
 
-/* echotc: output a termcap */
-
 #ifdef HAVE_TGETENT
-# if defined(HAVE_CURSES_H) && defined(HAVE_TERM_H)
+# ifdef USES_TERM_H
 #  ifdef HAVE_TERMIO_H
 #   include <termio.h>
 #  endif
 #  include <curses.h>
 #  include <term.h>
 # else
-#  ifdef HAVE_TERMCAP_H
+#  ifdef USES_TERMCAP_H
 #   include <termcap.h>
-#  else
-#   ifdef HAVE_CURSES_H
-#    include <curses.h>
-#   endif
-#   ifdef HAVE_TERM_H
-#    include <term.h>
-#   endif
 #  endif
 # endif
 
 static Param termcap_pm;
+
+/* echotc: output a termcap */
 
 /**/
 static int

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: Make Failure on SunOS-4.1 (correction)
  2001-04-26  4:27         ` Bart Schaefer
@ 2001-04-26  4:35           ` Bart Schaefer
  2001-04-26 12:50             ` Vin Shelton
  0 siblings, 1 reply; 22+ messages in thread
From: Bart Schaefer @ 2001-04-26  4:35 UTC (permalink / raw)
  To: Vin Shelton; +Cc: zsh-workers

On Apr 26, Bart Schaefer wrote:
}
} Ah, distant memory begins to return ... try the following patch

Except that I botched it and sent a broken patch.  Here's the right one:

diff -u -x CVS zsh-forge/current/Src/Modules/termcap.c zsh-4.0/Src/Modules/termcap.c
--- zsh-forge/current/Src/Modules/termcap.c	Mon Apr 23 23:43:27 2001
+++ zsh-4.0/Src/Modules/termcap.c	Wed Apr 25 21:29:17 2001
@@ -27,36 +27,37 @@
  *
  */
 
-#define USES_TERMCAP_H 1
-#define USES_TERM_H 1
+#ifdef HAVE_TGETENT
+# if defined(HAVE_CURSES_H) && defined(HAVE_TERM_H)
+#  define USES_TERM_H 1
+# else
+#  ifdef HAVE_TERMCAP_H
+#   define USES_TERMCAP_H 1
+#  endif
+# endif
+#endif
+
 #include "termcap.mdh"
 #include "termcap.pro"
 
 static char termcap_nam[] = "termcap";
 
-/* echotc: output a termcap */
-
 #ifdef HAVE_TGETENT
-# if defined(HAVE_CURSES_H) && defined(HAVE_TERM_H)
+# ifdef USES_TERM_H
 #  ifdef HAVE_TERMIO_H
 #   include <termio.h>
 #  endif
 #  include <curses.h>
 #  include <term.h>
 # else
-#  ifdef HAVE_TERMCAP_H
+#  ifdef USES_TERMCAP_H
 #   include <termcap.h>
-#  else
-#   ifdef HAVE_CURSES_H
-#    include <curses.h>
-#   endif
-#   ifdef HAVE_TERM_H
-#    include <term.h>
-#   endif
 #  endif
 # endif
 
 static Param termcap_pm;
+
+/* echotc: output a termcap */
 
 /**/
 static int

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: Make Failure on SunOS-4.1 (correction)
  2001-04-26  4:35           ` Make Failure on SunOS-4.1 (correction) Bart Schaefer
@ 2001-04-26 12:50             ` Vin Shelton
  2001-04-26 13:06               ` Or on ReliantUNIX ... " Andrej Borsenkow
  0 siblings, 1 reply; 22+ messages in thread
From: Vin Shelton @ 2001-04-26 12:50 UTC (permalink / raw)
  To: Bart Schaefer; +Cc: zsh-workers

Yes, that did it.  With this patch, zsh from the latest CVS sources
builds and runs on SunOS-4.1.

Thanks, bart.

  - vin

"Bart Schaefer" <schaefer@candle.brasslantern.com> writes:
> On Apr 26, Bart Schaefer wrote:
> }
> } Ah, distant memory begins to return ... try the following patch
> 
> Except that I botched it and sent a broken patch.  Here's the right one:
> 
> diff -u -x CVS zsh-forge/current/Src/Modules/termcap.c zsh-4.0/Src/Modules/termcap.c
> --- zsh-forge/current/Src/Modules/termcap.c	Mon Apr 23 23:43:27 2001
> +++ zsh-4.0/Src/Modules/termcap.c	Wed Apr 25 21:29:17 2001
> @@ -27,36 +27,37 @@
>   *
>   */
>  
> -#define USES_TERMCAP_H 1
> -#define USES_TERM_H 1
> +#ifdef HAVE_TGETENT
> +# if defined(HAVE_CURSES_H) && defined(HAVE_TERM_H)
> +#  define USES_TERM_H 1
> +# else
> +#  ifdef HAVE_TERMCAP_H
> +#   define USES_TERMCAP_H 1
> +#  endif
> +# endif
> +#endif
> +
>  #include "termcap.mdh"
>  #include "termcap.pro"
>  
>  static char termcap_nam[] = "termcap";
>  
> -/* echotc: output a termcap */
> -
>  #ifdef HAVE_TGETENT
> -# if defined(HAVE_CURSES_H) && defined(HAVE_TERM_H)
> +# ifdef USES_TERM_H
>  #  ifdef HAVE_TERMIO_H
>  #   include <termio.h>
>  #  endif
>  #  include <curses.h>
>  #  include <term.h>
>  # else
> -#  ifdef HAVE_TERMCAP_H
> +#  ifdef USES_TERMCAP_H
>  #   include <termcap.h>
> -#  else
> -#   ifdef HAVE_CURSES_H
> -#    include <curses.h>
> -#   endif
> -#   ifdef HAVE_TERM_H
> -#    include <term.h>
> -#   endif
>  #  endif
>  # endif
>  
>  static Param termcap_pm;
> +
> +/* echotc: output a termcap */
>  
>  /**/
>  static int
> 
> -- 
> Bart Schaefer                                 Brass Lantern Enterprises
> http://www.well.com/user/barts              http://www.brasslantern.com
> 
> Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   
> 

-- 
In a minute there is time
For decisions and revisions which a minute will reverse.         T.S. Eliot
[URL: http://www.cs.amherst.edu/~ccm/prufrock.html]


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Or on ReliantUNIX ... RE: Make Failure on SunOS-4.1 (correction)
  2001-04-26 12:50             ` Vin Shelton
@ 2001-04-26 13:06               ` Andrej Borsenkow
  2001-04-26 13:15                 ` Clint Adams
  2001-04-26 14:35                 ` Bart Schaefer
  0 siblings, 2 replies; 22+ messages in thread
From: Andrej Borsenkow @ 2001-04-26 13:06 UTC (permalink / raw)
  To: zsh-workers


>
> Yes, that did it.  With this patch, zsh from the latest CVS sources
> builds and runs on SunOS-4.1.
>

Now it's my turn:

gmake[3]: Entering directory `/u3/u1/build/zsh/Src/Modules'
cc -c -I. -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LONGLONG -Kll64 -DHAVE
_CONFIG_H -DMODULE -g -Kpic -o termcap..o /tools/src/zsh/Src/Modules/termcap.c
/tools/src/zsh/Src/Modules/termcap.c   321: [error]:   CFE1020 identifier
"boolcodes" is undefined
      for (capcode = (char **)boolcodes; *capcode; capcode++) {
                              ^

/tools/src/zsh/Src/Modules/termcap.c   330: [error]:   CFE1020 identifier
"numcodes" is undefined
      for (capcode = (char **)numcodes; *capcode; capcode++) {
                              ^

/tools/src/zsh/Src/Modules/termcap.c   339: [error]:   CFE1020 identifier
"strcodes" is undefined
      for (capcode = (char **)strcodes; *capcode; capcode++) {
                              ^
I have termcap == cureses here; and

bor@itsrm2% grep boolco /usr/include/*.h
/usr/include/term.h:            *boolnames[], *boolcodes[], *boolfnames[],

May be, we shuld just hold these patches until 4.0.1 release. They are nice to
have but definitely not important, as opposed to e.g. parameter stuff cleanup.

-andrej

Before this patch it compiled O.K.


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: Or on ReliantUNIX ... RE: Make Failure on SunOS-4.1 (correction)
  2001-04-26 13:06               ` Or on ReliantUNIX ... " Andrej Borsenkow
@ 2001-04-26 13:15                 ` Clint Adams
  2001-04-26 13:25                   ` Andrej Borsenkow
  2001-04-26 14:35                 ` Bart Schaefer
  1 sibling, 1 reply; 22+ messages in thread
From: Clint Adams @ 2001-04-26 13:15 UTC (permalink / raw)
  To: Andrej Borsenkow; +Cc: zsh-workers

> cc -c -I. -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LONGLONG -Kll64 -DHAVE
> _CONFIG_H -DMODULE -g -Kpic -o termcap..o /tools/src/zsh/Src/Modules/termcap.c
> /tools/src/zsh/Src/Modules/termcap.c   321: [error]:   CFE1020 identifier
> "boolcodes" is undefined
>       for (capcode = (char **)boolcodes; *capcode; capcode++) {

I'm confused.  Do you not have a curses.h?


^ permalink raw reply	[flat|nested] 22+ messages in thread

* RE: Or on ReliantUNIX ... RE: Make Failure on SunOS-4.1 (correction)
  2001-04-26 13:15                 ` Clint Adams
@ 2001-04-26 13:25                   ` Andrej Borsenkow
  2001-04-26 13:30                     ` Clint Adams
  0 siblings, 1 reply; 22+ messages in thread
From: Andrej Borsenkow @ 2001-04-26 13:25 UTC (permalink / raw)
  To: zsh-workers

>
> > cc -c -I. -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LONGLONG
> -Kll64 -DHAVE
> > _CONFIG_H -DMODULE -g -Kpic -o termcap..o
> /tools/src/zsh/Src/Modules/termcap.c
> > /tools/src/zsh/Src/Modules/termcap.c   321: [error]:   CFE1020 identifier
> > "boolcodes" is undefined
> >       for (capcode = (char **)boolcodes; *capcode; capcode++) {
>
> I'm confused.  Do you not have a curses.h?
>

Yes. The actual problem is of course difference between configure and source
code. configure must check for any symbol/declaration/etc using exactly the
same defines as will be used in code. Else it finds either too much or too
little :-)

The problem is it needs a bit of testing, and it needs time. Is it worth
delay?

-andrej


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: Or on ReliantUNIX ... RE: Make Failure on SunOS-4.1 (correction)
  2001-04-26 13:25                   ` Andrej Borsenkow
@ 2001-04-26 13:30                     ` Clint Adams
  2001-04-26 14:02                       ` Andrej Borsenkow
  0 siblings, 1 reply; 22+ messages in thread
From: Clint Adams @ 2001-04-26 13:30 UTC (permalink / raw)
  To: Andrej Borsenkow; +Cc: zsh-workers

> Yes. The actual problem is of course difference between configure and source
> code. configure must check for any symbol/declaration/etc using exactly the
> same defines as will be used in code. Else it finds either too much or too
> little :-)

If you have HAVE_TGETENT, HAVE_CURSES_H, and HAVE_TERM_H, then you should
have the same defines (curses.h, term.h) as were used in the configure
test, no?


^ permalink raw reply	[flat|nested] 22+ messages in thread

* RE: Or on ReliantUNIX ... RE: Make Failure on SunOS-4.1 (correction)
  2001-04-26 13:30                     ` Clint Adams
@ 2001-04-26 14:02                       ` Andrej Borsenkow
  2001-04-26 14:20                         ` Clint Adams
  0 siblings, 1 reply; 22+ messages in thread
From: Andrej Borsenkow @ 2001-04-26 14:02 UTC (permalink / raw)
  To: zsh-workers


> > Yes. The actual problem is of course difference between configure
> and source
> > code. configure must check for any symbol/declaration/etc using
> exactly the
> > same defines as will be used in code. Else it finds either too much or too
> > little :-)
>
> If you have HAVE_TGETENT, HAVE_CURSES_H, and HAVE_TERM_H, then you should
> have the same defines (curses.h, term.h) as were used in the configure
> test, no?
>

Yes, but you have to test for them after including config.h, not before?

After moving

#ifdef HAVE_TGETENT
# if defined(HAVE_CURSES_H) && defined(HAVE_TERM_H)
#  define USES_TERM_H 1
# else
#  ifdef HAVE_TERMCAP_H
#   define USES_TERMCAP_H 1
#  endif
# endif
#endif

after #inlcude "termcap.mdh" I get different error:

ONFIG_H -DMODULE -g -Kpic -o termcap..o /tools/src/zsh/Src/Modules/termcap.c
/usr/include/unctrl.h    17: [warning]:   CFE1301 typedef name has already
been declared (with same type)
  typedef unsigned long chtype;
                        ^

/usr/include/term.h  1196: [error]:   CFE1147 declaration is incompatible with
"int tputs(char *, int, int (*)(int))" (declared at line 42 of
"/tools/src/zsh/Src/prototypes.h")
                tputs(char *, int, int (*)(char)), putp(char *),
                ^
 /tools/src/zsh/Src/Modules/termcap.c   125: [warning]:   CFE1167 argument of
type "int (*)(int)" is incompatible with parameter of type "int (*)(char)"
        tputs(tgoto(t, atoi(*argv), num), num, putraw);
                                               ^
 -andrej



^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: Or on ReliantUNIX ... RE: Make Failure on SunOS-4.1 (correction)
  2001-04-26 14:02                       ` Andrej Borsenkow
@ 2001-04-26 14:20                         ` Clint Adams
  0 siblings, 0 replies; 22+ messages in thread
From: Clint Adams @ 2001-04-26 14:20 UTC (permalink / raw)
  To: Andrej Borsenkow; +Cc: zsh-workers

> Yes, but you have to test for them after including config.h, not before?

What do you mean?  config.h shouldn't be affecting system include files.

> After moving
> 
> #ifdef HAVE_TGETENT
> # if defined(HAVE_CURSES_H) && defined(HAVE_TERM_H)
> #  define USES_TERM_H 1
> # else
> #  ifdef HAVE_TERMCAP_H
> #   define USES_TERMCAP_H 1
> #  endif
> # endif
> #endif
> 
> after #inlcude "termcap.mdh" I get different error:

Well, putting the USES_TERM{,CAP}_H defines after termcap.mdh is
not very useful.


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: Or on ReliantUNIX ... RE: Make Failure on SunOS-4.1 (correction)
  2001-04-26 13:06               ` Or on ReliantUNIX ... " Andrej Borsenkow
  2001-04-26 13:15                 ` Clint Adams
@ 2001-04-26 14:35                 ` Bart Schaefer
  2001-04-26 14:52                   ` Andrej Borsenkow
  1 sibling, 1 reply; 22+ messages in thread
From: Bart Schaefer @ 2001-04-26 14:35 UTC (permalink / raw)
  To: Andrej Borsenkow, zsh-workers

On Apr 26,  5:06pm, Andrej Borsenkow wrote:
} Subject: Or on ReliantUNIX ... RE: Make Failure on SunOS-4.1 (correction)
}
} >
} > Yes, that did it.  With this patch, zsh from the latest CVS sources
} > builds and runs on SunOS-4.1.
} 
} Now it's my turn:
} 
} gmake[3]: Entering directory `/u3/u1/build/zsh/Src/Modules'
} cc -c -I. -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LONGLONG -Kll64 -DHAVE
} _CONFIG_H -DMODULE -g -Kpic -o termcap..o /tools/src/zsh/Src/Modules/termcap.c
} /tools/src/zsh/Src/Modules/termcap.c   321: [error]:   CFE1020 identifier
} "boolcodes" is undefined
}       for (capcode = (char **)boolcodes; *capcode; capcode++) {
}                               ^
} 
} Before this patch it compiled O.K.

I think I know why.  Try the patch as I committed it just now, rather than
as it was sent to the list.  (I forgot to #include config.h before testing
HAVE_TGETENT, but for Vin's system that didn't matter because it wasn't
defined anyway.)

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   


^ permalink raw reply	[flat|nested] 22+ messages in thread

* RE: Or on ReliantUNIX ... RE: Make Failure on SunOS-4.1 (correction)
  2001-04-26 14:35                 ` Bart Schaefer
@ 2001-04-26 14:52                   ` Andrej Borsenkow
  2001-04-26 14:58                     ` Clint Adams
  0 siblings, 1 reply; 22+ messages in thread
From: Andrej Borsenkow @ 2001-04-26 14:52 UTC (permalink / raw)
  To: zsh-workers


>
> I think I know why.  Try the patch as I committed it just now, rather than
> as it was sent to the list.  (I forgot to #include config.h before testing
> HAVE_TGETENT, but for Vin's system that didn't matter because it wasn't
> defined anyway.)
>

It compiles. Just in case, here are some warnings, if anybody feels like
cleaning them:

cc -c -I. -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LONGLONG -Kll64 -DHAVE
_CONFIG_H -DMODULE -g -Kpic -o termcap..o /tools/src/zsh/Src/Modules/termcap.c
/usr/include/unctrl.h    17: [warning]:   CFE1301 typedef name has already
been declared (with same type)
  typedef unsigned long chtype;
                        ^

/tools/src/zsh/Src/Modules/termcap.c   130: [warning]:   CFE1167 argument of
type "int (*)(int)" is incompatible with parameter of type "int (*)(char)"
        tputs(t, 1, putraw);
                    ^

/tools/src/zsh/Src/Modules/termcap.c   133: [warning]:   CFE1167 argument of
type "int" is incompatible with parameter of type "char *"
        tputs(tgoto(t, atoi(*argv), num), num, putraw);
              ^

/tools/src/zsh/Src/Modules/termcap.c   133: [warning]:   CFE1167 argument of
type "int (*)(int)" is incompatible with parameter of type "int (*)(char)"
        tputs(tgoto(t, atoi(*argv), num), num, putraw);
                                               ^

/tools/src/zsh/Src/Modules/termcap.c   150: [warning]:   CFE1550 variable
"incleanup" was set but never used
  static int incleanup;
             ^

-andrej


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: Or on ReliantUNIX ... RE: Make Failure on SunOS-4.1 (correction)
  2001-04-26 14:52                   ` Andrej Borsenkow
@ 2001-04-26 14:58                     ` Clint Adams
  2001-04-26 15:32                       ` Bart Schaefer
  0 siblings, 1 reply; 22+ messages in thread
From: Clint Adams @ 2001-04-26 14:58 UTC (permalink / raw)
  To: Andrej Borsenkow; +Cc: zsh-workers

> /tools/src/zsh/Src/Modules/termcap.c   130: [warning]:   CFE1167 argument of
> type "int (*)(int)" is incompatible with parameter of type "int (*)(char)"
>         tputs(t, 1, putraw);

Solaris 8 has the same problem, but it seems to cope well.  I believe
SUS and POSIX both call for int (*)int.
> 
> /tools/src/zsh/Src/Modules/termcap.c   150: [warning]:   CFE1550 variable
> "incleanup" was set but never used
>   static int incleanup;

That's puzzling.


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: Or on ReliantUNIX ... RE: Make Failure on SunOS-4.1 (correction)
  2001-04-26 14:58                     ` Clint Adams
@ 2001-04-26 15:32                       ` Bart Schaefer
  2001-04-26 15:52                         ` Clint Adams
  0 siblings, 1 reply; 22+ messages in thread
From: Bart Schaefer @ 2001-04-26 15:32 UTC (permalink / raw)
  To: zsh-workers

On Apr 26, 10:58am, Clint Adams wrote:
} Subject: Re: Or on ReliantUNIX ... RE: Make Failure on SunOS-4.1 (correcti
}
} > /tools/src/zsh/Src/Modules/termcap.c   150: [warning]:   CFE1550 variable
} > "incleanup" was set but never used
} >   static int incleanup;
} 
} That's puzzling.

In each of termcap.c and terminfo.c the only references to `incleanup' are
the static declaration and two assignments; it's never tested anywyere.

Either it should be tested in getterm{info,cap}, or removed entirely.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: Or on ReliantUNIX ... RE: Make Failure on SunOS-4.1 (correction)
  2001-04-26 15:32                       ` Bart Schaefer
@ 2001-04-26 15:52                         ` Clint Adams
  0 siblings, 0 replies; 22+ messages in thread
From: Clint Adams @ 2001-04-26 15:52 UTC (permalink / raw)
  To: Bart Schaefer; +Cc: zsh-workers

> Either it should be tested in getterm{info,cap}, or removed entirely.

Hmm, good point.

Index: Src/Modules/termcap.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/termcap.c,v
retrieving revision 1.11
diff -u -r1.11 termcap.c
--- Src/Modules/termcap.c	2001/04/26 15:48:17	1.11
+++ Src/Modules/termcap.c	2001/04/26 15:51:02
@@ -147,10 +147,6 @@
     BUILTIN("echotc", 0, bin_echotc, 1, -1, 0, NULL, NULL),
 };
 
-/* This says if we are cleaning up when the module is unloaded. */
-
-static int incleanup;
-
 /**/
 #ifdef HAVE_TGETENT
 
@@ -363,8 +359,6 @@
 int
 setup_(Module m)
 {
-    incleanup = 0;
-
     return 0;
 }
 
@@ -391,11 +385,7 @@
 {
 #ifdef HAVE_TGETENT
     Param pm;
-#endif
-
-    incleanup = 1;
 
-#ifdef HAVE_TGETENT
     if ((pm = (Param) paramtab->getnode(paramtab, termcap_nam)) &&
 	pm == termcap_pm) {
 	pm->flags &= ~PM_READONLY;
Index: Src/Modules/terminfo.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/terminfo.c,v
retrieving revision 1.16
diff -u -r1.16 terminfo.c
--- Src/Modules/terminfo.c	2001/04/24 06:48:54	1.16
+++ Src/Modules/terminfo.c	2001/04/26 15:51:02
@@ -109,10 +109,6 @@
     BUILTIN("echoti", 0, bin_echoti, 1, -1, 0, NULL, NULL),
 };
 
-/* This says if we are cleaning up when the module is unloaded. */
-
-static int incleanup;
-
 /**/
 #ifdef HAVE_TIGETSTR
 
@@ -337,8 +333,6 @@
 int
 setup_(Module m)
 {
-    incleanup = 0;
-
     return 0;
 }
 
@@ -365,11 +359,7 @@
 {
 #ifdef HAVE_TIGETSTR
     Param pm;
-#endif
-
-    incleanup = 1;
 
-#ifdef HAVE_TIGETSTR
     if ((pm = (Param) paramtab->getnode(paramtab, terminfo_nam)) &&
 	pm == terminfo_pm) {
 	pm->flags &= ~PM_READONLY;


^ permalink raw reply	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2001-04-26 15:52 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-04-24 19:43 Make Failure on SunOS-4.1 Vin Shelton
2001-04-25  4:13 ` Bart Schaefer
2001-04-25  9:55   ` Peter Stephenson
2001-04-25 14:41     ` Bart Schaefer
2001-04-25 14:57       ` Clint Adams
2001-04-25 14:29   ` Vin Shelton
2001-04-25 14:58     ` Bart Schaefer
2001-04-25 18:03       ` Vin Shelton
2001-04-26  4:27         ` Bart Schaefer
2001-04-26  4:35           ` Make Failure on SunOS-4.1 (correction) Bart Schaefer
2001-04-26 12:50             ` Vin Shelton
2001-04-26 13:06               ` Or on ReliantUNIX ... " Andrej Borsenkow
2001-04-26 13:15                 ` Clint Adams
2001-04-26 13:25                   ` Andrej Borsenkow
2001-04-26 13:30                     ` Clint Adams
2001-04-26 14:02                       ` Andrej Borsenkow
2001-04-26 14:20                         ` Clint Adams
2001-04-26 14:35                 ` Bart Schaefer
2001-04-26 14:52                   ` Andrej Borsenkow
2001-04-26 14:58                     ` Clint Adams
2001-04-26 15:32                       ` Bart Schaefer
2001-04-26 15:52                         ` Clint Adams

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).