zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk (Zsh hackers list)
Subject: Re: order of processing in brace expansion
Date: Fri, 27 Apr 2001 19:09:56 +0100	[thread overview]
Message-ID: <Tc0a88d01532d9494fe@mailsweeper01.cambridgesiliconradio.com> (raw)
In-Reply-To: Your message of "27 Apr 2001 11:31:48 MDT." <yu9n1928d17.fsf@cato.aoc.nrao.edu>

Allan Poindexter <apoindex@aoc.nrao.edu> wrote:
> Consider the following:
> 
> pts/11 10:37 208%setopt braceccl
> pts/11 10:38 209%foo=b,c
> pts/11 10:38 210%echo a{$foo}d
> a,d abd acd
> 
> Can anyone shed any light on what I might be overlooking here?

By default, parameters in zsh are expanded without turning the contents
into tokens, so the comma is just treated as a normal character, just as if
you had typed a{'b,c'}d.  This is the behaviour I would expect.

The real bug, I would say, is this:

% echo a{$~foo}d
a,d abd acd

The ~ force $foo to be interpreted pretty much as if the characters had
been put directly on the command line (the option GLOB_SUBST does the same
thing).  This is done by default by a lot of other shells.  In *this* case,
I would expect what you expect: the expression is interpreted the same as
a{b,c}d.  Unfortunately it isn't.  The reason seems to be that the comma
doesn't get turned back into a token.  If we want to fix this, the
following patch will do it.

Index: Src/glob.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/glob.c,v
retrieving revision 1.15
diff -u -r1.15 glob.c
--- Src/glob.c	2001/04/24 05:45:17	1.15
+++ Src/glob.c	2001/04/27 17:57:25
@@ -2373,6 +2373,7 @@
 	case '*':
 	case '?':
 	case '=':
+	case ',':
 	    for (t = ztokens; *t; t++)
 		if (*t == *s) {
 		    if (bslash)

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Unit 300, Science Park, Milton Road,
Cambridge, CB4 0XL, UK                          Tel: +44 (0)1223 392070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************


  reply	other threads:[~2001-04-27 18:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-27 17:31 Allan Poindexter
2001-04-27 18:09 ` Peter Stephenson [this message]
2001-04-28  6:05   ` Bart Schaefer
2001-04-28 18:17     ` Bart Schaefer
2001-05-02  9:50     ` Peter Stephenson
2001-05-02 14:59       ` Bart Schaefer
2001-05-02 15:28         ` Peter Stephenson
2001-05-02 16:30           ` Bart Schaefer
2001-05-09  9:06             ` Peter Stephenson
2001-05-11 16:57               ` Allan Poindexter
2001-05-11 19:22             ` Allan Poindexter
2001-05-11 20:09               ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Tc0a88d01532d9494fe@mailsweeper01.cambridgesiliconradio.com \
    --to=pws@csr.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).