From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk (Zsh hackers list)
Subject: Re: General unqueue_signal problem
Date: Mon, 18 Jun 2001 10:20:33 +0100 [thread overview]
Message-ID: <Tc0a88d0154377c1d53@mailsweeper01.cambridgesiliconradio.com> (raw)
In-Reply-To: "Sven Wischnowsky"'s message of "Mon, 18 Jun 2001 09:21:50 +0200." <200106180721.JAA11015@beta.informatik.hu-berlin.de>
Sven Wischnowsky wrote:
> Peter Stephenson wrote:
> > Adding mod_export is obviously the right first step, and probably ought to
> > fix this particular bug. I haven't got time to change the name `handler'
> > at the moment, but replacing it by zhandler sounds sensible.
>
> Here's the patchlet for that.
I'd feel happier if handler were changed to zhandler for systems that don't
use POSIX signals, too.
Of course, *I* would never commit a patch without a thorough review of all
effects. Ummm....
Index: Src/signals.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/signals.c,v
retrieving revision 1.19
diff -u -r1.19 signals.c
--- Src/signals.c 2001/06/18 07:24:23 1.19
+++ Src/signals.c 2001/06/18 09:17:49
@@ -105,7 +105,7 @@
# ifdef BSD_SIGNALS
struct sigvec vec;
- vec.sv_handler = (SIGNAL_HANDTYPE) handler;
+ vec.sv_handler = (SIGNAL_HANDTYPE) zhandler;
vec.sv_mask = sigmask(sig); /* mask out this signal while in handler */
# ifdef SV_INTERRUPT
vec.sv_flags = SV_INTERRUPT; /* make sure system calls are not restarted */
@@ -115,9 +115,9 @@
# ifdef SYSV_SIGNALS
/* we want sigset rather than signal because it will *
* block sig while in handler. signal usually doesn't */
- sigset(sig, handler);
+ sigset(sig, zhandler);
# else /* NO_SIGNAL_BLOCKING (bummer) */
- signal(sig, handler);
+ signal(sig, zhandler);
# endif /* SYSV_SIGNALS */
# endif /* BSD_SIGNALS */
**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential
and/or privileged material.
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by
persons or entities other than the intended recipient is
prohibited.
If you received this in error, please contact the sender and
delete the material from any computer.
**********************************************************************
next prev parent reply other threads:[~2001-06-18 9:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.SV4.4.33.0106120954500.24714-200000@itsrm2.mow.siemens.ru>
[not found] ` <yeh3d95lsa0.fsf@water.cs.brown.edu>
2001-06-12 17:58 ` AIX-problem: the main module won't link statically Andrej Borsenkow
2001-06-12 18:19 ` Peter Stephenson
2001-06-12 19:14 ` Bart Schaefer
2001-06-12 20:09 ` Wayne Davison
2001-06-13 9:20 ` Peter Stephenson
2001-06-13 6:09 ` 4.0.2 patches " Andrej Borsenkow
2001-06-13 9:22 ` Peter Stephenson
2001-06-13 8:46 ` Sven Wischnowsky
2001-06-13 8:48 ` Sven Wischnowsky
2001-06-13 6:34 ` General unqueue_signal problem Andrej Borsenkow
2001-06-13 9:30 ` Peter Stephenson
2001-06-18 7:21 ` Sven Wischnowsky
2001-06-18 9:20 ` Peter Stephenson [this message]
2001-06-13 10:57 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Tc0a88d0154377c1d53@mailsweeper01.cambridgesiliconradio.com \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).