zsh-workers
 help / color / mirror / code / Atom feed
From: Matthew Martin <phy1729@gmail.com>
To: zsh-workers@zsh.org
Subject: Re: Bug in Functions/Misc/regexp-replace
Date: Thu, 29 Apr 2021 19:40:41 -0500	[thread overview]
Message-ID: <YItSCc5bvilHOEC/@CptOrmolo.darkstar> (raw)
In-Reply-To: <CAB5oL3Z4m+vYsGLzkAqw62o3RbUy+N5HpgbBuLn_kK99YPNjDg@mail.gmail.com>

On Thu, Apr 29, 2021 at 07:53:52PM -0400, Jacob Menke wrote:
> Hello,
> 
> I think I found a bug in Functions/Misc/regexp-replace

> One way to fix:
> 41: eval ${1}=${(qqq)5}
> 
> Patch file is attached.

Thanks for the report, minimal reproducer, and patch. I think it would
make sense to swap the eval for ${(P) ::= here as below.


diff --git a/Functions/Misc/regexp-replace b/Functions/Misc/regexp-replace
index dec105524..ff82c39b6 100644
--- a/Functions/Misc/regexp-replace
+++ b/Functions/Misc/regexp-replace
@@ -38,6 +38,6 @@ while [[ -n $4 ]]; do
 done
 5+=$4
 
-eval ${1}=${(q)5}
+: ${(P)1::=$5}
 # status 0 if we did something, else 1.
 [[ -n $6 ]]


  reply	other threads:[~2021-04-30  0:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-29 23:53 Jacob Menke
2021-04-30  0:40 ` Matthew Martin [this message]
2021-04-30  5:56   ` Stephane Chazelas
2021-04-30  6:51 ` Stephane Chazelas
2021-04-30  8:17   ` tilde expansion after quoted : in assignments Stephane Chazelas
2021-04-30 17:43     ` Bart Schaefer
2021-04-30 20:13   ` Bug in Functions/Misc/regexp-replace Jacob Menke
2021-04-30 21:22     ` Bart Schaefer
2021-04-30 20:43   ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YItSCc5bvilHOEC/@CptOrmolo.darkstar \
    --to=phy1729@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).