zsh-workers
 help / color / mirror / code / Atom feed
From: Matthew Martin <phy1729@gmail.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] _python: add missing options
Date: Tue, 27 Jul 2021 22:42:13 -0500	[thread overview]
Message-ID: <YQDSFeMyF7rsS38G@CptOrmolo.darkstar> (raw)
In-Reply-To: <20210726221050.764873-1-stepnem@gmail.com>

On Tue, Jul 27, 2021 at 12:10:50AM +0200, Štěpán Němec wrote:
> ---
>  Completion/Unix/Command/_python | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Completion/Unix/Command/_python b/Completion/Unix/Command/_python
> index f10106f9b4d9..05d26f2e7652 100644
> --- a/Completion/Unix/Command/_python
> +++ b/Completion/Unix/Command/_python
> @@ -1,7 +1,7 @@
>  #compdef -P python[0-9.]#
>  
>  # Python 2.7
> -# Python 3.4
> +# Python 3.9
>  
>  local curcontext="$curcontext" state state_descr line
>  typeset -A opt_args
> @@ -11,7 +11,9 @@ if _pick_variant python3=Python\ 3 python2 --version; then
>    args=(
>      '(-bb)-b[issue warnings about str(bytes_instance), str(bytearray_instance) and comparing bytes/bytearray with str]'
>      '(-b)-bb[issue errors about str(bytes_instance), str(bytearray_instance) and comparing bytes/bytearray with str]'
> +    '--check-hash-based-pycs[configure how Python evaluates up-to-dateness of hash-based .pyc files]:mode'

Should probably offer the allowed modes here
    '--check-hash-based-pycs[configure how Python evaluates up-to-dateness of hash-based .pyc files]:mode:(default always never)'

>      "-I[isolate Python from the user's environment]"
> +    '-q[do not print version and copyright messages]'
>      '-X[set implementation-specific option]:option'
>    )
>  else
> @@ -37,7 +39,8 @@ _arguments -C -s -S "$args[@]" \
>    "-s[don't add user site directory to sys.path]" \
>    "-S[don't imply 'import site' on initialization]" \
>    '-u[unbuffered binary stdout and stderr]' \
> -  '-v[verbose (trace import statements)]' \
> +  '(-vv)-v[trace module initialization and cleanup]' \
> +  '(-v)-vv[in addition to -v, trace all files checked when searching for a module]' \

--help only mentions "can be supplied multiple times to increase
verbosity" not what each count does. I'm not sure we should be more
specific than the --help output. Changing the spec to *-v may suffice.

>    '(1 * -)-V[display version information]' \
>    '-W+[warning control]:warning filter (action\:message\:category\:module\:lineno):(default always ignore module once error)' \
>    '-x[skip first line of source, allowing use of non-Unix forms of #!cmd]' \
> 
> base-commit: f8ec33c453159ad848d9b1a28782c5df7f0cc944
> -- 
> 2.32.0
> 
> 


  reply	other threads:[~2021-07-28  3:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-26 22:10 Štěpán Němec
2021-07-28  3:42 ` Matthew Martin [this message]
2021-08-03 17:36   ` [PATCH v2] " Štěpán Němec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQDSFeMyF7rsS38G@CptOrmolo.darkstar \
    --to=phy1729@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).