From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 18140 invoked from network); 7 Apr 2022 04:52:31 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 7 Apr 2022 04:52:31 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1649307151; b=WIUMa6W+SoR3cKSUPulqh1usVPvk5Hk/wAaYoQWeg6ww35434jor1EaXc8OjAJ4so3vqvZZdKV 8QCyIWaRZq9odfASCBqMMRfOcFby9rizPyce6Dn4b5iXNhoUqI8vtB/jm4sp6SJVDtXoFYMND2 gqXa0Z+jp40ccxnWRme/nQ0VQMR//O+9Hz4Aj0oXhpaPUrkvkq+AtLHMzzxy/Q1uBkPQHzZ/C4 SjI/RV/9a4U68xwE57WkxmBLteqe31BJNc86fU+dKHNCD2SSQbL7BooFClplNN5WLMgg8OeFju BGQRsdQjHgj8U5123qws8djYXQ6sKi7rvudGPdenowcK0g==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-oi1-f172.google.com) smtp.remote-ip=209.85.167.172; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1649307151; bh=lPbcrUTAWVJ/UwriiVM3Wcyq34FvoDMhn0ZEKghfFTI=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:To:From:Date:DKIM-Signature:DKIM-Signature; b=CSEqffnN1TXBkC9I3v5pm9l4SYFALn7iOPqCJUFJRer6jgT9f6XcQE2KmeWE8Imf0IPQ+MKMz1 Lm92DPuPWNbADS7IR3e84O6N3bQTpFhLynLr6cEwzrKxmndCbRiWCLNnVueAHVwsEkTIWCdUJo LAjHBeuZHFMLdDiVsVZKPm8c33j4CG7AEpGsP6DC6+941zpZaffpadi3m49QiPmfNUnnYePxiG WlzmLJKrdpxi5mc219k3wemSOLHCW2B+AWBhT475W/B1oc8jovWjrKdbfrHD4q61bnf0UjavzS l5Ph7YyGgZ7PIF169OFXI4atOpdbM0zbpXVIbndRS90DsA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:To:From:Date:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=DTjCTdLS+NaHirHu8J3gKFCKG5RzH90M03vPLHAGzjQ=; b=jEO2IhT+EWbntBlKCFcmvwrBsp W47+qXX4PutbCfL654dpHYos9nCpAcRD9GAYUEJVbfR/VJN7wHnsOngdIbVUx5o5Hxdl3cdZa0nH+ 1BbQxQx3t4nUh2kQLLcAO8RCROwRyfKL0Yb6s4bgQ9hlLjeKNb9cJr42HtZLD6XfQemmQGQVLFY11 oqkky3DUoFIih3tlNp4mhvJ7LQJ5Mqcia1KGcaXgyhFomOm57WCa0yscfVbVqdJ0kvr5F6kl8MYHS QxE4qBZ1tIy8tp0Zp/WgkAiQaoFyRzJMy1cVEzXiSrTrFEyCOhDjdpqD9GEwU6WVxPjL1ssN+Ex2S p0P4ecmQ==; Received: from authenticated user by zero.zsh.org with local id 1ncK8E-00079M-G7; Thu, 07 Apr 2022 04:52:30 +0000 Authentication-Results: zsh.org; iprev=pass (mail-oi1-f172.google.com) smtp.remote-ip=209.85.167.172; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-oi1-f172.google.com ([209.85.167.172]:44815) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1ncK7x-0006p9-Sg; Thu, 07 Apr 2022 04:52:14 +0000 Received: by mail-oi1-f172.google.com with SMTP id t21so4528929oie.11 for ; Wed, 06 Apr 2022 21:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=DTjCTdLS+NaHirHu8J3gKFCKG5RzH90M03vPLHAGzjQ=; b=oVEZEvMhANMtZNOa7n8N0OWAXZxlewn+OOxKQeVbRy9iOIWXwf3KP44NpjDLyKt6oZ prQnDXrCyMpcN4x7EgKx3BlPO0UVPpm2y6vAHsGP8qy8iHxEQF+sS503cfYq1/LmAun3 57XbLNf6O/m8am37rN+yZh0XDZZ9jqZWqLoFpwxG5LvZEcMlds1KvqMxnD4Xhq02PA+k RSJ8NC3x6mmcLTLCifTrna+Enmz3ASuPVHyjw+QPP5L21MUR1Q1rKgsZLeLgEhv+IGUl a8+MI8DFkQFQWQcU/eUxCMU3kTt8PP9h4nf7RLGOebiwDdm+lnIKK6F8XW7c79SCkj5w J4NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to; bh=DTjCTdLS+NaHirHu8J3gKFCKG5RzH90M03vPLHAGzjQ=; b=nCXY7MJnhPmPXsCU4MgMa9tkWGHQrE35FaNmnyPiptrOvuIfXPL/VQlkis5wHp059x ltWfXFFTUrpZv7KFyxLYlP8bqFGGplSD1qvbgV34BJ1ZOM+DT5aHUUl8FdLE04RlarHl vyGV2c7P2IhiBq39fW9JqxbHgVnRMtoWVTicXpnCl5o4E3W7IX7OGyL7XjRJE/qJahij N28G14+Y40FNOP1t67TEaPyM5idWWO5o81N4aqGZsZfgF6o5Isc+LVf6EJo31ziLOkB3 xCWFiLG2BLUtKgs2UMkCg3yj/76wJ3kBe2goaUQewOPIs1msxrp2uTC2dpjLVcDTlD8g 24+g== X-Gm-Message-State: AOAM533xa0Ek++SvZdwKbj087VNZTYqGa2zQRYE5htiKgTdLQUA3ntKj jwNxQ+eNS34iltfITJrB0prAUVWktPw= X-Google-Smtp-Source: ABdhPJxGjcTRnlscamkgZvViSZidJ5nQEl/8WASRbRCnprjXNloxlaIzNFi1J/3aguMyqEbP86S/UA== X-Received: by 2002:aca:4bc6:0:b0:2d9:a8e2:d99d with SMTP id y189-20020aca4bc6000000b002d9a8e2d99dmr5083668oia.74.1649307132367; Wed, 06 Apr 2022 21:52:12 -0700 (PDT) Received: from CptOrmolo.darkstar (cpe-76-184-110-212.tx.res.rr.com. [76.184.110.212]) by smtp.gmail.com with ESMTPSA id g8-20020a9d2d88000000b005b238f7551csm7410843otb.53.2022.04.06.21.52.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 21:52:11 -0700 (PDT) Date: Wed, 6 Apr 2022 23:52:08 -0500 From: Matthew Martin To: zsh-workers@zsh.org Subject: Re: Hang in E01 due to zpty on OpenBSD Message-ID: Mail-Followup-To: zsh-workers@zsh.org References: <4BCAE950-2D78-415A-88C3-8362946DC74C@kba.biglobe.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Seq: 50011 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Thu, Apr 07, 2022 at 12:47:18PM +0900, Jun T wrote: > > > 2022/04/06 21:53, Matthew Martin wrote: > > > > I'd prefer something like the below where it's a feature test instead of > > an OS test. > > I was thinking that we should better minimize the possible side effects > just before the new release. > > If we use your patch (with some fixes) openpty() will be used on ALL systems > (Linux, other BSDs and macOS, ...) if it is available. Is this what you > want to achieve? It may work but we need to test on lots of systems. I was thinking I'd wait until after the release and put the patch in the OpenBSD port until the next release. That way things are fixed with no need to rush. > > diff --git a/Src/Modules/zpty.c b/Src/Modules/zpty.c > (snip) > > +#elifdef USE_DEV_PTMX > #elif defined(USE_DEV_PTMX) > > > -#elif defined(__OpenBSD__) > > - static char char1[] = "pqrstuvwxyzPQRST"; > > - static char char2[] = "0123456789" > > - "abcdefghijklmnopqrstuvwxyz" > > - "ABCDEFGHIJKLMNOPQRSTUVWXYZ"; They no longer really support the /dev/ptyxx route. When I asked the response I got was, why do you think that should work it's dead and archaic. If openpty is removed in the future, falling back to /dev/pty is unlikely to be an option. > > diff --git a/configure.ac b/configure.ac > (snip) > > +AC_MSG_CHECKING([for openpty]) > > +openpty=no > > We need to call AC_SEARCH_LIBS(openpty, util) here to add -lutil to LIBS. > Otherwise the following two AC_LINK_IFELSE() fail and openpty() will never > be used. It worked here, but I don't claim to be an auto* expert. So just put the AC_SEARCH_LIBS before AC_MSG_CHECKING (otherwise the output is mixed up)?