From: "Daniel Shahaf" <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Cc: "Marc Finet" <m.dreadlock@gmail.com>
Subject: Re: [PATCH 2/2] vcs_info quilt: Use quilt-patch-dir and ${QUILT_PATCHES} even when get-unapplied hasn't been set
Date: Thu, 27 Jan 2022 18:12:18 +0000 [thread overview]
Message-ID: <a0a8d24a-a261-4a9f-b599-8a1e5d8aed17@www.fastmail.com> (raw)
In-Reply-To: <20220127175814.10179-2-danielsh@tarpaulin.shahaf.local2>
Daniel Shahaf wrote on Thu, 27 Jan 2022 17:58 +00:00:
> This affects the post-quilt hook. Before this patch, if no patches have
> been applied and get-unapplied hasn't been set, the second argument to
> that hook would undergo null elision.
>
> The generation of patch subjects for the gen-applied-string,
> gen-unapplied-string, and set-patch-format hooks was unaffected since
> it was guarded by [[ -n $patches ]].
While we're on the subject of hooks, I've been wondering how to pass the
quilt patches dir path to my gen-applied-string hook. (I have a hook
that does lsdiff on patches that have no header.)
Right now I'm just using $patches, since, well, that works.
The post-quilt hook gets that value passed to it, but that doesn't help
since it runs _after_ gen-applied-string.
I suppose I could add another hook that runs sooner…
Cheers,
Daniel
prev parent reply other threads:[~2022-01-27 18:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 17:58 [PATCH 1/2] vcs_info quilt: Refactor for readability. No functional change Daniel Shahaf
2022-01-27 17:58 ` [PATCH 2/2] vcs_info quilt: Use quilt-patch-dir and ${QUILT_PATCHES} even when get-unapplied hasn't been set Daniel Shahaf
2022-01-27 18:12 ` Daniel Shahaf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0a8d24a-a261-4a9f-b599-8a1e5d8aed17@www.fastmail.com \
--to=d.s@daniel.shahaf.name \
--cc=m.dreadlock@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).