zsh-workers
 help / color / mirror / code / Atom feed
From: "S. Cowles" <scowles@ckhb.org>
To: Peter Stephenson <Peter.Stephenson@csr.com>
Cc: zsh-workers@zsh.org
Subject: Re: build on os x 10.6.7, xcode 3.2.6
Date: Wed, 13 Apr 2011 12:32:23 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LN8.2.00.1104131146110.23733@ckhb06> (raw)
In-Reply-To: <20110413172646.2e406efd@pwslap01u.europe.root.pri>

On Wed, 13 Apr 2011, Peter Stephenson wrote:

> On Wed, 13 Apr 2011 09:10:47 -0700
> "S. Cowles" <scowles@ckhb.org> wrote:
>> i have been building source from the sourceforge cvs repository on os
>> x 10.6.x for the past two months with no issues, until this week.  as
>> of rev4.3.11-dev-1, patchlevel 1.5245, i have begun getting the
>> following build error
>>
>> gcc -c -I. -I/opt/local/include -DHAVE_CONFIG_H -Wall
>> -Wmissing-prototypes -O2  -o builtin.o builtin.c In file included
>> from zsh.mdh:37, from builtin.c:33:
>> exec.epro:29: error: 'RLIM_NLIMITS' undeclared here (not in a
>> function) make[2]: *** [builtin.o] Error 1
>> make[1]: *** [modobjs] Error 2
>> make: *** [all] Error 1
>>
>> previously, rev4.3.11-dev-1, patchlevel 1.5241, and prior, built with
>> no problems.  i am still looking for what might cause the
>> RLIM_NLIMITS definition to be missed, but wanted to find out if
>> someone was already aware of this issue and might point out any
>> possible mistake on my part.
>
> No, but there's a good chance it's got something to do with this
> change.  Changing random source code options often has side effects.
> Does removing either _GNU_SOURCE or _POSIX_C_SOURCE help?
>
> --- zsh-4.3.11/Src/system.h     2010-02-22 11:12:31.000000000 +0100
> +++ zsh/Src/system.h    2011-04-12 14:20:37.106000061 +0200
> @@ -37,13 +37,12 @@
> #endif
> #endif
>
> -#if defined(__linux) || defined(__GNU__) || defined(__GLIBC__)
> /*
>  * Turn on numerous extensions.
>  * This is in order to get the functions for manipulating /dev/ptmx.
>  */
> #define _GNU_SOURCE 1
> -#endif
> +#define _POSIX_C_SOURCE 200809L
>
> /* NeXT has half-implemented POSIX support *
>  * which currently fools configure         */


i checked all three cases:
 	1)
 		/* #define _GNU_SOURCE 1 /**/
 		#define _POSIX_C_SOURCE 200809L
 	2)
 		/* #define _GNU_SOURCE 1 /**/
 		/* #define _POSIX_C_SOURCE 200809L /**/
 	3)
 		#define _GNU_SOURCE 1
 		/* #define _POSIX_C_SOURCE 200809L /**/

cases 2 and 3 built patchlevel 1.5246 with no problem.  so, indeed,
removing _POSIX_C_SOURCE does help.  thank you very much for pinpointing
the search.

perhaps some directive such as the following might be sufficiently
restrictive to handle OS X and not interfere with other OS
installations on apple hardware:

#if !defined(__APPLE__) && !defined(__APPLE_CC__)
#define _POSIX_C_SOURCE 200809L
#endif


  reply	other threads:[~2011-04-13 19:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12 13:09 [PATCH v2] define _GNU_SOURCE Valentin Ochs
2011-04-13 16:10 ` build on os x 10.6.7, xcode 3.2.6 S. Cowles
2011-04-13 16:26   ` Peter Stephenson
2011-04-13 19:32     ` S. Cowles [this message]
2011-04-13 19:56     ` Bart Schaefer
2011-04-14  8:35 ` [PATCH v2] define _GNU_SOURCE Peter Stephenson
2011-04-14  9:03   ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LN8.2.00.1104131146110.23733@ckhb06 \
    --to=scowles@ckhb.org \
    --cc=Peter.Stephenson@csr.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).