From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1359 invoked from network); 3 Feb 2008 07:22:51 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham version=3.2.4 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 3 Feb 2008 07:22:51 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 90007 invoked from network); 3 Feb 2008 07:22:46 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 3 Feb 2008 07:22:46 -0000 Received: (qmail 12651 invoked by alias); 3 Feb 2008 07:22:42 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 24526 Received: (qmail 12627 invoked from network); 3 Feb 2008 07:22:42 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 3 Feb 2008 07:22:42 -0000 Received: from smtp.bredband2.net (smtp.bredband2.net [82.209.166.4]) by bifrost.dotsrc.org (Postfix) with ESMTP id 50F2980482A1 for ; Sun, 3 Feb 2008 08:22:36 +0100 (CET) Received: (qmail 23742 invoked from network); 3 Feb 2008 07:24:31 -0000 Received: from kr-lun-154-152-233-83.3.cust.bredband2.com (HELO mika.l3ib.org) ([83.233.152.154]) (envelope-sender ) by smtp.bredband2.net (qmail-ldap-1.03) with SMTP for ; 3 Feb 2008 07:24:31 -0000 Date: Sun, 3 Feb 2008 08:22:35 +0100 (CET) From: Mikael Magnusson To: zsh-workers Subject: Re: gnu cut completion as wrong as it can be, patch In-Reply-To: <237967ef0802022248k459943dboaaacb3163dc77ed1@mail.gmail.com> Message-ID: References: <237967ef0802022248k459943dboaaacb3163dc77ed1@mail.gmail.com> User-Agent: Alpine 1.00 (LNX ) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Virus-Scanned: ClamAV 0.91.2/5665/Sun Feb 3 03:35:12 2008 on bifrost X-Virus-Status: Clean On Sun, 3 Feb 2008, Mikael Magnusson wrote: > Add + qualifiers to short options that take arguments. Add said > arguments too. Remove a = from an option that does not take an > argument. Complete files (hello?). Without linewrapping the patch... diff --git a/Completion/Unix/Command/_cut b/Completion/Unix/Command/_cut index 7d7526d..b17cf7c 100644 --- a/Completion/Unix/Command/_cut +++ b/Completion/Unix/Command/_cut @@ -35,16 +35,17 @@ if _pick_variant gnu="Free Soft" unix --version; then esac _arguments \ - '(--bytes -b)'{--bytes=,-b}'['$_cut_args[bytes]']' \ - '(--characters -c)'{--characters=,-c}'['$_cut_args[characters]']' \ - '(--delimiter -d)'{--delimiter=,-d}'['$_cut_args[delimiter]']' \ - '(--fields -f)'{--fields=,-f}'['$_cut_args[fields]']' \ + '(--bytes -b+)'{--bytes=,-b}'['$_cut_args[bytes]']:list' \ + '(--characters -c+)'{--characters=,-c}'['$_cut_args[characters]']:list' \ + '(--delimiter -d+)'{--delimiter=,-d}'['$_cut_args[delimiter]']:delimeter' \ + '(--fields -f+)'{--fields=,-f}'['$_cut_args[fields]']:list' \ '-n['$_cut_args[n]']' \ '--complement['$_cut_args[complement]']' \ - '(--only-delimited -s)'{--only-delimited=,-s}'['$_cut_args[only-delimited]']' \ - '--output-delimiter['$_cut_args[output-delimiter]']' \ + '(--only-delimited -s)'{--only-delimited,-s}'['$_cut_args[only-delimited]']' \ + '--output-delimiter=['$_cut_args[output-delimiter]']:delimeter' \ '--help['$_cut_args[help]']' \ - '--version['$_cut_args[version]']' + '--version['$_cut_args[version]']' \ + '*:file:_files' else _arguments \ '-b[list specifies byte positions]:list:' \ -- Mikael Magnusson