From: Mikael Magnusson <mikachu@gmail.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: [PATCH 2/4] attr: Make zlistattr return an array, zdelattr take several attrs
Date: Tue, 3 Nov 2009 19:56:22 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.0911031955490.3783@localhost> (raw)
In-Reply-To: <alpine.LNX.2.00.0911031951480.3519@localhost>
---
Completion/Zsh/Command/_zattr | 2 +-
Src/Modules/attr.c | 39 ++++++++++++++++++++++++++++++---------
2 files changed, 31 insertions(+), 10 deletions(-)
diff --git a/Completion/Zsh/Command/_zattr b/Completion/Zsh/Command/_zattr
index 55804db..a6ae806 100644
--- a/Completion/Zsh/Command/_zattr
+++ b/Completion/Zsh/Command/_zattr
@@ -31,6 +31,6 @@ esac
if [[ $state = attrs ]]; then
if [[ -f $~line[1] ]]; then
zlistattr $~line[1] REPLY
- _wanted attrs expl 'attribute' compadd ${(0)REPLY}
+ _wanted attrs expl 'attribute' compadd $REPLY
fi
fi
diff --git a/Src/Modules/attr.c b/Src/Modules/attr.c
index cbf3d92..1a9c323 100644
--- a/Src/Modules/attr.c
+++ b/Src/Modules/attr.c
@@ -142,12 +142,16 @@ bin_delattr(char *nam, char **argv, Options ops, UNUSED(int func))
{
int ret = 0, slen;
int symlink = OPT_ISSET(ops, 'h');
+ char *file = *argv;
- unmetafy(*argv, &slen);
- unmetafy(*(argv+1), NULL);
- if (xremovexattr(*argv, *(argv+1), symlink)) {
- zwarnnam(nam, "%s: %e", metafy(*argv, slen, META_NOALLOC), errno);
- ret = 1;
+ unmetafy(file, &slen);
+ while (*++argv) {
+ unmetafy(*argv, NULL);
+ if (xremovexattr(file, *argv, symlink)) {
+ zwarnnam(nam, "%s: %e", metafy(file, slen, META_NOALLOC), errno);
+ ret = 1;
+ break;
+ }
}
return ret;
}
@@ -164,9 +168,26 @@ bin_listattr(char *nam, char **argv, Options ops, UNUSED(int func))
if (0 < (len = xlistxattr(*argv, value, 256, symlink))) {
if (len < 256) {
char *p = value;
- if (*(argv+1))
- setsparam(*(argv+1), metafy(value, len, META_DUP));
- else while (p < &value[len]) {
+ if (*(argv+1)) {
+ if (strlen(value) + 1 == len)
+ setsparam(*(argv+1), metafy(value, len-1, META_DUP));
+ else {
+ int arrlen = 0;
+ char **array = NULL, **arrptr = NULL;
+
+ while (p < &value[len]) {
+ arrlen++;
+ p += strlen(p) + 1;
+ }
+ arrptr = array = (char **)zshcalloc((arrlen+1) * sizeof(char *));
+ p = value;
+ while (p < &value[len]) {
+ *arrptr++ = metafy(p, -1, META_DUP);
+ p += strlen(p) + 1;
+ }
+ setaparam(*(argv+1), array);
+ }
+ } else while (p < &value[len]) {
printf("%s\n", p);
p += strlen(p) + 1;
}
@@ -183,7 +204,7 @@ bin_listattr(char *nam, char **argv, Options ops, UNUSED(int func))
static struct builtin bintab[] = {
BUILTIN("zgetattr", 0, bin_getattr, 2, 3, 0, "h", NULL),
BUILTIN("zsetattr", 0, bin_setattr, 3, 3, 0, "h", NULL),
- BUILTIN("zdelattr", 0, bin_delattr, 2, 2, 0, "h", NULL),
+ BUILTIN("zdelattr", 0, bin_delattr, 2, -1, 0, "h", NULL),
BUILTIN("zlistattr", 0, bin_listattr, 1, 2, 0, "h", NULL),
};
--
1.6.5
next prev parent reply other threads:[~2009-11-03 19:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-26 21:55 [wip patch] new zsh/attr module Mikael Magnusson
2009-02-26 22:36 ` Mikael Magnusson
2009-02-27 0:48 ` Mikael Magnusson
2009-03-03 12:12 ` Peter Stephenson
2009-03-03 14:43 ` Mikael Magnusson
2009-03-03 16:35 ` Peter Stephenson
2009-03-03 16:51 ` Mikael Magnusson
2009-03-03 16:55 ` Peter Stephenson
2009-03-03 17:00 ` Mikael Magnusson
2009-11-03 18:52 ` Mikael Magnusson
2009-11-03 18:55 ` [PATCH 1/4] attr: add -h option to operate on symlinks without dereferencing Mikael Magnusson
2009-11-04 10:48 ` Peter Stephenson
2009-11-04 11:01 ` Mikael Magnusson
2009-11-04 11:36 ` Peter Stephenson
2010-09-12 11:12 ` Mikael Magnusson
2009-11-03 18:56 ` Mikael Magnusson [this message]
2009-11-05 6:51 ` [PATCH 2/4] attr: Make zlistattr return an array, zdelattr takeseveral attrs Jun T.
2009-11-05 9:48 ` Mikael Magnusson
2009-11-03 18:57 ` [PATCH 3/4] attr: dynamically allocate memory for attributes Mikael Magnusson
2009-11-03 18:57 ` [PATCH 4/4] attr: Use descriptive variables for argv and allow setting values with embedded nuls Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.0911031955490.3783@localhost \
--to=mikachu@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).